Page MenuHomePhabricator
Create Task
Maniphest T377854

[harbor] Do not clean up images currently running in production
Closed, ResolvedPublic
Actions

Description

Right now we only keep in Harbor the latest 10 images for Toolforge components. The older images are automatically cleaned up.

If we push many test images, we sometimes end up deleting the image that is currently running in production (the one specified in the toolforge-deploy repo).

We should find a way to prevent this from happening, because otherwise we get in a situation where k8s is not able to download the image for a component, and we only rely on it being cached on the k8s workers.

We used to have "immutable" tags that were never deleted, but that is also problematic because it means we fill up Harbor with images that were previously deployed but are no longer needed. Related previous task: T348538: [tools,harbor] Cleanup old production images

Related Objects

Event Timeline

fnegri created this task.Oct 22 2024, 2:43 PM
Restricted Application added a project: cloud-services-team. · View Herald TranscriptOct 22 2024, 2:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
aborrero edited projects, added User-aborrero, Toolforge (Toolforge iteration 16); removed Toolforge.Oct 22 2024, 2:44 PM
aborrero moved this task from Backlog to Radar/observer on the User-aborrero board.
Raymond_Ndibe claimed this task.Oct 25 2024, 12:00 PM
CodeReviewBot added a project: Patch-For-Review.Oct 26 2024, 1:39 AM

raymond-ndibe opened https://gitlab.wikimedia.org/repos/cloud/toolforge/maintain-harbor/-/merge_requests/35

[maintain-harbor] do not clean up images currently running in production

Raymond_Ndibe changed the task status from Open to In Progress.Oct 26 2024, 1:39 AM
Raymond_Ndibe moved this task from Next Up to In Review on the Toolforge (Toolforge iteration 16) board.
dcaro triaged this task as High priority.Oct 29 2024, 2:19 PM
dcaro moved this task from In Review to In Progress on the Toolforge (Toolforge iteration 16) board.Tue, Nov 12, 10:30 AM
CodeReviewBot added a comment.Mon, Nov 18, 8:29 AM

raymond-ndibe merged https://gitlab.wikimedia.org/repos/cloud/toolforge/maintain-harbor/-/merge_requests/35

[maintain-harbor] do not clean up images currently running in production

Maintenance_bot removed a project: Patch-For-Review.Mon, Nov 18, 8:30 AM
Raymond_Ndibe closed this task as Resolved.Tue, Nov 26, 1:50 PM
Raymond_Ndibe moved this task from In Progress to Done on the Toolforge (Toolforge iteration 16) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits