watchlist doesn't link to diffs on mobile
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Danbloch
	Thu, Oct 24, 9:02 PM

Description

Caused by T377503

Steps to replicate the issue (include links if applicable):

Go to mobile watchlist (https://en.m.wikipedia.org/wiki/Special:Watchlist)
Ensure you don't have Advanced mode enabled
Click on an entry in the list

What happens?:

Browser goes to either the page for the article which has been changed or the editor who changed it, depending on where I click.

What should have happened instead?:

Browser goes to the diff page for the edit.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Reproducible in Chrome on Android, Chrome and Firefox on Windows.

Derived Requirement

Ensure that, on the mobile watchlist with Advanced mode disabled, clicking an entry in the list navigates to the diff page for the edit.

BDD

gherkin
Feature: Watchlist Entry Links to Diff Page on Mobile

Scenario: User clicks on an entry in the mobile watchlist with Advanced mode disabled
  Given the user is on the mobile watchlist page with Advanced mode disabled
  When the user clicks on an entry in the watchlist
  Then the browser should navigate to the diff page for the edit

Test Result - Beta|Prod

Status: ✅ PASS / ❓Need More Info / ❌ FAIL
Environment: beta/xyzwiki
OS: macOS Sonoma 15.0
Browser: Chrome 130
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure Watchlist Entry Links to Diff Page

Open the mobile version of Wikipedia and navigate to the Special:Watchlist page.
Verify that Advanced mode is disabled.
Click on an entry in the watchlist.
✅❓❌⬜ AC1: Confirm that clicking the entry navigates to the diff page for the edit.

QA Results - Beta

AC	Status	Details
1	✅	T378142#10273474

QA Results - PROD

AC	Status	Details
1	✅	T378142#10273487

Details

	Subject	Repo	Branch	Lines +/-
	Partial Revert "Make sure contributor's name is on its line"	mediawiki/skins/MinervaNeue	wmf/1.43.0-wmf.28	+2 -1
	Partial Revert "Make sure contributor's name is on its line"	mediawiki/skins/MinervaNeue	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned In: T378396: Verify 1.44.0-wmf.1 deployment
T378204: Client error "TypeError: Cannot convert undefined or null to object"
T378155: Special:GlobalContributions ignores namespace in links
Mentioned Here: T378155: Special:GlobalContributions ignores namespace in links
T378204: Client error "TypeError: Cannot convert undefined or null to object"
T377503: Username overlaps watched categories

Event Timeline

Danbloch created this task.Thu, Oct 24, 9:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Oct 24, 9:02 PM

Pppery added projects: MobileFrontend, MediaWiki-Watchlist.Thu, Oct 24, 9:55 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptThu, Oct 24, 9:55 PM

Ammarpad updated the task description. (Show Details)Sat, Oct 26, 1:51 PM

Ammarpad edited projects, added MinervaNeue; removed MobileFrontend.Sun, Oct 27, 9:26 PM

Change #1083282 had a related patch set uploaded (by Ammarpad; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Partial Revert "Make sure contributor's name is on its line"

https://gerrit.wikimedia.org/r/1083282

gerritbot added a project: Patch-For-Review.Sun, Oct 27, 9:35 PM

Jdlrobson updated the task description. (Show Details)Mon, Oct 28, 2:27 AM

Change #1083282 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Partial Revert "Make sure contributor's name is on its line"

https://gerrit.wikimedia.org/r/1083282

Maintenance_bot removed a project: Patch-For-Review.Mon, Oct 28, 5:30 AM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.1; 2024-10-29).Mon, Oct 28, 6:00 AM

Jdlrobson triaged this task as High priority.Mon, Oct 28, 5:22 PM

Jdlrobson added a project: Web-Team-Backlog (FY2024-25 Q2 Sprint 3).

Jdlrobson moved this task from Needs analysis to QA on the Web-Team-Backlog (FY2024-25 Q2 Sprint 3) board.

Jdlrobson added a project: Regression.Mon, Oct 28, 5:43 PM

Jdlrobson assigned this task to Edtadros.Mon, Oct 28, 5:53 PM

Jdlrobson lowered the priority of this task from High to Medium.

Jdlrobson raised the priority of this task from Medium to High.

Change #1083874 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@wmf/1.43.0-wmf.28] Partial Revert "Make sure contributor's name is on its line"

https://gerrit.wikimedia.org/r/1083874

gerritbot added a project: Patch-For-Review.Mon, Oct 28, 5:55 PM

This ideally should be backported to production. I am not sure I will be able to do it today though :(

Change #1083874 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.43.0-wmf.28] Partial Revert "Make sure contributor's name is on its line"

https://gerrit.wikimedia.org/r/1083874

Maintenance_bot removed a project: Patch-For-Review.Mon, Oct 28, 8:30 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-28T20:30:55Z] <kharlan@deploy2002> Started scap sync-world: Backport for [[gerrit:1083874|Partial Revert "Make sure contributor's name is on its line" (T378142)]], [[gerrit:1083877|Restore missing second argument to "mapState" in QuickView.vue (T378204)]], [[gerrit:1083853|GlobalContributionsPager: Use Special:PermanentLink to construct link (T378155)]], [[gerrit:1083886|GlobalContributionsPager: Don't display external namespace in

Stashbot mentioned this in T378204: Client error "TypeError: Cannot convert undefined or null to object".Mon, Oct 28, 8:30 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-28T20:33:06Z] <kharlan@deploy2002> jdlrobson, kharlan: Backport for [[gerrit:1083874|Partial Revert "Make sure contributor's name is on its line" (T378142)]], [[gerrit:1083877|Restore missing second argument to "mapState" in QuickView.vue (T378204)]], [[gerrit:1083853|GlobalContributionsPager: Use Special:PermanentLink to construct link (T378155)]], [[gerrit:1083886|GlobalContributionsPager: Don't display external namespace in artic

Mentioned in SAL (#wikimedia-operations) [2024-10-28T20:42:19Z] <kharlan@deploy2002> Finished scap sync-world: Backport for [[gerrit:1083874|Partial Revert "Make sure contributor's name is on its line" (T378142)]], [[gerrit:1083877|Restore missing second argument to "mapState" in QuickView.vue (T378204)]], [[gerrit:1083853|GlobalContributionsPager: Use Special:PermanentLink to construct link (T378155)]], [[gerrit:1083886|GlobalContributionsPager: Don't display external namespace in

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.28; 2024-10-22).Mon, Oct 28, 9:00 PM

GMikesell-WMF claimed this task.Mon, Oct 28, 9:09 PM

GMikesell-WMF updated the task description. (Show Details)

GMikesell-WMF added subscribers: GMikesell-WMF, Edtadros.

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 15.0
Browser: Chrome 130
Device: MBA
Emulated Device: NA

Test Artifact(s):

https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Watchlist?hidepreviousrevisions=1&hidecategorization=1&hideWikibase=1&limit=250&days=3&urlversion=2

Test Steps

Test Case 1: Ensure Watchlist Entry Links to Diff Page

Open the mobile version of Wikipedia and navigate to the Special:Watchlist page.
Verify that Advanced mode is disabled.
Click on an entry in the watchlist.
✅ AC1: Confirm that clicking the entry navigates to the diff page for the edit.

2024-10-29_08-57-41.mp4.gif (894×860 px, 921 KB)

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 15.0
Browser: Chrome 130
Device: MBA
Emulated Device: NA

Test Artifact(s):

https://en.m.wikipedia.org/wiki/Special:Watchlist?hidepreviousrevisions=1&hidecategorization=1&hideWikibase=1&limit=250&days=3&urlversion=2

Test Steps

Test Case 1: Ensure Watchlist Entry Links to Diff Page

Open the mobile version of Wikipedia and navigate to the Special:Watchlist page.
Verify that Advanced mode is disabled.
Click on an entry in the watchlist.
✅ AC1: Confirm that clicking the entry navigates to the diff page for the edit.