Page MenuHomePhabricator

horizon: enable the UI to select networks on VM creation panel
Closed, ResolvedPublic

Description

As part of the migration to VXLAN/IPv6 we want to let users decide if hey want a given VM with different network settings.

We will need to enable the panel while the migration is ongoing.

See also:

Event Timeline

aborrero updated the task description. (Show Details)

Here are the two panels that are currently hidden. First, network selection:

launch_instance_networks.png (1×1 px, 265 KB)

And, port selection:

launch_instance_ports.png (1×1 px, 231 KB)

I can replace both of them in the upstream form, or prune down the network panel (or add a default, which seems like a good idea?)

Change #1110464 had a related patch set uploaded (by Andrew Bogott; author: Andrew Bogott):

[openstack/horizon/horizon@2024.1] Re-enable the network and port panel for instance creation

https://gerrit.wikimedia.org/r/1110464

Change #1110465 had a related patch set uploaded (by Andrew Bogott; author: Andrew Bogott):

[openstack/horizon/horizon@2024.1] launch-instance-model: support default network ID in the network panel

https://gerrit.wikimedia.org/r/1110465

What use case there is for the manual port selection form? If there is none, I think only re-enabling the network form would be clearer.

What use case there is for the manual port selection form? If there is none, I think only re-enabling the network form would be clearer.

I'm not sure. We certainly attach existing ports to existing VMs but I'm less sure that we do it on /new/ VMs. Presumably it would allow us to rebuild a series of VMs with the same IP, if we needed to do that...

Change #1110464 merged by Andrew Bogott:

[openstack/horizon/horizon@2024.1] Re-enable the network panel for instance creation

https://gerrit.wikimedia.org/r/1110464

Change #1110465 merged by Andrew Bogott:

[openstack/horizon/horizon@2024.1] launch-instance-model: support default network ID in the network panel

https://gerrit.wikimedia.org/r/1110465

Change #1115035 had a related patch set uploaded (by Andrew Bogott; author: Andrew Bogott):

[operations/puppet@production] Horizon: update release version for codfw1dev

https://gerrit.wikimedia.org/r/1115035

Change #1115035 merged by Andrew Bogott:

[operations/puppet@production] Horizon: update release version for codfw1dev

https://gerrit.wikimedia.org/r/1115035

This panel is now enabled in codfw1dev; the panel takes a default so that interacting with the panel is not required.

@aborrero, please give this a look and let me know if it looks correct to you, then let me know when you want it rolled out in eqiad.

I see the list includes a bunch of infrastructure networks, I assume that's only shown for admins?

I see the list includes a bunch of infrastructure networks, I assume that's only shown for admins?

When I log in as a mortal user I see three networks: lan-flat-cloudinstances2b, cloud-flat-codfw1dev-ipv4only, and wan-transport-codfw, all three 'shared = yes'.

When logged in as myself, I see those same three. Are you seeing more than three?

With my admin account I can see cloud-flat-codfw1dev, cloud-flat-codfw1dev-ipv4only, lan-flat-cloudinstances2b and wan-transport-codfw. At least wan-transport-codfw should be hidden now, and lan-flat-cloudinstances2b will need to be hidden in the future.

Change #1131090 had a related patch set uploaded (by Andrew Bogott; author: Andrew Bogott):

[openstack/horizon/horizon@main] Re-enable the network panel for instance creation

https://gerrit.wikimedia.org/r/1131090

Change #1131091 had a related patch set uploaded (by Andrew Bogott; author: Andrew Bogott):

[openstack/horizon/horizon@main] launch-instance-model: support default network ID in the network panel

https://gerrit.wikimedia.org/r/1131091

Change #1131090 merged by Andrew Bogott:

[openstack/horizon/horizon@main] Re-enable the network panel for instance creation

https://gerrit.wikimedia.org/r/1131090

Change #1131091 merged by Andrew Bogott:

[openstack/horizon/horizon@main] launch-instance-model: support default network ID in the network panel

https://gerrit.wikimedia.org/r/1131091

Change #1136025 had a related patch set uploaded (by Andrew Bogott; author: Andrew Bogott):

[openstack/horizon/horizon@main] launch-instance-model: restore setFinalSpecNetworks to upstream

https://gerrit.wikimedia.org/r/1136025

Change #1136025 merged by Andrew Bogott:

[openstack/horizon/horizon@main] launch-instance-model: restore setFinalSpecNetworks to upstream

https://gerrit.wikimedia.org/r/1136025

Change #1136122 had a related patch set uploaded (by Andrew Bogott; author: Andrew Bogott):

[operations/puppet@production] Horizon: update codfw1dev version

https://gerrit.wikimedia.org/r/1136122

Change #1136122 merged by Andrew Bogott:

[operations/puppet@production] Horizon: update codfw1dev version

https://gerrit.wikimedia.org/r/1136122