Page MenuHomePhabricator
Create Task
Maniphest T380262

Make CodeMirror compatible with ProofreadPage headers and footers
Closed, ResolvedPublicFeature
Actions

Description

Feature summary:
Modify Extension:CodeMirror to work in Extension:ProofreadPage's headers and footers.

It doesn't look very complicated, e.g. stuffing the code given in the doc to add CM to a textarea, looped for the three textareas, in a browser console, works.

Use case(s):
All pages in Page: namespace on the Wikisources.

Benefits:
The same benefits that CodeMirror has in the first place.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Page: slightly adjust the header/footer sizeBhsdmediawiki/extensions/ProofreadPagemaster+1 -1
jest: fix a test that always passesBhsdmediawiki/extensions/CodeMirrormaster+1 -0
CodeMirrorKeymap: limit the number of click listenersBhsdmediawiki/extensions/CodeMirrormaster+3 -2
Fix CodeMirror layout of header/body/footer fieldsSamwilsonmediawiki/extensions/ProofreadPagemaster+6 -8
CodeMirror: do not apply autofocus to child instancesBhsdmediawiki/extensions/CodeMirrormaster+14 -1
Do not run WikiEditor-specific function when WikiEditor is disabledBhsdmediawiki/extensions/ProofreadPagemaster+3 -1
page.edit.js: fix a few remaining issues with CodeMirror integrationMusikAnimalmediawiki/extensions/ProofreadPagemaster+11 -111
Use CodeMirrorGetModeHook instead of extension attributeMusikAnimalmediawiki/extensions/ProofreadPagemaster+31 -6
Zuul: [extensions/ProofreadPage] Add CodeMirror as phan dependencyMusikAnimalintegration/configmaster+1 -0
ext.proofreadpage.page.edit: add CodeMirror to header and footerMusikAnimalmediawiki/extensions/ProofreadPagemaster+145 -4
Customize query in gerrit

Related Objects

Event Timeline

Alien333 created this task.Nov 19 2024, 11:37 AM
Restricted Application added a project: Community-Tech. · View Herald TranscriptNov 19 2024, 11:37 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MusikAnimal moved this task from Backlog to Improvement on the MediaWiki-extensions-CodeMirror board.Nov 21 2024, 4:41 AM
MusikAnimal mentioned this in T384148: Enable syntax highlighting on Special:ExpandTemplates.Jan 22 2025, 12:15 AM
MusikAnimal changed the task status from Open to In Progress.Apr 29 2025, 2:38 AM
MusikAnimal claimed this task.
gerritbot added a comment.Apr 29 2025, 3:45 AM

Change #1139588 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/ProofreadPage@master] ext.proofreadpage.page.edit: add CodeMirror to header and footer

https://gerrit.wikimedia.org/r/1139588

gerritbot added a project: Patch-For-Review.Apr 29 2025, 3:45 AM
gerritbot added a comment.May 3 2025, 8:08 AM

Change #1139588 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] ext.proofreadpage.page.edit: add CodeMirror to header and footer

https://gerrit.wikimedia.org/r/1139588

Maintenance_bot removed a project: Patch-For-Review.May 3 2025, 8:30 AM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.28; 2025-05-06).May 3 2025, 9:00 AM
MusikAnimal added a comment.May 8 2025, 9:44 PM

Looks like this was broken with r1107061, and now there's no CodeMirror at all on Wikisource :(

I'm investigating. There are no more backport windows this week so the fix may not go live until Monday.

gerritbot added a comment.May 12 2025, 11:18 PM

Change #1144673 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/ProofreadPage@master] Use CodeMirrorGetModeHook instead of extension attribute

https://gerrit.wikimedia.org/r/1144673

gerritbot added a project: Patch-For-Review.May 12 2025, 11:18 PM
gerritbot added a comment.May 19 2025, 4:28 PM

Change #1147809 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[integration/config@master] Zuul: [extensions/ProofreadPage] Add CodeMirror as phan dependency

https://gerrit.wikimedia.org/r/1147809

gerritbot added a comment.May 21 2025, 7:46 AM

Change #1147809 merged by jenkins-bot:

[integration/config@master] Zuul: [extensions/ProofreadPage] Add CodeMirror as phan dependency

https://gerrit.wikimedia.org/r/1147809

gerritbot added a comment.May 21 2025, 12:34 PM

Change #1144673 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Use CodeMirrorGetModeHook instead of extension attribute

https://gerrit.wikimedia.org/r/1144673

Maintenance_bot removed a project: Patch-For-Review.May 21 2025, 1:30 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.3; 2025-05-27).May 21 2025, 2:00 PM
Bhsd subscribed.EditedJun 12 2025, 8:08 AM

Remaining issues:

  • The header and the footer disappear when previewing.
  • The CSS looks broken when line wrapping is disabled.
  • Code folding does not work.
Bhsd mentioned this in T393742: CodeMirrorContentModels extension attribute is ignored.Jun 12 2025, 8:09 AM
Albertoleoncio subscribed.Jun 12 2025, 8:45 PM
gerritbot added a comment.Sep 9 2025, 5:38 AM

Change #1186190 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/ProofreadPage@master] page.edit.js: fix a few remaining issues with CodeMirror integration

https://gerrit.wikimedia.org/r/1186190

gerritbot added a project: Patch-For-Review.Sep 9 2025, 5:38 AM
MusikAnimal added a comment.Sep 9 2025, 5:45 AM
In T380262#10907952, @Bhsd wrote:

Remaining issues:

  1. The header and the footer disappear when previewing.
  2. The CSS looks broken when line wrapping is disabled.
  3. Code folding does not work.

I believe r1186190 may incidentally fix #1 and #3 by using CodeMirrorChild instances. For #2, I was not able to devise a solution without potentially breaking something, given Proofread Page uses flexbox. But a nice little alternative solution came to mind, which hopefully will do for now.

@Alien333 How important would you say turning line wrapping off is to Wikisourcers? Here we're forcing it to be on.

Alien333 added a comment.Sep 14 2025, 7:51 PM
In T380262#11161076, @MusikAnimal wrote:

@Alien333 How important would you say turning line wrapping off is to Wikisourcers? Here we're forcing it to be on.

I won't claim to speak for everyone everywhere, but probably not that much? I didn't even know one could turn line wrapping off, tbh. I think that the intersection of people who know it was possible and people who routinely use it is pretty small.
It would perhaps be more of a problem for wikis where they have content much wider than tall. But then again, they already have a full-width window, so not that bad.
So in the end I think it'd be fine to force it on. If you want to be 100% sure, go ask at the mulws scriptorium; over there they have plenty of languages and different perspectives.
(Sorry for not being very responsive, a bit busy irl.)

gerritbot added a comment.Sep 15 2025, 7:47 PM

Change #1186190 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] page.edit.js: fix a few remaining issues with CodeMirror integration

https://gerrit.wikimedia.org/r/1186190

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.19; 2025-09-16); removed: MW-1.45-notes (1.45.0-wmf.3; 2025-05-27).Sep 15 2025, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 15 2025, 8:31 PM
Bhsd added a comment.EditedSep 16 2025, 6:40 PM

Sohom's comments in r1186190:

  • CodeMirror v5 breaks (this is probably okay? since it is going away)
  • If I start with the headers/footers collapsed, and then I reopen the headers and footers, they do not display anymore at all. (this works fine without CodeMirror so I think it is a issue with the integration). (fixed by r1242739)

Additional issues I find:

  • There are multiple panels for keyboard shortcuts opened at the same time. (fixed by r1243057)
  • Switching on and off CodeMirror breaks textarea heights. (fixed by r1238991)
Bhsd merged a task: T203897: CodeMirror extension In Russian Wikisource breaks the edit field of pages.Oct 1 2025, 1:41 PM
Bhsd mentioned this in T203897: CodeMirror extension In Russian Wikisource breaks the edit field of pages.
Bhsd added subscribers: Vladis13, TheDJ, • Niharika, JJMC89.
Bhsd mentioned this in T393231: Show bottom resize bar for all content models.Feb 12 2026, 3:14 AM
gerritbot added a comment.Feb 23 2026, 2:58 AM

Change #1238991 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/ProofreadPage@master] Fix CodeMirror layout of header/body/footer fields

https://gerrit.wikimedia.org/r/1238991

gerritbot added a project: Patch-For-Review.Feb 23 2026, 2:58 AM
Bhsd added a comment.EditedFeb 23 2026, 9:52 AM
  • When WikiEditor is disabled while CodeMirror 6 is enabled, #wpTextbox1 is not correctly wrapped inside .ext-codemirror-wrapper. (fixed by r1242412)
gerritbot added a comment.Feb 23 2026, 2:48 PM

Change #1242412 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/ProofreadPage@master] Do not run WikiEditor-specific function when WikiEditor is disabled

https://gerrit.wikimedia.org/r/1242412

gerritbot added a comment.Feb 23 2026, 3:49 PM

Change #1242412 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Do not run WikiEditor-specific function when WikiEditor is disabled

https://gerrit.wikimedia.org/r/1242412

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.17; 2026-02-24).Feb 23 2026, 4:00 PM
gerritbot added a comment.Feb 24 2026, 10:07 AM

Change #1243057 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/CodeMirror@master] CodeMirrorKeymap: limit the number of click listeners

https://gerrit.wikimedia.org/r/1243057

Bhsd added a comment.EditedMar 2 2026, 2:20 PM

@Alien333 commented on Discord:

  • The body should be auto-fucused instead of the footer. (fixed by r1247077)
gerritbot added a comment.Mar 2 2026, 2:45 PM

Change #1247077 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/CodeMirror@master] CodeMirror: do not apply autofocus to child instances

https://gerrit.wikimedia.org/r/1247077

gerritbot added a comment.Mar 3 2026, 4:07 AM

Change #1247077 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirror: do not apply autofocus to child instances

https://gerrit.wikimedia.org/r/1247077

gerritbot added a comment.Mar 3 2026, 4:59 AM

Change #1238991 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Fix CodeMirror layout of header/body/footer fields

https://gerrit.wikimedia.org/r/1238991

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.19; 2026-03-10); removed: MW-1.46-notes (1.46.0-wmf.17; 2026-02-24).Mar 3 2026, 5:00 AM
gerritbot added a comment.Mar 3 2026, 8:22 AM

Change #1247514 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/CodeMirror@master] jest: fix a test that always passes

https://gerrit.wikimedia.org/r/1247514

gerritbot added a comment.Mar 3 2026, 11:41 PM

Change #1243057 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirrorKeymap: limit the number of click listeners

https://gerrit.wikimedia.org/r/1243057

gerritbot added a comment.Mar 6 2026, 1:45 PM

Change #1247514 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] jest: fix a test that always passes

https://gerrit.wikimedia.org/r/1247514

Maintenance_bot removed a project: Patch-For-Review.Mar 6 2026, 2:32 PM
TheDJ added a subtask: T419236: Text area collapsed to 'silly' values..Mar 6 2026, 2:33 PM
Bhsd removed a subtask: T419236: Text area collapsed to 'silly' values..Mar 6 2026, 2:40 PM
gerritbot added a comment.Mar 13 2026, 1:28 PM

Change #1251315 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/ProofreadPage@master] Page: slightly adjust the header/footer size

https://gerrit.wikimedia.org/r/1251315

gerritbot added a project: Patch-For-Review.Mar 13 2026, 1:28 PM
gerritbot added a comment.Mar 16 2026, 2:20 AM

Change #1251315 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Page: slightly adjust the header/footer size

https://gerrit.wikimedia.org/r/1251315

Maintenance_bot removed a project: Patch-For-Review.Mar 16 2026, 2:31 AM
ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17); removed: MW-1.46-notes (1.46.0-wmf.19; 2026-03-10).Mar 16 2026, 3:00 AM
MusikAnimal mentioned this in T357794: Update CodeMirror integrations in preparation for CodeMirror 6 upgrade.Mar 18 2026, 7:38 AM
Mr._Starfleet_Command subscribed.Mar 18 2026, 8:26 PM
Bhsd added a comment.Mar 20 2026, 11:34 AM

Is there anything left for this ticket? I think all known issues have been fixed (except for CM5 which is not expected to work).

MusikAnimal closed this task as Resolved.Mar 23 2026, 10:16 PM
MusikAnimal moved this task from Improvement to Done on the MediaWiki-extensions-CodeMirror board.

Seems like the functionality is all there. Any follow-ups or bugs can be filed under new tasks.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits