Page MenuHomePhabricator

Provide context for the error message of `EntityAccessLimitException` on click
Open, Needs TriagePublic

Description

As an editor, I want to understand what the entity access limit error means when it is thrown while visiting a Wikipedia article.

Problem
Continuation of the previous ticket Fix wikidata entity usage tracking and access count. The current affected pages will have a lot of errors after the entity access limit is reached.

Acceptance Criteria

  1. Generate a popup for a short description of the error when it is clicked.
  2. Links in the popup to provide further details.
  3. Able to track the number of entity accessed in the edit page.

Event Timeline

As discussed with Cynthia, this ticket is moved to (In Preparation) column because refinement is still needed.

@seanleong-WMDE please research the following:
Option 1

  • Replace the error notification "No further details are available" with -> "Maximum number of Wikibase entities acceptable: 400"

Option 2

  • Replace the error notification "No further details are available" with a specific error notification for each page e.g: -> "Number of Wikibase entities loaded: 401/400 (Inject the entity count into the error modal)"

Change #1100126 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Scribunto@master] Improve error messages about unknown code location

https://gerrit.wikimedia.org/r/1100126

Change #1100126 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Improve error messages about unknown code location

https://gerrit.wikimedia.org/r/1100126

As discussed with Cynthia and Ifeatu,

  1. We will not be putting the entity id into the error message.
  2. We will be adding Scribunto error: in front of the error title to provide more context to the technical user.
  3. The existing runtime exception error will remain static and un-clickable.

The error message will look like this after the patch:

Scribunto Error: Too many Wikibase entities accessed. Number of Wikibase entities loaded: 3/2.

Change #1100855 had a related patch set uploaded (by Seanleong-wmde; author: Seanleong-wmde):

[mediawiki/extensions/Wikibase@master] Provide more context for the error message of EntityAccessLimitException

https://gerrit.wikimedia.org/r/1100855

Change #1101539 had a related patch set uploaded (by Seanleong-wmde; author: Seanleong-wmde):

[mediawiki/extensions/Scribunto@master] Provide more context for the error message of EntityAccessLimitException

https://gerrit.wikimedia.org/r/1101539

Change #1101539 abandoned by Seanleong-wmde:

[mediawiki/extensions/Scribunto@master] Provide more context for the error message of EntityAccessLimitException

Reason:

We will follow the existing formatting of the error message.

https://gerrit.wikimedia.org/r/1101539

Change #1100855 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Provide more context for the error message of EntityAccessLimitException

https://gerrit.wikimedia.org/r/1100855