Page MenuHomePhabricator

Anon users can't change the quality at ProofreadPage extension anymore
Closed, ResolvedPublic

Description

Author: enomil

Description:
After all the changes to Proofread Page Extension in 1.20wmf1 anon users can't change the quality of an page anymore. The main problem are the changes from proofreadPageUserName to mw.config.get( 'wgUserName' ) in proofreadpage.js. For anons the proofreadPageUserName was the IP (x.x.x.x) [1] but the wgUserName outputs null for IP users [2]. This causes problems inside the proofreadpage_body.php because it blocks when the ip user performs his request. (Hopefully this is the only problem.)

Another problem is the position of the quality input boxes for anon users. See the proofreadpage.js [3] at the function pr_add_quality_buttons, specially at the lines 949-957 (with the extrem sibling action). Get the div with the class editCheckboxes and append the span child there is much easier and works for all usergroups (it is default set and for anon it is only empty).

Anon users have the right to change the quality of a page on de.ws per Bug 27516

[1] http://de.wikisource.org/w/index.php?diff=1792330
[2] http://www.mediawiki.org/wiki/Manual:Interface/JavaScript#Page-specific
[3] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/ProofreadPage.git;a=blob;f=proofread.js;hb=ebd197c9f78afae1d2c21cca21fa5df474d80897


Version: unspecified
Severity: major

Details

Reference
bz36115

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:25 AM
bzimport added a project: ProofreadPage.
bzimport set Reference to bz36115.
bzimport added a subscriber: Unknown Object (MLST).

beau wrote:

Sorry, I wasn't aware that anonymous users could change page status. I have submitted a change I7e08c570e7c88a13f07515e2298fc003a8f3fc95 for review, which reverts the proofreadPageUserName change.

I did not understand the second part of the report.

enomil wrote:

Screenshots as registered (top) and anonymous user (bottom) and the position of the quality buttons

Two the sesond part of the bug: anonymous user doesn't have the options for marking as minor edit and for watching page, so the nextSibling action puts the quality buttons outside of the div with the class editCheckboxes. It makes more sense for having the buttons everytime at the same position (as the last child of the div) e. g. for styling like .editCheckboxes .quality4 {} (thats why they have no color at the time at german ws).

Attached:

beau wrote:

I understand now (A picture is worth a thousand words). Can you make a separate report for that issue?

enomil wrote:

Bug 36125

(In reply to comment #1)

Sorry, I wasn't aware that anonymous users could change page status. I have
submitted a change I7e08c570e7c88a13f07515e2298fc003a8f3fc95 for review, which
reverts the proofreadPageUserName change.

gerrit #5428 -- closing pending review on gerrit

There have always been restrictions on the ability of proofreading status change by anonymous users. What are the restrictions now in place, ie. what changes, and can we say that we have discussed this with the Wikisource community prior to its implementation. Bugzilla is a cloistered environment and not particularly useful for such discussions.

GOIII moved this task from Backlog to Done on the ProofreadPage board.Jun 12 2016, 3:23 AM