Page MenuHomePhabricator

<pages> transclusions allow for infinite loop
Closed, ResolvedPublic

Description

Author: beau

Description:

  1. Create an index page named Index:1 with a link to Page:1.png.
  2. Create a page Page:1.png with the following content:

<pages index="1" from="1.png" to="1.png" />

  1. Create a page in the main namespace with the following content:

<pages index="1" from="1.png" to="1.png" />

You will get: Fatal error: Maximum function nesting level of '100' reached,
aborting! This should be handled more gracefully.


Version: unspecified
Severity: normal

Details

Reference
bz36158

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:27 AM
bzimport added a project: ProofreadPage.
bzimport set Reference to bz36158.
bzimport added a subscriber: Unknown Object (MLST).

beau wrote:

I have submitted a change https://gerrit.wikimedia.org/r/#q,Ic4e878dec84a4cde8ebb455dee5370b1deaaa4f1,n,z for review. This change disables nested <pages> transclusion completely.

beau wrote:

Similar case to bug 36157. It turns out MediaWiki can handle this situation (I had enabled unconfigured xdebug extension), however the result is quite ugly: https://test2.wikipedia.org/wiki/Beau%27s_playground so I recommend the fix to be merged.

GOIII moved this task from Backlog to Done on the ProofreadPage board.Jun 12 2016, 3:23 AM