Page MenuHomePhabricator
Create Task
Maniphest T381897

Typo in HarbormasterBuildkiteBuildStepImplementation.php on Phabricator
Closed, DeclinedPublicBUG REPORT
Actions

Description

  • On line 46 of this page, "Webhook" seems better than "Webook".
  • On line 64, it seems that a "|" char is missing at the end of the line.
  • Widths of the columns of the lines 62 and 63 are shorter that widths of the columns of the line 64.

Event Timeline

Mahabarata73 created this task.Tue, Dec 10, 5:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Dec 10, 5:09 PM
Mahabarata73 updated the task description. (Show Details)Tue, Dec 10, 5:17 PM
Dzahn subscribed.Tue, Dec 10, 5:19 PM

These refer to the source repo at https://we.phorge.it/source/phorge/browse/master/src/applications/harbormaster/

Peachey88 edited projects, added Phabricator (Upstream); removed Phabricator.Tue, Dec 10, 5:53 PM
Aklapper closed this task as Declined.Tue, Dec 10, 6:03 PM

This should be reported at https://we.phorge.it/ instead as we do not use Harbormaster at all in our Wikimedia Phabricator installation.

Maintenance_bot added a project: Upstream.Tue, Dec 10, 6:29 PM
Pppery subscribed.Wed, Dec 11, 12:49 AM

https://we.phorge.it/D25852

Pppery added a comment.Wed, Dec 11, 12:54 AM

Widths of the columns of the lines 62 and 63 are shorter that widths of the columns of the line 64.

Doesn't matter in this context given Phabricator's table syntax (as you can see here)

Really long column nameReally long column name 2
qbar
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits