Page MenuHomePhabricator
Create Task
Maniphest T382506

Check the values of extra metadata
Closed, ResolvedPublic
Actions

Description

Description

When checking metadata, we can test that extra metadata is present, but we can't verify the values of that metadata. Our tests should also transform the metadata map in order to inspect the metadata values.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • better guarantees around emitted metadata

Completion checklist

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
wikifunctions: Upgrade orchestrator from 2026-01-21-135031 to 2026-01-28-071101Jforresteroperations/deployment-chartsmaster+1 -1
wikifunctions: Upgrade evaluators from 2026-01-15-194836 to 2026-01-27-063404Jforresteroperations/deployment-chartsmaster+2 -2
Update function-schemata sub-module to HEAD (160b771)Jforrestermediawiki/extensions/WikiLambdamaster+1 -1
Update function-schemata sub-module to HEAD (bc6e7bd)Jforrestermediawiki/extensions/WikiLambdamaster+1 -1
wikifunctions: Upgrade orchestrator from 2025-12-10-133418 to 2026-01-07-132737Jforresteroperations/deployment-chartsmaster+1 -1
wikifunctions: Upgrade evaluators from 2025-12-10-150641 to 2026-01-07-132938Jforresteroperations/deployment-chartsmaster+2 -2
Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Check metadata values in unit tests.repos/abstract-wiki/wikifunctions/function-orchestrator!531apineapine-metadata-valuesmain
Use function-schemata version of checkMetadata and test metadata values.repos/abstract-wiki/wikifunctions/function-evaluator!464apineapine-metadata-valuesmain
Update function-schemata sub-module to HEAD (bc6e7bd)repos/abstract-wiki/wikifunctions/wikilambda-cli!100apinesync-function-schematamain
Update function-schemata sub-module to HEAD (bc6e7bd)repos/abstract-wiki/wikifunctions/function-evaluator!462apinesync-function-schematamain
Update function-schemata sub-module to HEAD (bc6e7bd)repos/abstract-wiki/wikifunctions/function-orchestrator!511apinesync-function-schematamain
Use \!deepEqual instead of \!== (oops).repos/abstract-wiki/wikifunctions/function-schemata!313apineapine-metadata-checksmain
Update function-schemata sub-module to HEAD (03b2b73)repos/abstract-wiki/wikifunctions/function-orchestrator!510apinesync-function-schematamain
Use new, unified metadata tests.repos/abstract-wiki/wikifunctions/function-orchestrator!509apineapine-metadata-simplificationmain
Add checkMetadata utility.repos/abstract-wiki/wikifunctions/function-schemata!311apineapine-metadata-checksmain
Customize query in GitLab

Related Objects

Event Timeline

cmassaro created this task.Dec 19 2024, 3:53 PM
cmassaro added a project: Abstract Wikipedia Fix-It tasks.
Jdforrester-WMF triaged this task as Low priority.Jan 8 2025, 5:35 PM
Jdforrester-WMF moved this task from To Triage to Engineering Backlog on the Abstract Wikipedia team board.
CodeReviewBot added a project: Patch-For-Review.Dec 20 2025, 1:39 AM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/311

Draft: Add checkMetadata utility.

CodeReviewBot added a comment.Jan 5 2026, 6:25 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/311

Add checkMetadata utility.

Maintenance_bot removed a project: Patch-For-Review.Jan 5 2026, 6:30 PM
CodeReviewBot added a project: Patch-For-Review.Jan 5 2026, 9:12 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/510

Update function-schemata sub-module to HEAD (03b2b73)

CodeReviewBot added a comment.Jan 5 2026, 9:12 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/461

Update function-schemata sub-module to HEAD (03b2b73)

cmassaro mentioned this in rMSFE19f025976c0c: Update function-schemata sub-module to HEAD (03b2b73).Jan 5 2026, 9:13 PM
CodeReviewBot added a comment.Jan 5 2026, 9:16 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/99

Update function-schemata sub-module to HEAD (03b2b73)

CodeReviewBot added a comment.Jan 5 2026, 9:45 PM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/461

Update function-schemata sub-module to HEAD (03b2b73)

DMartin-WMF mentioned this in rMSFEd981d3a3df16: Update function-schemata sub-module to HEAD (03b2b73).Jan 5 2026, 9:45 PM
CodeReviewBot added a comment.Jan 6 2026, 12:38 AM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/99

Update function-schemata sub-module to HEAD (03b2b73)

CodeReviewBot added a comment.Jan 6 2026, 2:25 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/510

Update function-schemata sub-module to HEAD (03b2b73)

Maintenance_bot removed a project: Patch-For-Review.Jan 6 2026, 2:30 PM
Jdforrester-WMF changed the task status from Open to In Progress.Jan 6 2026, 2:54 PM
Jdforrester-WMF assigned this task to cmassaro.
Jdforrester-WMF edited projects, added: Abstract Wikipedia team (26Q3 (Jan–Mar)); removed: Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to In Engineering on the Abstract Wikipedia team (26Q3 (Jan–Mar)) board.
CodeReviewBot added a comment.Jan 6 2026, 2:58 PM

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/509

Use new, unified metadata tests.

CodeReviewBot added a project: Patch-For-Review.Jan 6 2026, 4:37 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/313

Use \!deepEqual instead of \!== (oops).

CodeReviewBot added a comment.Jan 6 2026, 4:51 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/313

Use \!deepEqual instead of \!== (oops).

CodeReviewBot added a comment.Jan 6 2026, 4:52 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/511

Update function-schemata sub-module to HEAD (bc6e7bd)

cmassaro mentioned this in rMSFE07c54d163907: Update function-schemata sub-module to HEAD (bc6e7bd).Jan 6 2026, 4:53 PM
CodeReviewBot added a comment.Jan 6 2026, 4:54 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/462

Update function-schemata sub-module to HEAD (bc6e7bd)

CodeReviewBot added a comment.Jan 6 2026, 4:54 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/100

Update function-schemata sub-module to HEAD (bc6e7bd)

CodeReviewBot added a comment.Jan 6 2026, 4:55 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/100

Update function-schemata sub-module to HEAD (bc6e7bd)

gerritbot added a comment.Jan 6 2026, 4:57 PM

Change #1223691 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (bc6e7bd)

https://gerrit.wikimedia.org/r/1223691

CodeReviewBot added a comment.Jan 6 2026, 4:58 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/511

Update function-schemata sub-module to HEAD (bc6e7bd)

CodeReviewBot added a comment.Jan 6 2026, 5:21 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/462

Update function-schemata sub-module to HEAD (bc6e7bd)

Jdforrester-WMF mentioned this in rMSFE6e509f1c676e: Update function-schemata sub-module to HEAD (bc6e7bd).Jan 6 2026, 5:21 PM
CodeReviewBot added a comment.Jan 7 2026, 1:27 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/509

Use new, unified metadata tests.

gerritbot added a comment.Jan 7 2026, 1:53 PM

Change #1224078 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2025-12-10-150641 to 2026-01-06-172129

https://gerrit.wikimedia.org/r/1224078

gerritbot added a comment.Jan 7 2026, 1:54 PM

Change #1224079 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-12-10-133418 to 2026-01-07-132737

https://gerrit.wikimedia.org/r/1224079

gerritbot added a comment.Jan 7 2026, 3:05 PM

Change #1224078 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2025-12-10-150641 to 2026-01-07-132938

https://gerrit.wikimedia.org/r/1224078

gerritbot added a comment.Jan 7 2026, 3:12 PM

Change #1224079 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-12-10-133418 to 2026-01-07-132737

https://gerrit.wikimedia.org/r/1224079

Jdforrester-WMF subscribed.Jan 7 2026, 3:18 PM

Initial part of this now deployed; remaining parts still In Engineering.

gerritbot added a comment.Jan 7 2026, 7:00 PM

Change #1224156 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (160b771)

https://gerrit.wikimedia.org/r/1224156

DSantamaria added a project: Essential-Work.Jan 8 2026, 1:51 PM
gerritbot added a comment.Jan 8 2026, 2:26 PM

Change #1223691 abandoned by Jforrester:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (bc6e7bd)

https://gerrit.wikimedia.org/r/1223691

gerritbot added a comment.Jan 9 2026, 9:16 AM

Change #1224156 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (160b771)

https://gerrit.wikimedia.org/r/1224156

CodeReviewBot added a comment.Jan 26 2026, 12:09 PM

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/464

Draft: Use function-schemata version of checkMetadata and test metadata values.

CodeReviewBot added a comment.Jan 26 2026, 12:18 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/531

Check metadata values in unit tests.

cmassaro moved this task from In Engineering to In Code review on the Abstract Wikipedia team (26Q3 (Jan–Mar)) board.Jan 26 2026, 12:20 PM
CodeReviewBot added a comment.Jan 27 2026, 6:33 AM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/464

Use function-schemata version of checkMetadata and test metadata values.

DMartin-WMF mentioned this in rMSFEa8ce8496c124: Use function-schemata version of checkMetadata and test metadata values..Jan 27 2026, 6:34 AM
CodeReviewBot added a comment.Jan 27 2026, 6:41 AM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/531

Check metadata values in unit tests.

cmassaro moved this task from In Code review to Needs Sign-off on the Abstract Wikipedia team (26Q3 (Jan–Mar)) board.Jan 28 2026, 11:58 AM

Moved directly fo "Needs Sign-off" because this is a test-only change.

cmassaro closed this task as Resolved.Jan 28 2026, 12:11 PM
gerritbot added a comment.Jan 28 2026, 2:42 PM

Change #1234427 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2026-01-15-194836 to 2026-01-27-063404

https://gerrit.wikimedia.org/r/1234427

gerritbot added a comment.Jan 28 2026, 2:43 PM

Change #1234428 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-01-21-135031 to 2026-01-28-071101

https://gerrit.wikimedia.org/r/1234428

gerritbot added a comment.Jan 28 2026, 3:02 PM

Change #1234427 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2026-01-15-194836 to 2026-01-27-063404

https://gerrit.wikimedia.org/r/1234427

gerritbot added a comment.Jan 28 2026, 3:08 PM

Change #1234428 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-01-21-135031 to 2026-01-28-071101

https://gerrit.wikimedia.org/r/1234428

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits