Don't check user_newtalk for anons when $wgDisableAnonTalk = true;
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	liangent
	May 11 2012, 5:47 PM

Description

Currently:

$ grep wgDisableAnonTalk * -R
includes/DefaultSettings.php:$wgDisableAnonTalk = false;
includes/Linker.php: global $wgUser, $wgDisableAnonTalk, $wgLang;
includes/Linker.php: $talkable = !( $wgDisableAnonTalk && 0 == $userId );
$

So it's only a visual hack. The whole feature should be disabled by not checking user_newtalk at all.

Version: unspecified
Severity: normal

Details

Reference: bz36776

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 12:20 AM

• bzimport added a project: MediaWiki-User-login-and-signup.

• bzimport set Reference to bz36776.

• bzimport added a subscriber: Unknown Object (MLST).

liangent created this task.May 11 2012, 5:47 PM

Added code to User::getNewtalk to prevent DB query in this case.

https://gerrit.wikimedia.org/r/16855

patch merged. closing.

Don't check user_newtalk for anons when $wgDisableAnonTalk = true;Closed, ResolvedPublicActions

Description

Details

Event Timeline

Don't check user_newtalk for anons when $wgDisableAnonTalk = true;
Closed, ResolvedPublic
Actions