Page MenuHomePhabricator

OH-AFT - Able to insert invalid date and URL in web citation template
Closed, InvalidPublic

Description

Author: a.sejpal

Description:
Repro image with IE10

Repro Steps :-

-> Log in wikimedia
-> Select any article & Choose the Edit options.
-> Click on "cite" options from command bar in Edit options.
-> Select the Template Citi/ Web template from drop down
-> Popup page will open with "Web-Citation" title.
-> In the "Access date" Text box -> Type Characters, symbols, junk characters Etc.

Date field allows to choose the invalid "access date"


Version: unspecified
Severity: minor

attachment Repro _Date.zip ignored as obsolete

Details

Reference
bz37435

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:23 AM
bzimport added a project: WikiEditor.
bzimport set Reference to bz37435.
bzimport added a subscriber: Unknown Object (MLST).

a.sejpal wrote:

Screen_Repro

There should be validation for all fields. why we are allowing the end users to insert symbols/ Junk characters in other field like name etc.

Wikimedia don't have proper validation for the Date & URL fields. End-user are able to insert the anything for Date & URLS. Invalid URLS & date to !

Attached:

2012-06-10_00h59_18.png (642×1 px, 150 KB)

This is an English Wikipedia script, not part of the MediaWiki software or any of its plugins.

Marking as invalid as such, since there is nothing we can do here.

See also https://en.wikipedia.org/wiki/MediaWiki:Common.js/edit.js

sumanah wrote:

Abhinav, if you'd like to fix this, you can go to English Wikipedia and add validation to that JavaScript there, or add your request for date and URL validation to the discussion page at https://en.wikipedia.org/wiki/MediaWiki_talk:Common.js/edit.js .

It should probably be using the jQuery UI date picker module (which presumably doesn't have this bug, if it does, it should be reported upstream to the jquery bug tracker).