Page MenuHomePhabricator

Skin.php coding typo in line 1506
Closed, ResolvedPublic

Description

Author: guriluzi82-wikipedia

Description:
it is found in 1.4.2 actually, not 1.4.0, (do not have the option).

in Skin.php, there is a function "makeKnownLinkObj", the second "wfProfileIn"
seems to be "wfProfileOut".

for patch:

1506c1506

< wfProfileOut( $fname );

wfProfileIn( $fname );

Version: 1.4.x
Severity: normal
OS: Linux
Platform: PC

Details

Reference
bz1949

Revisions and Commits

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:18 PM
bzimport set Reference to bz1949.
bzimport added a subscriber: Unknown Object (MLST).

guriluzi82-wikipedia wrote:

patch to solve typo in Skin.php line 1506

Attached:

Fix applied in CVS HEAD and REL1_4, thanks for the catch.

For future reference, try to make your diffs with the -u option as this provides
some context and makes it easier to a) see what the patch does from reading it
and b) automatically merge the patch when the file has been changed.

The order of arguments should also be original, _then_ new file; this diff seems
to be reversed.

epriestley added a commit: Unknown Object (Diffusion Commit).Mar 4 2015, 8:15 AM