Page MenuHomePhabricator

Urls with [ and ] do not display properly
Closed, ResolvedPublic

Description

Author: corey.burger

Description:
Urls such as
http://www.privacyinternational.org/article.shtml?cmd[347]=x-347-65428 do not
display correctly.

My though is that they would need to be escaped in an easy manner. One possible
way would be to use quotes for this. Basically tell the renderer to ignore any [
or ] from " to a close ".


Version: 1.4.x
Severity: minor

Details

Reference
bz1951

Revisions and Commits

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:18 PM
bzimport set Reference to bz1951.
bzimport added a subscriber: Unknown Object (MLST).

A couple quick notes for reference: [ and ] are not legal URL characters, so _must_ be escaped per RFC 2396 2.4.3.

We're lax in what we accept, though, so if it's not ambiguous we could take them and do the escaping ourselves.

However [ and ] are special syntax characters to the wiki, used as delimiters for URL and wiki links, so it needs to be done quite carefully if done at
all.

corey.burger wrote:

It would be a lot nicer if non-RFC-compliant URL's didn't exist.

rowan.collins wrote:

Tentatively marking as a dupe of bug 343, based on Brion's comment re the
relevant RFC.

*** This bug has been marked as a duplicate of 343 ***

Diffusion added a commit: Unknown Object (Diffusion Commit).Mar 4 2015, 8:24 AM