Page MenuHomePhabricator

LanguageId.php update request
Closed, ResolvedPublic

Description

Author: fratmess

Description:
I decided to make very minor change to the LanguageId.php.
Please update the LanguageId.php in the 1.4 CVS tree with the attached file.

Thank you.

For your information, the only change in this revision is the removal of the
following text:

  1. This localisation is originally based on a file kindly donated by the folks at

MIMOS

  1. http://www.asiaosc.org/enwiki/page/Knowledgebase_Home.html #

I decided to remove the text, because:

  1. The translation they (MIMOS) provided was Malaysian translation (so we had to

retranslate/rewrite them in most part), and it was long time ago [2003], so most
of the current Indonesian translation are not based on the original MIMOS
Malaysian translation (mostly because of new strings, changed strings, etc.),

  1. Plus, I think it is considered an advertisement to mention MIMOS (MIMOS is a

government-owned for-profit Malaysian R&D company), because the donation they
provided to the Indonesian translation were so small today (the text probably
still relevant one or two years ago, but certainly not today) -- the exposure
outweighs the amount of donation, that is,

  1. Most of the current Indonesian translation are done by other parties (not

MIMOS; the current Indonesian translation are mostly done by me and other
Wikipedians),

  1. As far as I know, no other translations (language files) ever done the same

thing (mention a company name in their translation),

Thank you.


Version: 1.4.x
Severity: enhancement

Details

Reference
bz2071

Revisions and Commits

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 8:26 PM
bzimport set Reference to bz2071.
bzimport added a subscriber: Unknown Object (MLST).

fratmess wrote:

LanguageId.php

attachment LanguageId.php ignored as obsolete

avarab wrote:

Removed the patch keyword, it's not a patch, please submit one.

fratmess wrote:

I don't know how to produce a patch, but here is the diff.
For your information, I am just removing a few lines of comments from the
beginning of the file.

3,5d2
< # This localisation is originally based on a file kindly donated by the folks
at MIMOS
< # http://www.asiaosc.org/enwiki/page/Knowledgebase_Home.html
< #

Thank you.

fratmess wrote:

Patch for LanguageId.php file

attachment LanguageId.php.patch.txt ignored as obsolete

fratmess wrote:

I have submitted the patch for the LanguageId.php file (the language file to be
updated).

zigger wrote:

REL1_4 patch for LanguageId.php

Patch made from supplied diff.

attachment LanguageId.php.2071.REL1_4.patch ignored as obsolete

zigger wrote:

HEAD patch for LanguageId.php

attachment LanguageId.php.2071.HEAD.patch ignored as obsolete

zigger wrote:

HEAD patch for LanguageId.php (b)

Added auto-documentation comments.

Attached:

zigger wrote:

REL1_4 patch for LanguageId.php (b)

Added auto-documentation comments.

Attached:

Fixed in HEAD, does that suffice?

Diffusion added a commit: Unknown Object (Diffusion Commit).Mar 4 2015, 8:25 AM