! (not patrolled) sign shown on recent changes for new pages edited (thus autopatrolled) by admins' edit.
Steps to reproduce:
RC still shows ! as unpatrolled page creation.
Version: unspecified
Severity: minor
Marking wontfix, this is not a bug, this is by design.
This right here is the fundamental difference between:
.. which is a system where markers are put in the page history, indicating which version is stable etc. - review in FlaggedRevisions applies to the entire page at that point in time, not the individual edits themselves).
When reviewing a revision in FlaggedRevisions, it means the page as it is at that revision is OK. So any edits before that revision are no longer relevant. And if there is a problem, the user fixes the problem and marks his new version as the review point.
and
.. which is a system where markers are put on the individual revisions, indicating that the edit itself (the "difference") is patrolled. So if there are 3 unpatrolled edits to a page, one is vandalism, one is a typo change, and one a big rewrite of the article. Then one can patrol those edits individually as small chunks. So it could a patrolled someone follows a diff-link to the typo change and marks it as patrolled. That should not patrol the vandal edit from earlier, as the user hasn't even seen that content.
When patrolling a revision in Patrolling, it means the revision (the change made to the page in that revision) is dealt with. Which means it was either OK, or a later edit has addressed the problem.
I don't think this is by design:
Just to clarify - this bug applies to sites which mark new pages with !, I have not checked sites which mark all diffs.
(In reply to comment #2)
I don't think this is by design:
It is. Trust me, this has always been the case and likely will not change because this is the system as it was designed and what users wanted when they requested it to be enabled on their wiki.
It is based on the patrolling of individual edits, to distribute the work-load while also not causing unworkable workflows where one can't make a casual edit without having to be aware of the entire page. For that there is FlaggedRevisions.
- So far I remember, when admin/autopatrolled edits the page, then all
previous changes have been marked as patrolled - this comes from assumption
that if you edit it, then you deal with what was there before.
No, this has never been the case and by design should not.
- If the "Patrolling" from above applied, then the "patrol this" link should
not disappear from page, otherwise it's not possible to mark it as patrolled.
It is not there neither in particular revision display (the first of the page)
nor on history page. So RC remains with ! marks although it in fact has been
patrolled.
What do you mean when you say the link should not disappear? What link where? When does it disappear when it should not?
Regarding discoverability of the patrol link for the first edit, this is a known problem and has to do with database performance. Apparently it is expensive to calculate that link for the first revision of the page.
See also:
Just to clarify - this bug applies to sites which mark new pages with !, I have
not checked sites which mark all diffs.
Its the same, except that patrol-links for edits after the first one are more visible than patrol-links for the first edit.