Page MenuHomePhabricator
Create Task
Maniphest T43765

Autoedit changes unintended form field
Closed, ResolvedPublic
Actions

Description

I've run across a nasty bug in Semantic Forms (2.5.1) while doing an autoedit via the API where the autoedit changes the first character of another Template field that was not part of the intended edit.

This is the autoedit command I'm executing (via python-simplemediawiki)

c = wiki.call({'action': 'sfautoedit', 'form': 'Book', 'target': title, 'Book[Cover]': 'Cover for ' + book['printouts']['Has Amazon ASIN'][0] + '.jpg'})

It is targeting this Form:

http://rwbookclub.com/wiki/Form:Book

The behavior is very odd. It does update the Book[Cover] field as intended, but it changes the value of any *dates* in the templates.

Here is an example diff:

http://rwbookclub.com/w/index.php?title=Wired_for_War:_The_Robotics_Revolution_and_Conflict_in_the_21st_Century&curid=884&diff=4584&oldid=4575

Note that "November" has been changed to "Povember" in all cases, including *other* templates.

It isn't always a P either, see this diff:

http://rwbookclub.com/w/index.php?title=Among_Others&curid=898&diff=4594&oldid=4592

"November" became "Aovember".

Version: unspecified
Severity: major

Details

Reference
bz41765

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:12 AM
• bzimport added a project: MediaWiki-extensions-Page_Forms.
• bzimport set Reference to bz41765.
thingles created this task.Nov 4 2012, 1:58 PM
Yaron_Koren added a comment.Nov 4 2012, 3:05 PM

Re-assigning to f.trott.

thingles added a comment.Nov 5 2012, 1:43 PM

Additional information. I use this same autoedit capability on another wiki and had never seen this behavior with a timestamp being changed. So, I had a hunch. The only difference between those two forms was that this one had "restricted" set on the field that was getting changed.

So, I modified the form and removed "restricted" from the "Added on" field and this behavior went away.

http://rwbookclub.com/w/index.php?title=Fooled_by_Randomness%3A_The_Hidden_Role_of_Chance_in_Life_and_in_the_Markets&diff=4975&oldid=4973

Only happens with date fields that are set to restricted from what I can see.

thingles added a comment.Nov 5 2012, 1:44 PM

Here is the diff on the form that made the bug go away:

http://rwbookclub.com/w/index.php?title=Form:Book&curid=269&diff=4964&oldid=4154

thingles added a comment.Nov 7 2012, 1:11 PM

Moving from Critical to Major since this only happens if the field is set to restricted.

Foxtrott added a comment.Nov 7 2012, 9:51 PM

Fixed in https://gerrit.wikimedia.org/r/32313

thingles added a comment.Feb 4 2013, 9:03 PM

This fix doesn't seem to have ever been committed back into the main release. I'm seeing the same problem again on another wiki using new code.

Foxtrott added a comment.Apr 6 2013, 5:22 PM

Is this still an issue with the latest dev version?

Foxtrott added a comment.May 1 2013, 4:50 PM

I think this should be fixed. Please re-open if this is still an issue.

Luke081515 removed a subscriber: • wikibugs-l-list.Jan 28 2016, 6:11 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptJan 28 2016, 6:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits