Page MenuHomePhabricator

Pre validation of username for ACC experiment is inaccurate
Closed, ResolvedPublic


All valid fields

See the screenshots of me trying to register one of my accounts.

Version: master
Severity: normal


Screen_Shot_2012-11-07_at_16.17.16.png (621×369 px, 46 KB)



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:47 AM
bzimport set Reference to bz41849.

Created attachment 11325
but not allowed


Screen_Shot_2012-11-07_at_16.17.26.png (427×335 px, 30 KB)

You're right, unfortunately. Client-side validation in account creation is hampered by bug 40648 "can't validate username against blocking extensions like AntiSpoof." Technical discussion should continue there.

Do you think client-side validation is useful as it is, given that it can be misleading and you only discover some problems with form input by submitting it?

Maybe the green checkmark shouldn't turn on for the username field. It means "no apparent errors with this field", not "this is going to work". It's possible for extensions to complain about the other fields on form submissions, but I haven't seen this happen on enwiki for password and e-mail.

swalling wrote:

Yes, AntiSpoof and other extensions don't yet play nice with the client-side validation.

This version is solely for testing purposes, to try and understand whether updating validation will have any measurable benefits for end users.

When/if we move to productize this, we'll definitely need to resolve bug 40648 and similar dependencies from extensions that add more checks than are in core.

  • This bug has been marked as a duplicate of bug 40648 ***