Page MenuHomePhabricator

Thumbnails nested at more than two levels don't work.
Closed, InvalidPublic

Description

Author: avarab

Description:
Putting a thumbnail within an image caption like:

[[Image:Mk Berlin Tram 6.jpg|thumb|500px|asdf[[Image:Mk Berlin Tram
6.jpg|thumb|250px|asdf]]]]

works perfectly, but any deeper nesting than that will break, for example:

[[Image:Mk Berlin Tram 6.jpg|thumb|500px|asdf[[Image:Mk Berlin Tram
6.jpg|thumb|250px|asdf[[Image:Mk Berlin Tram 6.jpg|thumb|125px|asdf]]]]]]

Does not work as expected.

See the URL for a testcase.


Version: unspecified
Severity: normal
URL: http://commons.wikimedia.org/wiki/User:%C3%86var_Arnfj%C3%B6r%C3%B0_Bjarmason/Nested

Details

Reference
bz2412

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 8:33 PM
bzimport set Reference to bz2412.
bzimport added a subscriber: Unknown Object (MLST).

Michael.Keppler wrote:

Just a wild guess, but I think it works for 2 levels because the parser scans
for image links where the description contains a link (which should be the only
place where links in links are allowed). And by chance this second link may also
be an image inclusion instead of a wiki link.
I don't see any necessity for nested links/images with more links. Do you have
any real use case in mind or did you "just notice" it? I strongly vote for INVALID.

avarab wrote:

(In reply to comment #1)

I don't see any necessity for nested links/images with more links. Do you have
any real use case in mind or did you "just notice" it? I strongly vote for

INVALID.

No I don't have any real use case in mind, however the parser should accept
nested statements.

Putting a link in the second thumb image description render
the whole expression unparsed:

[[Image:Info.jpg|200px|thumb|Bla foo is :
[[Image:Info.jpg|100px|thumb|oh[[Accueil]] ]] ]]

Note [[Accueil]] link at the end.

Are users really supposed to put a thumb as a thumb description anyway ? :)

dunc_harris wrote:

I don't really see why this is needed anyway. I'm with Mike on this one. It looks terribly ugly and
probably would create more trouble that it fixes. A second image now won't go into the caption of the first
image at all.