Page MenuHomePhabricator

Warning notices from User.php after change in 1.162
Closed, ResolvedPublic

Description

Author: zigger

Description:
On local test wikis, I am getting this warning notices from php, since User.php
1.162 :

Notice: Trying to get property of non-object in .../User.php on line 534

A second notice is produced once after logging-in, and three times after a new
installation during "Granting user permissions..." :

Notice: Undefined variable: changed in .../User.php on line 1279

N.B. These installations are not using memcached.


Version: 1.5.x
Severity: normal

Details

Reference
bz2538

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:36 PM
bzimport set Reference to bz2538.
bzimport added a subscriber: Unknown Object (MLST).

zigger wrote:

(In reply to comment #0)

On local test wikis, I am getting this warning notices from php, since User.php
1.162 :
...
N.B. These installations are not using memcached.

The PHP version was 5.0.0 in these tests.

Whoops, forgot to check for non-objects. Fix checked in.