Page MenuHomePhabricator

mcc.php doesn't work with new WMF memcached config
Closed, ResolvedPublic

Description

mcc.php uses $wgMemCachedServers only:

$mcc = new MWMemcached( array( 'persistent' => true/*, 'debug' => true*/ ) );
$mcc->set_servers( $wgMemCachedServers );

Which doesn't work with the current WMF config for memcached:

reedy@fenari:/home/wikipedia/common$ mwscript eval.php enwiki

var_dump( $wgMemCachedServers );

array(1) {

[0]=>
string(15) "127.0.0.1:11000"

}

reedy@fenari:/home/wikipedia/common$ mwscript mcc.php commonswiki

server

127.0.0.1:11000

I guess it should depend on $wgMainCacheType. If it is CACHE_MEMCACHED use $wgMemCachedServers. If it's a string, use $wgObjectCaches[$wgMainCacheType]['servers']

Also, should this be classed as a WMF only script? If so, it should probably be moved to the WikimediaMaintenance extension.

Logging as a TODO/reminder. I might get round to fixing this before anyone else, but I'm not planning on fixing it now


Version: unspecified
Severity: minor

Details

Reference
bz43688

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:24 AM
bzimport set Reference to bz43688.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to comment #1)

Damn it.

https://gerrit.wikimedia.org/r/42500

Merged by Reedy on the 16th of January... What else is left to do for this bug?