Page MenuHomePhabricator
Create Task
Maniphest T45757

SemanticForms Special:FormStart needlessly requires Javascript
Closed, ResolvedPublic
Actions

Description

Author: wiki-dev

Description:
Replace JS redirect with HTML redirect

SemanticForms version: 2.5.1

When creating a page through Form:Whatever, the subsequent Special:FormStart page uses a Javascript redirect to proceed to the formedit page. This breaks the form creation process in browsers that do not support Javascript such as Lynx, any browser whose user disabled Javascript for security or aesthetic considerations, and hypothetical future browsers.

I have attached a proposed patch to SF_FormStart.php to use a plain HTML redirect.

Version: unspecified
Severity: trivial

Attached:

SF_FormStart.patch793 BDownload

Details

Reference
bz43757

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:29 AM
• bzimport added a project: MediaWiki-extensions-Page_Forms.
• bzimport set Reference to bz43757.
• bzimport created this task.Jan 9 2013, 1:55 AM
Yaron_Koren added a comment.Jan 9 2013, 1:59 AM

Won't regular forms fail anyway, if you use a browser without Javascript enabled?

• bzimport added a comment.Jan 11 2013, 11:32 PM

wiki-dev wrote:

Dropping priority to trivial if that is the case.

For the forms, saving works but preview and diff use JS redirects. I don't see a quick fix for these. In theory, the server-side code could do whatever the redirect triggers and skip the redirection step, but it looks like it will take some effort to rearrange things to work that way. I will work on it if I have the time.

If I am the only user to care about this, consider reclassifying this ticket as a enhancement request to make simple features work without Javascript.

Yaron_Koren added a comment.Dec 27 2013, 1:52 AM

I just added in this patch (or a variant of it) - thanks! For the record, I'm not really trying to avoid excess use of Javascript; but using HTML directly definitely seems like a cleaner solution.

Luke081515 removed a subscriber: • wikibugs-l-list.Jan 28 2016, 6:07 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptJan 28 2016, 6:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits