Page MenuHomePhabricator

[Enotif] Strange email notification when someone made no changes.
Closed, ResolvedPublic

Description

Author: stas-fomin

Description:
We use MediaWiki 1.4.5 + Enotif 2.0.0, but I think the problem remains ( I look
though CVS 1.5 codes).

Consider the following scenario:

  1. We have non-empty article "TheArticle".
  2. Alice watched "TheArticle".
  3. Bob opens "TheArticle" for editing, set "watch this page" checkbox, made no

changes, but press "Save article" button.

  1. Alice receive notification like "Bob edited TheArticle. _This is new page_".
  2. Alice fear that Bob "clear or recreate" "TheArticle".

I think the problem is UserMailer.php/composeCommonMailtext:
in lines: (lastest UserMailer.php from CVS contains similar lines...)

if ($article->mOldid) {
    $body = str_replace('$NEWPAGE', wfMsg(

'email_notification_lastvisitedrevisiontext' ), $body);

    .....
} else {
    $body = str_replace('$NEWPAGE', wfMsg( 'email_notification_newpagetext'

), $body );

    .....
}

that is if "oldid" is not set, the software sends notification about "New page".
But "oldid" is not set the no changes made also...


Version: 1.5.x
Severity: normal
URL: http://meta.wikipedia.org/wiki/Enotif

Details

Reference
bz2742

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:39 PM
bzimport set Reference to bz2742.
bzimport added a subscriber: Unknown Object (MLST).

This is fully fixed -- but only in my special edition "EnotifWiki", see
http://meta.wikipedia.org/wiki/Enotif and
http://sourceforge.net/projects/enotifwiki.

The developers of MediaWiki did not yet commit all of my changes

If you want, please try my version EnotifWiki for MediaWiki 1.5beta2. This
evening (UTC) I will upload EnotifWiki for MediaWiki 1.5beta3 version.
Please monitor the sourceforge releases.

stas-fomin wrote:

I think that the bug severity="minor", and I will be completely satisfied, I the
bug will be fixed with Target Milestone=1.5.
I just want to notify developers about this bug.
I should wait 1.5 release (I our company we use 3 installations of MediaWiki
"1.4.5+ENotif 2.0+our patches"), this bug is not so important for us to remerge
ENotif in MediaWiki again.
Thank you for quick reply.