Page MenuHomePhabricator

Get "add" button related DOM remnants out of jQuery.wikibase.claimlistview and don't use 'wb-claim' template for "add" button
Closed, ResolvedPublic

Description

Even though with bug 44745 being solved, the toolbar went out of the claimlistview widget, the DOM which contains the "add" button is still there. The DOM should probably go and be generated where the "add" button is being generated since that DOM doesn't really belong to the widget. If a list of claims should only be displayed and not editable (e.g. during diff views where we don't display the edit buttons) there is no point in having this piece of DOM.

Also, the jQuery.wikibase.claimlistview is currenlty abusing the 'wb-claim' template for the row which displays that "add" button. This is quite confusing and as a result there is some weird code in claimlistview that has to differentiate whether a row is an actual claim or just that row with the "add" button.


Version: unspecified
Severity: normal

Details

Reference
bz45673

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:15 AM
bzimport set Reference to bz45673.
bzimport added a subscriber: Unknown Object (MLST).
Danwe created this task.Mar 3 2013, 9:11 PM

Verified in Wikidata demo sprint 35-3

Restricted Application added a project: Wikidata. · View Herald TranscriptJan 28 2016, 6:00 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald Transcript