Page MenuHomePhabricator

Notice: Undefined property: CentralAuthUser::$mHomeWiki
Closed, ResolvedPublic

Description

Get a notice about CentralAuthUser::$mHomeWiki on CentralAuthUser.php line 815 frequently.

Not hurting anything, just annoying.


Version: master
Severity: minor

Details

Reference
bz46301

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:28 AM
bzimport set Reference to bz46301.
bzimport added a subscriber: Unknown Object (MLST).
csteipp created this task.Mar 19 2013, 12:14 AM

I got this running php maintenance/migratePass1.php on two local wikis configured for "Simulating SUL2 behavior on a single-instance development machine" per https://www.mediawiki.org/wiki/Extension:CentralAuth ; I had not noticed this error until now.

The notice is now on line 833 in method attemptAutoMigration, where it is logging

"Singleton migration for '$this->mName' on " . $this->mHomeWiki );

It looks like attemptAutoMigration() should be setting mHomeWiki to chooseHomeWiki(), but I put a debug print in the latter and it wasn't called before PHP warns.

The debug.log "[CentralAuth] Attaching local user Foo bar@testwiki by 'primary'" always has an '@testwiki' in it, so seems to figure out the user's wiki fine. "Just annoying" indeed.

Change 80325 had a related patch set uploaded by Mattflaschen:
Cache a variable locally before it is reset on the instance

https://gerrit.wikimedia.org/r/80325

Change 80325 merged by jenkins-bot:
Cache a variable locally before it is reset on the instance

https://gerrit.wikimedia.org/r/80325

This is no longer showing up on my test install, so I think it's fixed