Page MenuHomePhabricator

Make sure notification counts are reset after user changes subscription options
Closed, ResolvedPublic


Not sure if this is handled yet, when a notification type is dismissed from either the preference page or notification page, the notification count reset function should be called so a new count would be generated.

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:29 AM
bzimport added a project: Notifications.
bzimport set Reference to bz47131.

Whether this is done through the prefs or the options API, the change is handled by User::saveSettings() which does clear the user cache.

Related URL: (Gerrit Change I5244ef9f7bf9d1217c0c0df6691d8cf689c47cf5)

Forgot about the count itself needing to be updated, besides the cache. Fixed in 59016 (linked above).

-> "patch-in-gerrit" (patch-need-review is only for patches in Bugzilla)

Shit, I've been doing it wrong this whole time :P