Cloned Cite object does not clear if the parser was cloned inside a <ref> or <references>
Closed, ResolvedPublic

Description

If the parser is cloned inside a <ref> or <references> tag (e.g. if the first call to MessageCache::getParser() in the page is due to a message inside one of those tags), then the cloned Cite object created in Cite::cloneState() will have mInRef or mInReferences true and therefore the call to Cite::clearState() will not actually clear the Cite object.


Version: master
Severity: normal

bzimport added a project: Cite.Via ConduitNov 22 2014, 1:41 AM
bzimport set Reference to bz47291.
Anomie created this task.Via LegacyApr 16 2013, 7:52 PM
gerritbot added a comment.Via ConduitApr 16 2013, 7:52 PM

Related URL: https://gerrit.wikimedia.org/r/59508 (Gerrit Change Id3e91c41dc33a703b5326961fd57e1fe8ac61f5b)

gerritbot added a comment.Via ConduitApr 16 2013, 8:15 PM

https://gerrit.wikimedia.org/r/59508 (Gerrit Change Id3e91c41dc33a703b5326961fd57e1fe8ac61f5b) | change APPROVED and MERGED [by Aaron Schulz]

Add Comment

Column Prototype
This is a very early prototype of a persistent column. It is not expected to work yet, and leaving it open will activate other new features which will break things. Press "\" (backslash) on your keyboard to close it now.