Page MenuHomePhabricator

Excess white space between the bottom of the captcha image and refresh link
Closed, ResolvedPublic

Description

Details

Reference
bz47699

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:41 AM
bzimport set Reference to bz47699.
bzimport added a subscriber: Unknown Object (MLST).

The CAPTCHA only displays at that link while logged out. A comparison screenshot here would be helpful.

Thehelpfulonewiki wrote:

Screenshot showing excess white space between captcha and refresh link

Per request - I've selected the captcha so that you can see where it ends and gap between it and the refresh link.

Attached:

The CAPTCHAs vary in height. I put a min-height of 95 (which seems to be a close upper bound) to accomplish two goals:

  1. Don't scale or skew the CAPTCHA. We don't want to make it even less readable.
  2. Don't have the move jump vertically when they ask for a new CAPTCHA.

If this seems to be worse than jumping, we could look at removing the min-height. Or, we could change the CAPTCHA generation script to output fixed height images (a bigger project).

swalling wrote:

I think https://gerrit.wikimedia.org/r/#/c/61155/ will address this?

No, that's just to avoid splitting the reload text and reload image. This is about the whitespace in the CAPTCHA

See also bug 47713

Related URL: https://gerrit.wikimedia.org/r/62191 (Gerrit Change I57be0bc8aa80b9ea6148db979ad28397d2107b86)

Related URL: https://gerrit.wikimedia.org/r/62542 (Gerrit Change I003c5f1b75471cce32b149037198c314ce9489ea)

Related URL: https://gerrit.wikimedia.org/r/64203 (Gerrit Change I003c5f1b75471cce32b149037198c314ce9489ea)

Related URL: https://gerrit.wikimedia.org/r/64250 (Gerrit Change I003c5f1b75471cce32b149037198c314ce9489ea)

E3 requesting backport to wmf4 (only) with gerrit change 64250 so this change to the new Create account form can accompany the wmf4 roll-out. Low-risk since the new forms are opt-in.

Backport like bug 47801

Fix is backported to wmf4. The captcha is a little closer because it's inside the fancycaptcha-image-container, whose min-height we set to 95 so the rest of the form doesn't (well, rarely) shift up and down each time you refresh the captcha image.