Page MenuHomePhabricator

Buffer ParserService output
Closed, ResolvedPublic


We currently write out results straight to the response, which makes it impossible to properly handle and report errors once the headers are sent.
Instead we should buffer the full output before writing it to the response.

This is especially important as we are now caching out output aggressively, and we don't want to cache partial output. The VE also gets a truncated 200 OK response on such mid-write failures which will surely mess up round-tripping.

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:49 AM
bzimport added a project: Parsoid.
bzimport set Reference to bz49566.

Related URL: (Gerrit Change I944558d265b6329a87499ef9a38b4c5b9e34ca8f) (Gerrit Change I944558d265b6329a87499ef9a38b4c5b9e34ca8f) | change APPROVED and MERGED [by jenkins-bot]