Page MenuHomePhabricator

Check why DSR on DOMFragment wrappers is sometimes missing
Closed, ResolvedPublic

Description

In unpackDOMFragment, we sometimes get wrappers without DSR:

			var dsr = node.data.parsoid.dsr;
			// FIXME: Not sure why this would be missing
			if (dsr) {
				firstChild.data.parsoid.dsr = [dsr[0], dsr[1]];
			}

We should really track down when and why this is the case. A list of pages with this issue is exposed in http://parsoid.wmflabs.org:8001/topfixes/between/c28f13708fe1643acea1ed871182b2a0797b1c45/d1ae92720c4eaee391b324d566f7b91f84e72b7e.


Version: unspecified
Severity: normal

Details

Reference
bz49711

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 1:59 AM
bzimport added a project: Parsoid-DOM.
bzimport set Reference to bz49711.

Change 71166 had a related patch set uploaded by GWicke:
Bug 49711: Add debug print when dsr on wrapper is missing

https://gerrit.wikimedia.org/r/71166

Change 71166 merged by jenkins-bot:
Bug 49711: Add debug print when dsr on wrapper is missing

https://gerrit.wikimedia.org/r/71166

This does not seem to happen any more in production, and the old parser test results are no longer accessible after the rt testing migration to MySQL. Closing this as presumably fixed.