Page MenuHomePhabricator

Multiple right aligned images don't stack in non-Monobook skins
Closed, ResolvedPublic

Description

Author: rbeelaard

Description:
Besides the bug in MZ as described in the URL, there seems another bug in the common.css style
sheet used for the Classic and Nostalgia skins.
Each right aligned image is wrapped into a <div class="thumb tright">
The css file shows:
div.tright {

float: right;
margin-left:0.5em;

}
A clear:right statement is missing.
The effect: Multiple images are right aligned in a column for e.g. monobook.css (which does have a
clear:right statement), but appear in a row (or multiple rows, depending on width of window) in
Classic and Nostalgia skins.


Version: unspecified
Severity: minor
URL: http://nl.wikipedia.org/wiki/Gebruiker:RonaldB/column1#Test_samples_2

Details

Reference
bz3205

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:47 PM
bzimport set Reference to bz3205.
bzimport added a subscriber: Unknown Object (MLST).

wiki.bluefish wrote:

describes bug:1583 the same like this one here?

i added a slightly clearer example at
http://nl.wikipedia.org/wiki/Gebruiker:RonaldB/column1/sample3err

i've been fixing this in multiple articles, when spotted, just by dispersing the
images to throughout the page. This doesnt work if the page is already dense
with images, or the images belong stacked in one place.
eg the lead section often has 3 stacked infoboxes/images, creating this exact
problem. Can often be more easily seen if you "hide" the ToC.
we need a proper code fix please :)

oh, and this affects firefox and opera 6, 8, and 9b; but not IE5.01. (thats all
i have handy to test)

ayg wrote:

*** Bug 1583 has been marked as a duplicate of this bug. ***

ayg wrote:

Fixed in r16987.

Please note that the issue of consecutive floated images placed before a heading
(and therefore screwing up the section edit link) is unrelated to this, see bug
1629.

ayg wrote:

*** Bug 1494 has been marked as a duplicate of this bug. ***

This patch works only if images are thumbed. For smaller images without
"|thumb|" parameter the error exists furthermore:

with thumb:
http://de.wikipedia.org/wiki/Benutzer:Raymond/skintests2?useskin=standard
w/o thumb: http://de.wikipedia.org/wiki/Benutzer:Raymond/skintests?useskin=standard

ayg wrote:

Fixed (again) in r17073.