Page MenuHomePhabricator

history/diffs broken when page title contains an apostrophe
Closed, ResolvedPublic

Description

Author: mark_sweep

Description:
This problem affects version 1.6alpha on the live English 'pedia. The problem
is that pages with titles like "Student's t-distribution" cause problems when
displaying diffs, in particular the "title=" field in the URL and the links in
the page tabs (in Monobook) are wrong. To reproduce this, do the following:

  1. go to

http://en.wikipedia.org/w/index.php?title=Student%27s_t-distribution&action=history
(no problem there)

  1. click on any two versions and then on the "compare..." button
  2. the page that comes up has the wrong URL title= field and a different, but

also wrong, page title, for example:
http://en.wikipedia.org/w/index.php?title=Student&diff=21545885&oldid=20540703

Note how the title= field in that last URL indicates that the diff is about the
article "Student", not "Student's t-distribution". The links to "article",
"discussion", "edit this page", etc. as well as "rollback" all pertain to
"Student", not to "Student's t-distribution".


Version: 1.6.x
Severity: normal

Details

Reference
bz3218

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:45 PM
bzimport set Reference to bz3218.

Looks like some bogus JavaScript. Taking...

Incorrect quoting of escaped attribute value; cut-off but appears non-exploitable.

Fix in revision 1.86 of includes/PageHistory.php.