Page MenuHomePhabricator

When using LdapAuthentication extentions, ss_users in site_stat won
Closed, InvalidPublic

Description

Author: opera.wang

Description:


Version: 1.5.x
Severity: normal

Details

Reference
bz3277

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 8:48 PM
bzimport set Reference to bz3277.
bzimport added a subscriber: Unknown Object (MLST).

opera.wang wrote:

When using LdapAuthentication extentions, ss_users in site_stat won't updated:
in SpecialUserlogin.php:

			if ( $wgAuth->autoCreate() && $wgAuth->userExists( $u->getName() ) ) {
				if ( $wgAuth->authenticate( $u->getName(), $this->mPassword ) ) {
					$u =& $this->initUser( $u );

so the SiteStatsUpdate function won't get called.

Suggest moving these lines in /includes/SpecialUserlogin.php :

  1. Update user count
		$ssUpdate = new SiteStatsUpdate( 0, 0, 0, 0, 1 );
		$ssUpdate->doUpdate();

to function &initUser( &$u )

Is this even still valid any more?