Page MenuHomePhabricator

[SF] Default values incorrectly applied when editing existing pages
Closed, ResolvedPublic

Description

I just did an update from master and did a form edit with bad results. It looks like the current master (a3d5b54b47365c3b8f7b13ae6289473464442cec) doesn't want to keep all current template values. Using that commit resulted in a very bad form edit that didn't read any of the current values. The Edit with Form screen reverted to defaults instead of using the current values.

Reverting to (2e5567a1e8f6df84c3879e19e4a4805248731be1) resolved the issue


Version: master
Severity: major

Details

Reference
bz50833

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:50 AM
bzimport set Reference to bz50833.

Note, this is the diff of the bad edit. It's a little confusing because some of these fields I did change:

http://wikiapiary.com/w/index.php?title=Ultipedia&diff=273776&oldid=260530

Note that Audited, Active values should *not* have changed.

Also, the form edit screen didn't have the Image in it.

I used "undo" on that change, then reverted to the previous commit and did the same edit and worked as expected.

http://wikiapiary.com/w/index.php?title=Ultipedia&diff=273779&oldid=273778

I changed the title from "Semantic Forms master loses current form/template values" to "[SF] Some Boolean values change from "Yes" to "No"".

What's "the Image" that you're talking about?

The field

{{{field|Image|uploadable|image preview|default=Default website image.png}}}

on this form

http://wikiapiary.com/wiki/Form:Website

also reverted back to default when edited with the current master.

I checked out master again, did Edit with Form and then did a Show Changes to see what it was not keeping (without editing anything). It lost values in text fields and checkboxes. It seems like the ones that lost value are mostly (maybe all) ones that have defaults specified.

That makes sense - I retitled it again.

I think this is fixed now; thanks for the bug report.

I pulled 8add8efadb8976c5dafb34870a9dc5039e13cbc5 and verified that the defaults are not being applied on an existing value.