Page MenuHomePhabricator

Format of alias data is inconsistent in SetAliases
Closed, ResolvedPublic

Description

Depending on if I am removing an alias (e.g. in the middle of the array), adding one and whatnot, the way the alias data gets saves varys:

old_id: 105

old_text: {"label":{"en":"Soho"},"description":[],"aliases":{"en":["brown","orange","red"]},"claims":[],"links":[],"entity":["item",27]}
old_flags: utf-8

  • 106. row ******* old_id: 106 old_text: {"label":{"en":"Soho"},"description":[],"aliases":{"en":{"1":"orange","2":"red"}},"claims":[],"links":[],"entity":["item",27]}

old_flags: utf-8


Version: master
Severity: major

Details

Reference
bz51192

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz51192.
bzimport added a subscriber: Unknown Object (MLST).
aude created this task.Jul 11 2013, 7:12 PM

Change 73316 had a related patch set (by Addshore) published:
Entity removeAliases now resets array keys

https://gerrit.wikimedia.org/r/73316

Change 73797 had a related patch set uploaded by Michał Łazowik:
(51192) Resolve data inconsistency in patcher.

https://gerrit.wikimedia.org/r/73797

Change 73797 abandoned by Michał Łazowik:
(bug 51192) Resolve data inconsistency in patcher.

Reason:
Per last patch set review

https://gerrit.wikimedia.org/r/73797

Change 73316 merged by Jeroen De Dauw:
Entity removeAliases now resets array keys

https://gerrit.wikimedia.org/r/73316

Verified in Wikidata demo time July 17th