Page MenuHomePhabricator

Encode subjects in page change notification emails
Closed, ResolvedPublic

Description

Author: shimono

Description:

from https://bugzilla.mozilla.org/show_bug.cgi?id=307731

subject of mail notification from MW 1.5rc4 is not encoded when using 2-byte
UTF-8 charactors (like Japanese).
it should be encoded by B-encode for mail header.

  1. or some special settings in MW to do this :p
  2. if so, it should be enable by default.

Version: 1.5.x
Severity: normal

Details

Reference
bz3407

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:49 PM
bzimport set Reference to bz3407.
bzimport added a subscriber: Unknown Object (MLST).

shimono wrote:

in include/UserMailer.php, we should add wfQuotedPrintable(), i think.

% diff UserMailer.php mediawiki-1.5rc4/includes/UserMailer.php
327c327

< $this->subject = wfQuotedPrintable( $subject );

$this->subject = $subject;

uieoa wrote:

Russian wikipedia is also affected by this bug.
Please, fix it.

robchur wrote:

(In reply to comment #2)

Russian wikipedia is also affected by this bug.
Please, fix it.

As are all the other Wikipedias, and any other wiki using MediaWiki. Just bear
with us while someone proposes a patch, reviews and commits it.

The version is set to 1.5rc4. Has this been fixed in a release version, like 1.5.2?

Created attachment 1175
Patch for HEAD

  • (bug 3407) Fix encoding of subject and from/to headers on notification mails; userMailer() now takes a MailAddress wrapper object instead of a raw string to abstract things a level.

Attached: