Page MenuHomePhabricator

Certification templates not parsed correctly
Closed, ResolvedPublic


Author: kwwilliams

Per the failure to display the certification template tables in (live version appears to be rooted in Parsoid. This means that it must be a different bug than 50589 but may be related to 44498.

Version: unspecified
Severity: normal
See Also:



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:05 AM
bzimport added a project: Parsoid.
bzimport set Reference to bz52296.

It is unrelated to 44498. I've been investigating this and the parser introduces an empty <td></td> when parsing {{Certification Table Top}}. This doesn't happen when I copy the wikitext verbatim and parse it on its own. So, just an edge case which should be fixable relatively easily.

kwwilliams wrote:

Based on ssastry's commment, I went ahead and did a "subst" on "Certification Table Top" and "Certification Table Bottom". It got worse: and

Change 76842 had a related patch set uploaded by Subramanya Sastry:
WIP: (Bug 52296) Delete empty autoinserted tags in the last DOM pass

The subst-related parse issues are unrelated to the bug that we are fixing here. But, the patch above deals with the empty-cell scenarios that break the table on the Metallica album page.

Change 76842 merged by jenkins-bot:
(Bug 52296) Delete empty autoinserted tags in the last DOM pass

This fix has now been deployed and verified that User:Kww/certtable now shows up correctly in VE.

I am going to reopen Metallica album page for editing.

Closing -- please reopen if you see a problem.

kwwilliams wrote:

Please don't reenable editing on that page until 52254 is also fixed.

Yes, I noticed the other related bug and didn't re-enable it. I meant to update the bug report, but I got sucked into verifying other bug fixes.