Page MenuHomePhabricator

Do not allow to add "category:" prefix as category name in UploadWizard
Closed, ResolvedPublic

Description

In UploadWizard if we add category:foo to category input-box it adds category:category:foo too image's page!

please add possibility to remove Category: prefix from category-input box if user entered it.


Version: unspecified
Severity: enhancement

Details

Reference
bz52444

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:46 AM
bzimport set Reference to bz52444.
bzimport added a subscriber: Unknown Object (MLST).

david.narvaez wrote:

This was fixed in

http://git.wikimedia.org/commit/mediawiki/core.git/4894793ab60ea0a245372cb472150b4ed79d19f4

so now it doesn't matter if you use category:test or test.

Can someone reproduce it, or should we assume this was fixed with https://gerrit.wikimedia.org/r/#/c/83047/ ?

it is not fixed completely now it add category to images correctly (without two prefix) but at the UI when we add Category:foo in the category textbox it says this category doesn't exist ( we should some cleaning code for UI)

david.narvaez wrote:

(In reply to comment #2)

Can someone reproduce it, or should we assume this was fixed with
https://gerrit.wikimedia.org/r/#/c/83047/ ?

I don't understand this question, didn't my previous comment imply this cannot be reproduced any more and this bug should be closed as fixed?

david.narvaez wrote:

(In reply to comment #3)

it is not fixed completely now it add category to images correctly (without
two
prefix) but at the UI when we add Category:foo in the category textbox it
says
this category doesn't exist ( we should some cleaning code for UI)

That's a separate bug.

(In reply to comment #4)

I don't understand this question, didn't my previous comment imply this
cannot be reproduced any more and this bug should be closed as fixed?

I think I might have misunderstood your comment; and also the link you pasted was broken ;-) I'm closing the bug now if you're sure this is resolved.

david.narvaez wrote:

(In reply to comment #6)

I think I might have misunderstood your comment; and also the link you pasted
was broken ;-) I'm closing the bug now if you're sure this is resolved.

Yeah, I just noticed the issue with the link, it's a bug in Gitblit. Thanks for managing the bug!