Page MenuHomePhabricator

CirrusSearch's forceSearchIndex --deletes isn't finding any deletes
Closed, ResolvedPublic

Description

CirrusSearch's forceSearchIndex --deletes isn't finding any deletes. To recreate:

  1. Create a page.
  2. Configure your elasticsearch hosts to something bogus.
  3. Delete it. You should see an error deleting the document from search.
  4. In CirrusSearch run this:

php forceSearchIndex.php --deletes --from 1970-01-01T00:00:00Z

Expected:
This reports that it picked up your delete and searches for your document don't see it.

Actual:
This reports that it found no documents and searches for your document see it.

I believe this to be caused by us filtering out log_page = 0 rows in our query to logging to harvest deletes. Deletes seem to always write 0 into that column. Restores write the id of the restored page, which isn't useful to us anyway.


Version: unspecified
Severity: major

Details

Reference
bz52612