Page MenuHomePhabricator

data-mw attribute is stripped out of parsoid tests
Closed, ResolvedPublic

Description

Author: orbit

Description:
In mediawiki.Util.js:911, the attribute data-mw is being stripped out. The !parsoidOnly path correctly strips the attribute, but the 'else' path erroneously strips it.

A quick test of fixing line 911 broke about 150 tests. These tests should be updated to expect the data-mw attribute.


Version: unspecified
Severity: normal

Details

Reference
bz53492

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:59 AM
bzimport added a project: Parsoid-Tests.
bzimport set Reference to bz53492.

Turns out this is not that bad as feared. About 29 tests require their results updated (accounting for 150 test failures in all modes). Most of the fixes required are from the data-mw patch I pushed a few days back -- of course, I forgot to update tests and we didn't catch it because data-mw was being stripped. On it now.

Change 82521 had a related patch set uploaded by Subramanya Sastry:
(Bug 53492) Updated tests + code to not strip data-mw in parsoid mode

https://gerrit.wikimedia.org/r/82521

Change 82521 merged by jenkins-bot:
(Bug 53492) Updated tests + code to not strip data-mw in parsoid mode

https://gerrit.wikimedia.org/r/82521