Page MenuHomePhabricator

OutputPage.php ignores $wgCookiePath, $wgCookieDomain
Closed, ResolvedPublic

Description

Author: jernst+wikimedia.org

Description:
Line 460 in OutputPage.php is:

setcookie( $name, $val, $exp, '/' );

This hard-codes the path, and ignores the domain for cookies configured to as
$wgCookiePath, $wgCookieDomain in the settings. I suppose this is an oversight
(cookies set in all other places seem to use the settings).

The correct version would be:

global $wgCookiePath, $wgCookieDomain;
setcookie( $name, $val, $exp, $wgCookiePath, $wgCookieDomain );

Version: 1.5.x
Severity: normal

Details

Reference
bz3591

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:50 PM
bzimport set Reference to bz3591.
bzimport added a subscriber: Unknown Object (MLST).

jernst+wikimedia.org wrote:

still present in 1.5.0

Got removed in the 1.6 branch.