Page MenuHomePhabricator

SubPageList not showing the subpages right for other pages?
Closed, InvalidPublic

Description

Did a test of SubPageList on this page

http://wikiapiary.com/wiki/User:Thingles/Scratch1

and it isn't showing what I would expect.

Then, on this page:

http://wikiapiary.com/wiki/User:Thingles

It does show the right things.


Version: master
Severity: normal
Whiteboard: aklapper-moreinfo

Details

Reference
bz54771

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:26 AM
bzimport set Reference to bz54771.
bzimport added a subscriber: Unknown Object (MLST).

There is a serious bug with parser function argument handling in ParserHooks 1.1. Please upgrade to 1.2.

Please update this ticke after upgrading.

Updated ParserHooks to 6f51ee6 and SubPageList to bb425b4 and now the test page shows those other pages:

http://wikiapiary.com/wiki/User:Thingles/Scratch1

However, the format parameter doesn't seem to be doing anything. You want a new bug for that or leave it on this?

huh - looks like I forgot to hook up this param... its implemented and working in the module itself. Shows the unit tests on their own do not suffice. Added an integration test now.

At this point I've hijacked the now resolved bug, but, I pulled ec7729ef1cb94c2a98dc4541fdca5e3ca8a89718 and the format still is always ul, regardless of what I specify. :-\

Test page: http://wikiapiary.com/wiki/User:Thingles/Scratch1

Works for me...

{{#splist:|intro=foo|format=ol}}

foo

  1. daah
    1. dddd
  2. hax

You pulled both ParserHooks and SubPageList right? The first issue in this bug was in the former, the second one in the later.

Just did a fresh pull of Ia3d3f71c426154f5799346e99e12cae185297526 and looks good:

http://wikiapiary.com/wiki/User:Thingles/Scratch1

I may have had bad wikitext or there were bad docs since I had "li" instead of "ol" as the format. I swear there was a "list" format in the doc that said it would do comma separated but I see there is no option for that in the usage page.

Looks good.

(I see the list option was removed from mw.o: https://www.mediawiki.org/w/index.php?title=Extension%3ASubPageList&diff=800478&oldid=792700)

One of the most professional feeling MW extensions I've seen. Nicely done Jeroen!