Page MenuHomePhabricator

Labels for checkboxes/radiobuttons should appear inline
Closed, DeclinedPublic

Description

Right now, the labels appear on the next line, which is counter intuitive and wastes a lot of space.

Consider using label{display:inline-block;} in the CSS for this skin.


Version: unspecified
Severity: minor

Details

Reference
bz54930

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:37 AM
bzimport added a project: Chameleon.
bzimport set Reference to bz54930.

Change 88240 had a related patch set uploaded by Huji:
(bug 54930) Labels for checkboxes/radiobuttons should appear inline

https://gerrit.wikimedia.org/r/88240

Is this still an issue. E.g. preferences look alright now.

*After* applying patch 88240, yes, they do look alright.

This is my prefs page using current master (b06f286): http://imageshack.com/a/img849/5377/1pqh.png

What's wrong with that?

In fact, bootstrap has exactly your proposed rule:

label {

display: inline-block;
font-weight: bold;
margin-bottom: 5px;

}

Oh well, I did two separate installations of Chameleon and in both cases, the labels were NOT shown on the same line as the checkboxes. Let me try to figure out where the bug is.

It may be because I was using Bootstrap 2.3.x because now that I updated to Bootstrap 3, I see what you see. Closing the bug as WORKSFORME.

Change 88240 abandoned by Foxtrott:
(bug 54930) Labels for checkboxes/radiobuttons should appear inline

Reason:
Bug was closed as WORKSFORME.

https://gerrit.wikimedia.org/r/88240