Page MenuHomePhabricator
Create Task
Maniphest T57361

HTMLForm: harmonize 'toggle' and 'multiselect' parameters and layout [CLARIFICATION REQUEST or BUG REPORT]
Open, MediumPublic
Actions

Description

Clarification request - or bug repoort.

Screenshot:

pzgk0R7.png (391×802 px, 21 KB)

I think I have found a problem in HTMLForm, let me try to explain. In E:OpenID, a new preferences tab "openid" is added, which adds sections with 'toggle' and also 'multiselect' forms via the Preferences hook.

I noticed, that with the 'toggle' type, I cannot set up a 'default' text left of the toggle checkbox, I can only set up an individual text on the right side of the toggle checkbox (using 'label-message' key) (pictured).

With the 'multiselect' option I can use 'default' to set up a text left of the checkboxes and individual label-messages on the right side, of course (pictured).

The relevant code is in onGetPreferences in E:OpenID see lines 282 seq. https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FOpenID/483c1c9dfdbbdbdddd967bd87566b3d592c7285c/OpenID.hooks.php#L282 . In the part for 'user', where I use 'toggle', setting a 'default' value does not result in a text.

Version: 1.22.0
Severity: normal

Details

Reference
bz55361

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:37 AM
• bzimport added a project: MediaWiki-HTMLForm.
• bzimport set Reference to bz55361.
• bzimport added a subscriber: Unknown Object (MLST).
Wikinaut created this task.Oct 6 2013, 8:40 AM
Wikinaut added a comment.Oct 6 2013, 8:42 AM

I also want to point out, that in my view the alignemnt of 'toggle' and also 'multiselect' checkboxes should be harmonized, I mean, the boxes should be rendered in the same pixel row on screen, regardless whether they are toggles or multiselect boxes.

matmarex updated the task description. (Show Details)May 12 2015, 7:07 PM
matmarex set Security to None.
matmarex removed a subscriber: Unknown Object (MLST).
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL