Page MenuHomePhabricator

Center GettingStarted modal in IE7
Closed, ResolvedPublic

Description

It would be good to center the modal in at least IE7 (doesn't work in IE6 either, but I'm willing to drop that in this case).

Maybe we should just do it in JavaScript, with a resize listener.


Version: master
Severity: normal

Details

Reference
bz55487

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:17 AM
bzimport set Reference to bz55487.

swalling wrote:

Screenshot from IE7 on Sauce

Attached:

(In reply to comment #0)

Maybe we should just do it in JavaScript, with a resize listener.

This might also allow more flexible layouts, which is important now that we're rolling out to other language wikis (some of which have very different text length for their translations).

See http://tutorialzine.com/2010/03/centering-div-vertically-and-horizontally/

There are also other CSS-only methods (e.g. http://benalman.com/code/test/css-centering.html which uses a bunch of nested divs) to investigate, but I haven't tested the cross-browser support yet.

Change 114347 had a related patch set uploaded by Phuedx:
Center GettingStarted modal in IE7+

https://gerrit.wikimedia.org/r/114347

(In reply to Matthew Flaschen from comment #3)

There are also other CSS-only methods (e.g.
http://benalman.com/code/test/css-centering.html which uses a bunch of
nested divs) to investigate, but I haven't tested the cross-browser support
yet.

I've opted to introduce an additional div that encloses the modal so that it and the outer container can be styled with CSS tables, which gives you vertical centering. In IE6/7 you can fall back to push down/pull up by 50% of the modal's height to achieve the same effect.

Change 114347 merged by jenkins-bot:
Center GettingStarted modal in IE7+

https://gerrit.wikimedia.org/r/114347