phuedx (Sam Smith)
Engineering Manager, Readers

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Nov 14 2014, 10:42 AM (192 w, 23 h)
Availability
Available
IRC Nick
phuedx
LDAP User
Unknown
MediaWiki User
Phuedx (WMF) [ Global Accounts ]

Recent Activity

Yesterday

phuedx updated the task description for T192622: [EPIC] Page previews post-deploy cleanup.
Fri, Jul 20, 3:30 PM · Epic, Page-Previews, Readers-Web-Kanbanana-Board, Readers-Web-Backlog
phuedx claimed T199482: Properly handle the networking errors and aborted requests.
Fri, Jul 20, 3:16 PM · Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Backlog, Page-Previews
phuedx updated the task description for T199482: Properly handle the networking errors and aborted requests.
Fri, Jul 20, 3:16 PM · Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Backlog, Page-Previews
phuedx added a comment to T199482: Properly handle the networking errors and aborted requests.

When a request abort happens, Page Previews should not switch into FETCH_COMPLETE state

Fri, Jul 20, 3:10 PM · Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Backlog, Page-Previews
phuedx updated the task description for T199482: Properly handle the networking errors and aborted requests.
Fri, Jul 20, 2:51 PM · Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Backlog, Page-Previews
phuedx added a comment to T199482: Properly handle the networking errors and aborted requests.

When a request is aborted, the counter.PagePreviewsApiFailure should not be incremented

Fri, Jul 20, 2:43 PM · Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Backlog, Page-Previews
phuedx updated the task description for T199482: Properly handle the networking errors and aborted requests.
Fri, Jul 20, 2:31 PM · Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Backlog, Page-Previews
phuedx added a comment to T199482: Properly handle the networking errors and aborted requests.

Checked all the acceptance criteria except the last one, and they are passing.

Fri, Jul 20, 2:13 PM · Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Backlog, Page-Previews
phuedx added a comment to T199482: Properly handle the networking errors and aborted requests.

☝️ per T199482#4439716.

Fri, Jul 20, 2:03 PM · Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Backlog, Page-Previews
phuedx updated the task description for T199482: Properly handle the networking errors and aborted requests.
Fri, Jul 20, 2:03 PM · Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Backlog, Page-Previews

Thu, Jul 19

phuedx moved T199066: PHP error "Revision::ensureTitle: Could not determine title for page " in SpecialMobileContributions from To Do to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Thu, Jul 19, 9:01 AM · Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Patch-For-Review, Wikimedia-log-errors, Collaboration-Team-Triage, MediaWiki-Special-pages, MobileFrontend
phuedx triaged T199066: PHP error "Revision::ensureTitle: Could not determine title for page " in SpecialMobileContributions as Normal priority.

I'll triage this as Normal for now but bring it onto the board and into Needs Code Review as there's already a fix to be reviewed /cc @ovasileva.

Thu, Jul 19, 9:00 AM · Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Patch-For-Review, Wikimedia-log-errors, Collaboration-Team-Triage, MediaWiki-Special-pages, MobileFrontend
phuedx added a comment to T199066: PHP error "Revision::ensureTitle: Could not determine title for page " in SpecialMobileContributions.

Thanks for investigating and submitting the intermediate fix, @Jdforrester-WMF. Once the error's dealt with, Readers Web should look at using ContribsPager rather than duplicating it.

Thu, Jul 19, 8:56 AM · Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Patch-For-Review, Wikimedia-log-errors, Collaboration-Team-Triage, MediaWiki-Special-pages, MobileFrontend
phuedx moved T199066: PHP error "Revision::ensureTitle: Could not determine title for page " in SpecialMobileContributions from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Thu, Jul 19, 8:53 AM · Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Patch-For-Review, Wikimedia-log-errors, Collaboration-Team-Triage, MediaWiki-Special-pages, MobileFrontend
phuedx added a project to T199066: PHP error "Revision::ensureTitle: Could not determine title for page " in SpecialMobileContributions: Readers-Web-Backlog.
Thu, Jul 19, 8:53 AM · Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Patch-For-Review, Wikimedia-log-errors, Collaboration-Team-Triage, MediaWiki-Special-pages, MobileFrontend

Wed, Jul 18

phuedx updated the task description for T192622: [EPIC] Page previews post-deploy cleanup.
Wed, Jul 18, 9:39 AM · Epic, Page-Previews, Readers-Web-Kanbanana-Board, Readers-Web-Backlog
phuedx added a comment to T184793: [EPIC] Instrument page interactions.

There may be some followup work once page previews are rolled out to Wikidata (T111231), in case the setup doesn't work out of the box there.

Wed, Jul 18, 9:39 AM · Product-Analytics, Epic, Reading-analysis, MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog

Tue, Jul 17

phuedx added a comment to T184793: [EPIC] Instrument page interactions.

From Web's POV, this epic is now done (all the AC are met and the subtasks are now closed)! Are there any outstanding issues on your side @Nuria/@Tbayer?

Tue, Jul 17, 5:10 PM · Product-Analytics, Epic, Reading-analysis, MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog
phuedx closed T196904: Some VirtualPageView are too long and fail EventLogging processing as Resolved.

The error rate of ~0.00188% is borne out by another two hours of data collected between 2:00 and 3:58 UTC.

Tue, Jul 17, 5:00 PM · User-Ryasmeen, Readers-Web-Kanbanana-Board, Page-Previews, Analytics, Readers-Web-Backlog, Analytics-EventLogging
phuedx closed T196904: Some VirtualPageView are too long and fail EventLogging processing, a subtask of T184793: [EPIC] Instrument page interactions, as Resolved.
Tue, Jul 17, 5:00 PM · Product-Analytics, Epic, Reading-analysis, MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog
phuedx added a comment to T199157: [Spike 8hrs] Sticky header instrumentation.

We need to decide whether to send multiple events per page or follow an approach similar to https://meta.wikimedia.org/wiki/Schema:MobileWikiAppPageScroll

Tue, Jul 17, 4:49 PM · Readers-Web-Kanbanana-Board, Analytics, Readers-Web-Backlog, MinervaNeue, Design
phuedx updated the task description for T199000: Remove redundant/non-critical styling rules in Minerva.
Tue, Jul 17, 4:26 PM · Readers-Web-Kanbanana-Board, MinervaNeue, Readers-Web-Backlog, CSS, User-Jdlrobson
phuedx updated the task description for T196904: Some VirtualPageView are too long and fail EventLogging processing.
Tue, Jul 17, 2:41 PM · User-Ryasmeen, Readers-Web-Kanbanana-Board, Page-Previews, Analytics, Readers-Web-Backlog, Analytics-EventLogging
phuedx updated the task description for T196904: Some VirtualPageView are too long and fail EventLogging processing.
Tue, Jul 17, 2:22 PM · User-Ryasmeen, Readers-Web-Kanbanana-Board, Page-Previews, Analytics, Readers-Web-Backlog, Analytics-EventLogging
phuedx claimed T196904: Some VirtualPageView are too long and fail EventLogging processing.
Tue, Jul 17, 2:18 PM · User-Ryasmeen, Readers-Web-Kanbanana-Board, Page-Previews, Analytics, Readers-Web-Backlog, Analytics-EventLogging
phuedx added a comment to T196904: Some VirtualPageView are too long and fail EventLogging processing.

I captured just over an hours worth of data between 12:22 and 13:29 UTC using [0] and found the following errors:

Tue, Jul 17, 2:16 PM · User-Ryasmeen, Readers-Web-Kanbanana-Board, Page-Previews, Analytics, Readers-Web-Backlog, Analytics-EventLogging
phuedx added a comment to T196904: Some VirtualPageView are too long and fail EventLogging processing.

Excellent! Thanks, @Nuria. I'll try that out now.

Tue, Jul 17, 8:49 AM · User-Ryasmeen, Readers-Web-Kanbanana-Board, Page-Previews, Analytics, Readers-Web-Backlog, Analytics-EventLogging

Mon, Jul 16

phuedx added a comment to T196904: Some VirtualPageView are too long and fail EventLogging processing.

@elukey: As discussed, could you grab today's VirtualPageView-related processing errors from eventlog1002 and put them somewhere accessible like @mforns did in T196904#4303746?

Mon, Jul 16, 6:19 PM · User-Ryasmeen, Readers-Web-Kanbanana-Board, Page-Previews, Analytics, Readers-Web-Backlog, Analytics-EventLogging
phuedx added a comment to T184793: [EPIC] Instrument page interactions.

@Tbayer: Can this be resolved once T196904: Some VirtualPageView are too long and fail EventLogging processing is?

Mon, Jul 16, 6:16 PM · Product-Analytics, Epic, Reading-analysis, MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog
phuedx added a comment to T198525: Can't log into mobile on Commons.

I can now login to https://commons.m.wikimedia.org and when I do I see the CentralAuth cookies being set with a domain of commons.m.wikimedia.org 👍

Mon, Jul 16, 12:23 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, MediaWiki-Authentication-and-authorization, Wikimedia-General-or-Unknown
phuedx updated subscribers of T198525: Can't log into mobile on Commons.

Thanks to @pmiazga for deploying the change in my (unexpected!) absence.

Mon, Jul 16, 12:04 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, MediaWiki-Authentication-and-authorization, Wikimedia-General-or-Unknown
phuedx added a comment to T198525: Can't log into mobile on Commons.

I've scheduled ☝️ for deployment during today's European Mid-day SWAT deployment.

Mon, Jul 16, 8:51 AM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, MediaWiki-Authentication-and-authorization, Wikimedia-General-or-Unknown

Fri, Jul 13

phuedx added a comment to T196904: Some VirtualPageView are too long and fail EventLogging processing.

So, the errors should be a lot less frequent but not disappear, no?

Fri, Jul 13, 3:52 PM · User-Ryasmeen, Readers-Web-Kanbanana-Board, Page-Previews, Analytics, Readers-Web-Backlog, Analytics-EventLogging
phuedx updated subscribers of T196904: Some VirtualPageView are too long and fail EventLogging processing.

@elukey was good enough to check the logs on eventlog1002:

Fri, Jul 13, 1:18 PM · User-Ryasmeen, Readers-Web-Kanbanana-Board, Page-Previews, Analytics, Readers-Web-Backlog, Analytics-EventLogging
phuedx reassigned T196904: Some VirtualPageView are too long and fail EventLogging processing from phuedx to Ottomata.

I don't have access to eventlog1002 so I don't think that I can sign this off. Over to you for now, @Ottomata!

Fri, Jul 13, 12:57 PM · User-Ryasmeen, Readers-Web-Kanbanana-Board, Page-Previews, Analytics, Readers-Web-Backlog, Analytics-EventLogging
phuedx added a comment to T197700: Do not fire/abort AJAX request when it is not necessary.
  • The number of successful API requests has dropped steadily from 400000-600000/min to ~60000/min;
Fri, Jul 13, 9:49 AM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog
phuedx added a comment to T197700: Do not fire/abort AJAX request when it is not necessary.

Thanks for the ping, @Krinkle. I didn't address the increase in the API Request Failures in my comment and I should have.

Fri, Jul 13, 6:49 AM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog
phuedx closed T197700: Do not fire/abort AJAX request when it is not necessary as Resolved.
Fri, Jul 13, 5:09 AM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog
phuedx closed T197700: Do not fire/abort AJAX request when it is not necessary, a subtask of T192622: [EPIC] Page previews post-deploy cleanup, as Resolved.
Fri, Jul 13, 5:09 AM · Epic, Page-Previews, Readers-Web-Kanbanana-Board, Readers-Web-Backlog
phuedx added a comment to T197700: Do not fire/abort AJAX request when it is not necessary.

Per T197700#4421696.

Fri, Jul 13, 5:08 AM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog

Thu, Jul 12

phuedx claimed T197700: Do not fire/abort AJAX request when it is not necessary.
Thu, Jul 12, 5:10 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog
phuedx moved T197700: Do not fire/abort AJAX request when it is not necessary from Needs QA to Ready for Signoff on the Readers-Web-Kanbanana-Board board.
Thu, Jul 12, 5:10 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog
phuedx closed T198619: Send the Accept-Language header with RESTBase API request for page preview requests, a subtask of T188164: Popups don‘t support language variant conversion and {{lang}} template, as Resolved.
Thu, Jul 12, 4:43 PM · Epic, Services (watching), Parsoid, Readers-Web-Backlog (Tracking), Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, MediaWiki-Language-converter, Chinese-Sites, Page-Previews
phuedx closed T198619: Send the Accept-Language header with RESTBase API request for page preview requests as Resolved.

Per T198619#4420254.

Thu, Jul 12, 4:43 PM · Chinese-Sites, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Readers-Web-Kanbanana-Board, Services (blocked), Readers-Web-Backlog, Page-Previews
phuedx added a comment to T188134: Increase usage of noexcerpt class in IPA and pronunciation related templates.

I'll keep this task bookmarked to refer to if Readers Web sees similar requests in future too. Thanks, both!

Thu, Jul 12, 12:52 PM · Reading-Web-Local-Wiki-Issues, Reading-Infrastructure-Team-Backlog, Page Content Service
phuedx awarded T188134: Increase usage of noexcerpt class in IPA and pronunciation related templates a Yellow Medal token.
Thu, Jul 12, 12:47 PM · Reading-Web-Local-Wiki-Issues, Reading-Infrastructure-Team-Backlog, Page Content Service
phuedx awarded T186728: Record and aggregate page previews a Love token.
Thu, Jul 12, 12:42 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Analytics-Kanban

Wed, Jul 11

phuedx added a comment to T191532: Mobile page issues - instrument page issues.

💪

Wed, Jul 11, 4:13 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings
phuedx updated subscribers of T199282: Regression: Increase in time to first interactive; lead paragraph doesn't move on Barack Obama due to mw-empty-elt.

Not sure if this is a regression or not. Unless the XPath queries have changed dramatically during refactoring, I don't think that we've been normalising whitespace when searching for paragraphs with content before the infobox /cc @pmiazga.

Wed, Jul 11, 9:44 AM · Readers-Web-Kanbanana-Board, Regression, Performance, Readers-Web-Backlog

Tue, Jul 10

phuedx updated the task description for T199005: Talk overlay "issues" are not visible in A/B test.
Tue, Jul 10, 4:11 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Patch-For-Review, Page-Issue-Warnings, Readers-Web-Backlog
phuedx updated the task description for T199157: [Spike 8hrs] Sticky header instrumentation.
Tue, Jul 10, 10:44 AM · Readers-Web-Kanbanana-Board, Analytics, Readers-Web-Backlog, MinervaNeue, Design
phuedx added a comment to T197729: wikidiff2 creating ins and del elements with single empty character element.

@Jdlrobson gave additional context for T197729#4410014 in the parent task:

Tue, Jul 10, 10:13 AM · WMDE-QWERTY-Sprint-2018-07-17, WMDE-QWERTY-Sprint-2018-07-03, Patch-For-Review, Readers-Web-Backlog (Design), MediaWiki-History-or-Diffs, wikidiff2

Mon, Jul 9

phuedx added a comment to T197491: Implement new design for moved paragraphs in diffs on mobile.

☝️ per T197491#4400205.

Mon, Jul 9, 11:40 AM · Patch-For-Review, Readers-Web-Kanbanana-Board, MobileFrontend, Readers-Web-Backlog
phuedx added a parent task for T197729: wikidiff2 creating ins and del elements with single empty character element: T197491: Implement new design for moved paragraphs in diffs on mobile.
Mon, Jul 9, 11:39 AM · WMDE-QWERTY-Sprint-2018-07-17, WMDE-QWERTY-Sprint-2018-07-03, Patch-For-Review, Readers-Web-Backlog (Design), MediaWiki-History-or-Diffs, wikidiff2
phuedx added a subtask for T197491: Implement new design for moved paragraphs in diffs on mobile: T197729: wikidiff2 creating ins and del elements with single empty character element.
Mon, Jul 9, 11:39 AM · Patch-For-Review, Readers-Web-Kanbanana-Board, MobileFrontend, Readers-Web-Backlog

Fri, Jul 6

phuedx added a comment to T196904: Some VirtualPageView are too long and fail EventLogging processing.

Thanks, @Ryasmeen

Fri, Jul 6, 4:42 PM · User-Ryasmeen, Readers-Web-Kanbanana-Board, Page-Previews, Analytics, Readers-Web-Backlog, Analytics-EventLogging

Wed, Jul 4

phuedx added a comment to T197700: Do not fire/abort AJAX request when it is not necessary.

IMHO we shouldn't count aborted requests as counter.PagePreviewsApiFailure. This will create a noise in our dashboards. This graph supposed to show an API errors (4xx/5xx responses) but now it will be populated with both errors and aborted HTTP calls which makes it worthless

Wed, Jul 4, 5:17 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog
phuedx added a comment to T184681: Document how to run performance tests on real phones.

Sure. I'll poke the engineers on the team to see if they'd be interested in trying this out.

Wed, Jul 4, 11:00 AM · Readers-Web-Backlog (Tracking), Mobile, Documentation, Performance-Team
phuedx added a comment to T191528: Mobile page issues - allow page issues to display different severity levels.

What about using a sprite? The worst case performance impact would be:

Wed, Jul 4, 10:57 AM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings, Design

Tue, Jul 3

phuedx added a comment to T197932: Display section issues modal.

Editor currently works with /^\/editor\/(\d+|all)$/
Isn't consistency more important?

Tue, Jul 3, 11:10 AM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog

Mon, Jul 2

phuedx updated the task description for T198619: Send the Accept-Language header with RESTBase API request for page preview requests.
Mon, Jul 2, 4:16 PM · Chinese-Sites, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Readers-Web-Kanbanana-Board, Services (blocked), Readers-Web-Backlog, Page-Previews
Pchelolo awarded T198619: Send the Accept-Language header with RESTBase API request for page preview requests a Love token.
Mon, Jul 2, 11:43 AM · Chinese-Sites, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Readers-Web-Kanbanana-Board, Services (blocked), Readers-Web-Backlog, Page-Previews
phuedx added a subtask for T188164: Popups don‘t support language variant conversion and {{lang}} template: T198619: Send the Accept-Language header with RESTBase API request for page preview requests.
Mon, Jul 2, 11:42 AM · Epic, Services (watching), Parsoid, Readers-Web-Backlog (Tracking), Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, MediaWiki-Language-converter, Chinese-Sites, Page-Previews
phuedx added a parent task for T198619: Send the Accept-Language header with RESTBase API request for page preview requests: T188164: Popups don‘t support language variant conversion and {{lang}} template.
Mon, Jul 2, 11:42 AM · Chinese-Sites, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Readers-Web-Kanbanana-Board, Services (blocked), Readers-Web-Backlog, Page-Previews
phuedx added a comment to T188164: Popups don‘t support language variant conversion and {{lang}} template.

Per discussion on the Audiences-Services sync meeting, the initial step on the Page-Previews side could be to just explicitly set the Accept-Language header to the current wiki language code with no variant. <snip />

Mon, Jul 2, 11:42 AM · Epic, Services (watching), Parsoid, Readers-Web-Backlog (Tracking), Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, MediaWiki-Language-converter, Chinese-Sites, Page-Previews
phuedx created T198619: Send the Accept-Language header with RESTBase API request for page preview requests.
Mon, Jul 2, 11:41 AM · Chinese-Sites, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Readers-Web-Kanbanana-Board, Services (blocked), Readers-Web-Backlog, Page-Previews
phuedx updated subscribers of T188164: Popups don‘t support language variant conversion and {{lang}} template.

^ That's likely a question for @cscott and/or @Jdforrester-WMF and probably best asked in T43716: Support language variant conversion in Parsoid (?). Also, you might want to take a look at T195948: MCS should respect Accept-Language header, T197009: MCS should respect Accept-Language header for MW API requests, and T197792: MCS should proxy Vary and Content-Language headers header it gets from Parsoid.

Mon, Jul 2, 9:07 AM · Epic, Services (watching), Parsoid, Readers-Web-Backlog (Tracking), Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, MediaWiki-Language-converter, Chinese-Sites, Page-Previews
phuedx awarded T198552: Vandalism on Phabricator: Undo changes made (2018-07-01) a Barnstar token.
Mon, Jul 2, 4:52 AM · Cleanup, Phabricator
phuedx renamed T197931: Truncate page issues from 8gaaaaaaaa to Truncate page issues.
Mon, Jul 2, 4:47 AM · Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
phuedx renamed T193584: Prepare feature flagging gateway for mobile issues work from ztdaaaaaaa to Prepare feature flagging gateway for mobile issues work.
Mon, Jul 2, 4:36 AM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog

Sat, Jun 30

phuedx added a comment to T185233: Modern Event Platform (with EventLogging of the Future (EoF)).

It is currently difficult to debug EventLogging events. Analysts want a browser developer plugin to view the events they emit.

Sat, Jun 30, 1:09 PM · Services (watching), Analytics-EventLogging, EventBus, Analytics, Analytics-Kanban

Fri, Jun 29

phuedx added a comment to T198256: RFC: Modern Event Platform - Choose Schema Tech.

… we need schemas to be predicable, types to be static, and field names to be SQL compatible (no spaces, '.', other weird characters, etc.),

Fri, Jun 29, 2:33 PM · Operations, Services (designing), Analytics-EventLogging, EventBus, TechCom-RFC, Analytics
phuedx added a comment to T198256: RFC: Modern Event Platform - Choose Schema Tech.

Full JSONSchema spec is too featureful and extensive for easy integration between different systems.

Fri, Jun 29, 9:09 AM · Operations, Services (designing), Analytics-EventLogging, EventBus, TechCom-RFC, Analytics
phuedx added a comment to T198256: RFC: Modern Event Platform - Choose Schema Tech.

Yeah, both protobufs and thrift are options, but neither have the advantages that Avro does, yet many of the same disadvantages.

Fri, Jun 29, 9:06 AM · Operations, Services (designing), Analytics-EventLogging, EventBus, TechCom-RFC, Analytics

Thu, Jun 28

phuedx added a comment to T178665: [Spike, 8hrs] Grave kerning issues and spacing issues in PDFs generated by Chromium (and previous Electron) via "Download as PDF".

@ovasileva suggested that switching to Charter (see T181200) might get rid of this issue during today's standup ritual.

Thu, Jun 28, 5:24 PM · Readers-Web-Backlog, Readers-Web-Kanbanana-Board, Spike, Design, Proton, Electron-PDFs

Wed, Jun 27

phuedx added a comment to T196904: Some VirtualPageView are too long and fail EventLogging processing.

The alternative to that, I think, is to not call makeBeaconUrl from eventLogging, but replace it with our own function that does something similar, but chops off the encoded source_url.

Wed, Jun 27, 3:26 PM · User-Ryasmeen, Readers-Web-Kanbanana-Board, Page-Previews, Analytics, Readers-Web-Backlog, Analytics-EventLogging
phuedx closed T193584: Prepare feature flagging gateway for mobile issues work as Resolved.

Alright. This LGTM 👍

Wed, Jun 27, 12:12 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
phuedx updated the task description for T193584: Prepare feature flagging gateway for mobile issues work.
Wed, Jun 27, 12:08 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
phuedx added a comment to T193584: Prepare feature flagging gateway for mobile issues work.

It should be possible to enter group B on reading web staging or a local machine, but impossible to enter the group on production.

Wed, Jun 27, 11:22 AM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
phuedx added a comment to T193584: Prepare feature flagging gateway for mobile issues work.

For T193584#4318754:

Wed, Jun 27, 11:10 AM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
phuedx updated the task description for T193584: Prepare feature flagging gateway for mobile issues work.
Wed, Jun 27, 10:56 AM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
phuedx added a comment to T197931: Truncate page issues.

IIRC I assigned this to myself to leave a couple of notes about our discussion during yesterday's Web Team Task Grooming meeting. So…

Wed, Jun 27, 10:44 AM · Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
phuedx awarded Blog Post: Mobile web performance: the importance of the device a Like token.
Wed, Jun 27, 3:06 AM · Performance-Team
phuedx added a comment to Blog Post: Mobile web performance: the importance of the device.

Fascinating! Thanks for taking the time to write this up, @Gilles!

Wed, Jun 27, 3:06 AM · Performance-Team

Tue, Jun 26

phuedx added a comment to T193584: Prepare feature flagging gateway for mobile issues work.

…I'll create a follow on task to capture the follow-on change to the ReadingDepth instrumentation to mark events as "oversampled" (using the terminology from the NavigationTiming schema).

Tue, Jun 26, 5:13 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
phuedx claimed T197931: Truncate page issues.
Tue, Jun 26, 4:42 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
phuedx added a comment to T197932: Display section issues modal.

Can I suggest that the issue hash fragment be #/issues/section/{{n}}, which is a little more explicit (and hopefully reads like "show issues for section 1").

Tue, Jun 26, 4:09 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
phuedx added a comment to T193584: Prepare feature flagging gateway for mobile issues work.

I'm getting the following behavior and just wanted to check if that's expected.

Tue, Jun 26, 10:22 AM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog

Mon, Jun 25

phuedx claimed T193584: Prepare feature flagging gateway for mobile issues work.

As discussed in today's standup meeting, I'll create a follow on task to capture the follow-on change to the ReadingDepth instrumentation to mark events as "oversampled" (using the terminology from the NavigationTiming schema).

Mon, Jun 25, 5:11 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
phuedx moved T192725: "Add discussion" plus habitual talk page workflow can result in a duplicate signature from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board board.
Mon, Jun 25, 5:05 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), User-notice, Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, MobileFrontend
phuedx moved T192725: "Add discussion" plus habitual talk page workflow can result in a duplicate signature from Needs More Work to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Mon, Jun 25, 5:05 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), User-notice, Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, MobileFrontend

Thu, Jun 21

phuedx updated subscribers of T197857: Add @pmiazga @Niedzielski and @phuedx to the deploy-service group.

I approve this request for @Niedzielski and @pmiazga. @dr0ptp4kt will have to approve this request for me.

Thu, Jun 21, 12:11 PM · Proton, Operations, SRE-Access-Requests

Jun 20 2018

phuedx updated the task description for T139317: Allow quicksurvey to target based on edit count.
Jun 20 2018, 4:47 PM · Readers-Web-Backlog, QuickSurveys
phuedx added a comment to T197700: Do not fire/abort AJAX request when it is not necessary.

from the service side - there is some value, but it will not make any considerable difference. 99% of summary requests are stored in varnish and never reach restbase. But for remaining 1% aborting request will reduce the server load (first restbase checks Cassandra cache, and if the summary is not present it calls MCS).

Jun 20 2018, 9:17 AM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog
phuedx updated the task description for T197700: Do not fire/abort AJAX request when it is not necessary.
Jun 20 2018, 9:03 AM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog
phuedx awarded T197700: Do not fire/abort AJAX request when it is not necessary a Like token.
Jun 20 2018, 9:00 AM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog

Jun 19 2018

phuedx added a comment to T193055: [Spike, 4hrs] Should we abort in flight page previews requests?.

So it sounds like your proposal is that ABANDON_START should abort any pending API requests? Is that correct?

Jun 19 2018, 4:07 PM · Readers-Web-Kanbanana-Board, Spike, Services (watching), Performance, Page-Previews, Readers-Web-Backlog
phuedx added a comment to T181623: Chromium-render doesn't handle browser connection abort well.

Upstream described the rubric they use to prioritise bugs and clarified that they consider it low priority: https://github.com/GoogleChrome/puppeteer/issues/1505#issuecomment-393470731

Jun 19 2018, 10:47 AM · Readers-Web-Backlog (Tracking), Proton, Unplanned-Sprint-Work
phuedx updated the task description for T139317: Allow quicksurvey to target based on edit count.
Jun 19 2018, 9:04 AM · Readers-Web-Backlog, QuickSurveys

Jun 13 2018

phuedx added a comment to T193055: [Spike, 4hrs] Should we abort in flight page previews requests?.

Another possible solution:

Jun 13 2018, 3:47 PM · Readers-Web-Kanbanana-Board, Spike, Services (watching), Performance, Page-Previews, Readers-Web-Backlog