Page MenuHomePhabricator

phuedx (Sam Smith)
Engineering Manager, Readers

Projects (11)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Nov 14 2014, 10:42 AM (235 w, 6 d)
Availability
Available
IRC Nick
phuedx
LDAP User
Unknown
MediaWiki User
Phuedx (WMF) [ Global Accounts ]

Recent Activity

Yesterday

phuedx updated the task description for T223206: [Hackday] Analyse user interactions with RecentChanges.
Thu, May 23, 5:30 PM · Growth-Team, MediaWiki-Recent-changes, MobileFrontend, Readers-Web-Backlog
phuedx updated the task description for T223206: [Hackday] Analyse user interactions with RecentChanges.
Thu, May 23, 5:12 PM · Growth-Team, MediaWiki-Recent-changes, MobileFrontend, Readers-Web-Backlog
phuedx added a comment to T223206: [Hackday] Analyse user interactions with RecentChanges.

How frequently are users interaction with the highlight colour feature?

Thu, May 23, 5:11 PM · Growth-Team, MediaWiki-Recent-changes, MobileFrontend, Readers-Web-Backlog

Tue, May 21

phuedx updated subscribers of T223408: Page gets redirected randomly to former blackout page.
Tue, May 21, 3:57 PM · Readers-Web-Backlog, Performance-Team (Radar), Wikimedia-Incident
phuedx added a comment to T223408: Page gets redirected randomly to former blackout page.

Ian Marlier participated in the site maps project as his own personal initiative, but it has always been out of scope for the Performance Team. And his knowledge of that project left with him, so we're not better equipped than anyone else to do something about this.

Tue, May 21, 3:39 PM · Readers-Web-Backlog, Performance-Team (Radar), Wikimedia-Incident
phuedx closed T209377: Remove A/B test and launch to 100% as Resolved.

Per T209377#5197164 and T209377#5200890.

Tue, May 21, 2:07 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), SEO
phuedx closed T209377: Remove A/B test and launch to 100%, a subtask of T209306: [Epic] [SEO] Enable Schema.org Article linked data for all main namespace pages, as Resolved.
Tue, May 21, 2:07 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Epic, SEO
phuedx added a comment to T209377: Remove A/B test and launch to 100%.
  • Delete PageSplitTester and PageSplitTesterTest from Wikibase (this will move to Core in T209319)
  • Delete PageRandomLookup and PageRandomLookupTest
  • Delete related configuration variables from Wikibase
Tue, May 21, 2:07 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), SEO
phuedx updated the task description for T209377: Remove A/B test and launch to 100%.
Tue, May 21, 2:06 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), SEO
phuedx updated the task description for T209377: Remove A/B test and launch to 100%.
Tue, May 21, 2:06 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), SEO

Tue, May 14

phuedx updated the task description for T223206: [Hackday] Analyse user interactions with RecentChanges.
Tue, May 14, 2:26 PM · Growth-Team, MediaWiki-Recent-changes, MobileFrontend, Readers-Web-Backlog
phuedx updated the task description for T223206: [Hackday] Analyse user interactions with RecentChanges.
Tue, May 14, 2:21 PM · Growth-Team, MediaWiki-Recent-changes, MobileFrontend, Readers-Web-Backlog
phuedx updated the task description for T223206: [Hackday] Analyse user interactions with RecentChanges.
Tue, May 14, 10:31 AM · Growth-Team, MediaWiki-Recent-changes, MobileFrontend, Readers-Web-Backlog
phuedx added a comment to T223206: [Hackday] Analyse user interactions with RecentChanges.

How frequently is live updates enabled?

Tue, May 14, 10:30 AM · Growth-Team, MediaWiki-Recent-changes, MobileFrontend, Readers-Web-Backlog
phuedx updated the task description for T223206: [Hackday] Analyse user interactions with RecentChanges.
Tue, May 14, 9:45 AM · Growth-Team, MediaWiki-Recent-changes, MobileFrontend, Readers-Web-Backlog
phuedx updated the task description for T223206: [Hackday] Analyse user interactions with RecentChanges.
Tue, May 14, 9:08 AM · Growth-Team, MediaWiki-Recent-changes, MobileFrontend, Readers-Web-Backlog
phuedx added a comment to T223206: [Hackday] Analyse user interactions with RecentChanges.

@MNeisler: As discussed: I'll take How frequently to users change the limit and days parameters?

Tue, May 14, 8:57 AM · Growth-Team, MediaWiki-Recent-changes, MobileFrontend, Readers-Web-Backlog
phuedx created T223206: [Hackday] Analyse user interactions with RecentChanges.
Tue, May 14, 8:54 AM · Growth-Team, MediaWiki-Recent-changes, MobileFrontend, Readers-Web-Backlog

Thu, May 9

phuedx triaged T222632: Separate content styles from chrome styles as Normal priority.
Thu, May 9, 10:41 AM · Reading-Infrastructure-Team-Backlog, Page Content Service, Readers-Web-Backlog
phuedx added a comment to T222632: Separate content styles from chrome styles.

AIUI this isn't High priority but a nice to have. Is that correct, @bearND?

Thu, May 9, 10:40 AM · Reading-Infrastructure-Team-Backlog, Page Content Service, Readers-Web-Backlog
phuedx added a project to T222717: "article" icons need to be updated in Related Articles mobile view: Readers-Web-Backlog.
Thu, May 9, 8:38 AM · UI-Standardization, Readers-Web-Backlog, RelatedArticles
phuedx added a project to T222681: WikidataPageBanner uses a blacklist of skin names to decide 'prebodyhtml' support instead of sane feature detection: Readers-Web-Backlog.

Ping @Jdlrobson (the extension's author IIRC).

Thu, May 9, 8:36 AM · patch-welcome, Readers-Web-Backlog (Tracking), User-Jdlrobson, Technical-Debt, Wikidata-Page-Banner, Timeless, Wikidata

Wed, May 8

phuedx updated the task description for T222630: Add wikidata item link to AMC overflow menu.
Wed, May 8, 5:05 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
phuedx added a comment to T222630: Add wikidata item link to AMC overflow menu.

Setting up a development environment could be as trivial as adding the following to MobileFrontendHooks::onOutputPageParserOutput:

Wed, May 8, 5:05 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
phuedx updated the task description for T222630: Add wikidata item link to AMC overflow menu.
Wed, May 8, 4:55 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
phuedx updated the task description for T222630: Add wikidata item link to AMC overflow menu.
Wed, May 8, 4:55 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
phuedx closed T217220: Post-inheritance cleanup as Resolved.

This LGTM.

Wed, May 8, 4:45 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
phuedx closed T217220: Post-inheritance cleanup, a subtask of T212465: [EPIC] None of our View's should exhibit 2 levels of inheritance, as Resolved.
Wed, May 8, 4:45 PM · Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture), Epic, MinervaNeue
phuedx updated the task description for T217220: Post-inheritance cleanup.
Wed, May 8, 4:40 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
phuedx added a comment to T215597: QA edit tags for moderation actions.

🎉🎉🎉

Wed, May 8, 1:41 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Audiences-QA (RW-Test-Cases), Advanced Mobile Contributions

Mon, Apr 29

phuedx assigned T219846: Remove "mediawiki.template.muhogan" from RelatedArticles to Jdrewniak.
Mon, Apr 29, 5:20 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), RelatedArticles, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx closed T220159: Inline templates for mobile editor as Resolved.
Mon, Apr 29, 3:35 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
phuedx closed T220159: Inline templates for mobile editor, a subtask of T94086: [EPIC] Migrate MobileFrontend templates from hogan to inlined mustache templates, as Resolved.
Mon, Apr 29, 3:35 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend and MinervaNeue architecture), Epic
phuedx updated the task description for T220159: Inline templates for mobile editor.
Mon, Apr 29, 3:35 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
phuedx added a comment to T220159: Inline templates for mobile editor.

Increase in JS bundlesizes should be consistent with the removal of the size of ResourceLoader's mobile.startup module. Change in bytes shipped to client should be recorded.

Mon, Apr 29, 3:34 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
phuedx updated the task description for T220159: Inline templates for mobile editor.
Mon, Apr 29, 3:07 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
phuedx placed T219846: Remove "mediawiki.template.muhogan" from RelatedArticles up for grabs.
Mon, Apr 29, 2:54 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), RelatedArticles, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx moved T219846: Remove "mediawiki.template.muhogan" from RelatedArticles from Ready for Signoff to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.

There are a few nitpicks (their words) from Timo Tijhof on @Jdrewniak's change: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/RelatedArticles/+/502529/3/resources/ext.relatedArticles.cards/CardView.js

Mon, Apr 29, 2:54 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), RelatedArticles, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx claimed T219846: Remove "mediawiki.template.muhogan" from RelatedArticles.

I feel comfortable signing this off in @ovasileva's absence.

Mon, Apr 29, 1:46 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), RelatedArticles, MobileFrontend (MobileFrontend and MinervaNeue architecture)

Fri, Apr 26

phuedx added a comment to T220627: QuickSurveys EventLogging missing ~10% of interactions.

Moving to radar as further steps of code chnages to Quicksurveys to fix loading issues with JS should be done by (i think) @phuedx team?

Fri, Apr 26, 2:31 PM · Readers-Web-Backlog (Tracking), Analytics, Analytics-EventLogging, QuickSurveys
phuedx closed T218627: Upgrade MobileWebMainMenuClickTracking to have an AMC field as Resolved.

💪

Fri, Apr 26, 1:39 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
phuedx updated the task description for T218627: Upgrade MobileWebMainMenuClickTracking to have an AMC field.
Fri, Apr 26, 1:38 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
phuedx added a comment to T218627: Upgrade MobileWebMainMenuClickTracking to have an AMC field.

Document the oversampling behaviour for AMC on the schema's talk page so Tilman can understand it

Fri, Apr 26, 1:38 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
phuedx updated the task description for T218627: Upgrade MobileWebMainMenuClickTracking to have an AMC field.
Fri, Apr 26, 1:35 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
phuedx added a comment to T218627: Upgrade MobileWebMainMenuClickTracking to have an AMC field.

Sampling rate should be 100% if the user is AMC, otherwise use the configurable sampling rate
Log whether the user is in AMC mode using the new schema revision ID

Fri, Apr 26, 1:34 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
phuedx updated the task description for T218627: Upgrade MobileWebMainMenuClickTracking to have an AMC field.
Fri, Apr 26, 1:33 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
phuedx updated the task description for T218627: Upgrade MobileWebMainMenuClickTracking to have an AMC field.
Fri, Apr 26, 1:30 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
phuedx added a comment to T218627: Upgrade MobileWebMainMenuClickTracking to have an AMC field.

Update the schema to have an AMC flag

Fri, Apr 26, 1:29 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
phuedx closed T208980: [Bug] The statsv client should send a request when the page unloads so we are not losing events as Resolved.

Thanks to @Krinkle both for discussing this issue and for the prompt review and merge.

Fri, Apr 26, 1:24 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Performance-Team, MediaWiki-extensions-WikimediaEvents
phuedx added a comment to T208980: [Bug] The statsv client should send a request when the page unloads so we are not losing events.
  1. Add an annotation to https://grafana.wikimedia.org/d/000000566/overview?panelId=15&fullscreen&orgId=1 at the time when the change is deploying
Fri, Apr 26, 1:23 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Performance-Team, MediaWiki-extensions-WikimediaEvents
phuedx updated the task description for T208980: [Bug] The statsv client should send a request when the page unloads so we are not losing events.
Fri, Apr 26, 1:10 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Performance-Team, MediaWiki-extensions-WikimediaEvents
phuedx added a comment to T215597: QA edit tags for moderation actions.

AIUI this task has been blocked on a request for privileges on some (all?) of the Wikipedias. The request has stalled, insofar as it hasn't been rejected nor has it been resolved, since giving a test account such privileges on production wikis will be viewed with suspicion by the community and result in unintended outcomes.

Fri, Apr 26, 10:29 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Audiences-QA (RW-Test-Cases), Advanced Mobile Contributions
phuedx claimed T208980: [Bug] The statsv client should send a request when the page unloads so we are not losing events.
Fri, Apr 26, 8:36 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Performance-Team, MediaWiki-extensions-WikimediaEvents
phuedx added a comment to T218627: Upgrade MobileWebMainMenuClickTracking to have an AMC field.

I feel comfortable signing this off in @ovasileva's absence.

Fri, Apr 26, 8:35 AM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
phuedx claimed T218627: Upgrade MobileWebMainMenuClickTracking to have an AMC field.
Fri, Apr 26, 8:35 AM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
phuedx moved T220751: [Bug] Extreme latency due to JavaScript parsing on DOM-heavy pages from Triaged but Future to Needs Analysis on the Readers-Web-Backlog board.

Per T220751#5137468, above.

Fri, Apr 26, 8:28 AM · Performance-Team (Radar), Readers-Web-Backlog, MW-1.34-notes (1.34.0-wmf.1; 2019-04-16)
phuedx removed a project from T220751: [Bug] Extreme latency due to JavaScript parsing on DOM-heavy pages: Patch-For-Review.
Fri, Apr 26, 8:27 AM · Performance-Team (Radar), Readers-Web-Backlog, MW-1.34-notes (1.34.0-wmf.1; 2019-04-16)

Thu, Apr 25

phuedx reassigned T220751: [Bug] Extreme latency due to JavaScript parsing on DOM-heavy pages from ovasileva to nray.
Thu, Apr 25, 1:41 PM · Performance-Team (Radar), Readers-Web-Backlog, MW-1.34-notes (1.34.0-wmf.1; 2019-04-16)
phuedx edited projects for T220751: [Bug] Extreme latency due to JavaScript parsing on DOM-heavy pages, added: Readers-Web-Backlog; removed Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4).
Thu, Apr 25, 1:40 PM · Performance-Team (Radar), Readers-Web-Backlog, MW-1.34-notes (1.34.0-wmf.1; 2019-04-16)
phuedx added a comment to T220751: [Bug] Extreme latency due to JavaScript parsing on DOM-heavy pages.

I'd meant to follow up on this:

Thu, Apr 25, 1:40 PM · Performance-Team (Radar), Readers-Web-Backlog, MW-1.34-notes (1.34.0-wmf.1; 2019-04-16)

Wed, Apr 24

phuedx added a comment to T188697: Not possible to configure Minerva main menu to use Special:RandomRoot instead of Special:Random.

In the interest of fixing the discrepancy (at the expense of punting the more general problem, captured in T65459: Allow configuration of the Minerva menu), can we update MediaWiki\Minerva\Menu\Definitions::insertRandomItem to use

Wed, Apr 24, 4:50 PM · Readers-Web-Backlog, MinervaNeue
phuedx lowered the priority of T219212: Augment ReadingDepth schema with data from Page Lifecycle API from High to Normal.

I'll follow up with Kate Zimmerman and Megan Neisler about how the ReadingDepth instrumentation fits in with their priorities.

Wed, Apr 24, 4:27 PM · Reading Depth, Product-Analytics, Readers-Web-Backlog
phuedx added a comment to T214715: [Spike] How should menus work in Minerva?.

Editors can update URIs of menu items e.g. On Commons, Special:Random can be replaced with Special:Random/file (see T188697)

  • override the Definitions::insertRandomItem() to use the message cache. Instead of hardcoding Special:Random, we can load the title from Mediawiki:Random-url
Wed, Apr 24, 1:46 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Spike, Advanced Mobile Contributions
phuedx closed T214715: [Spike] How should menus work in Minerva? as Resolved.

I'm comfortable signing this off. Although one AC isn't satisfied, there's at least one task covering the community request. I'll follow up on that task with a simple suggestion that could get it unstuck.

Wed, Apr 24, 1:29 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Spike, Advanced Mobile Contributions
phuedx closed T214715: [Spike] How should menus work in Minerva?, a subtask of T214537: [EPIC] AMC Navigation - changes to main menu, as Resolved.
Wed, Apr 24, 1:29 PM · Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4)
phuedx added a comment to T214715: [Spike] How should menus work in Minerva?.

Editors can update URIs of menu items e.g. On Commons, Special:Random can be replaced with Special:Random/file (see T188697)

Wed, Apr 24, 1:11 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Spike, Advanced Mobile Contributions
phuedx added a comment to T214715: [Spike] How should menus work in Minerva?.

A menu can be converted to a JSON of template properties so that it can be rendered by JavaScript via Mustache

Wed, Apr 24, 11:30 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Spike, Advanced Mobile Contributions
phuedx updated the task description for T214715: [Spike] How should menus work in Minerva?.
Wed, Apr 24, 11:29 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Spike, Advanced Mobile Contributions
phuedx added a comment to T214715: [Spike] How should menus work in Minerva?.

A menu itself be made of multiple menus e.g. left hamburger navigation has 4 menus right now in stable
A menu uses a [Mustache] template for rendering so that it can also be used on the client.
Menus should work without JS

Wed, Apr 24, 11:28 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Spike, Advanced Mobile Contributions
phuedx updated the task description for T214715: [Spike] How should menus work in Minerva?.
Wed, Apr 24, 11:26 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Spike, Advanced Mobile Contributions
phuedx added a comment to T214715: [Spike] How should menus work in Minerva?.

A menu can have completely different contents in a given mode e.g. contributions might be in left menu on stable but in a new user menu that shows on hover in AMC mode

Wed, Apr 24, 11:23 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Spike, Advanced Mobile Contributions
phuedx updated the task description for T214715: [Spike] How should menus work in Minerva?.
Wed, Apr 24, 11:05 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Spike, Advanced Mobile Contributions
phuedx updated the task description for T214715: [Spike] How should menus work in Minerva?.
Wed, Apr 24, 9:40 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Spike, Advanced Mobile Contributions
phuedx added a comment to T214715: [Spike] How should menus work in Minerva?.

It should be possible for an extension to register a menu item in a certain menu without any knowledge of how the menu is rendered.

Wed, Apr 24, 9:40 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Spike, Advanced Mobile Contributions

Apr 18 2019

phuedx added a comment to T221181: strange virtual pageview jump on 2019-04-16-03.

Also! Thanks, everyone!

Apr 18 2019, 8:16 AM · Readers-Web-Backlog, Product-Analytics, Analytics
phuedx added a comment to T221181: strange virtual pageview jump on 2019-04-16-03.

I've been noodling on proposing that @Stashbot and/or scap create annotations in Grafana. I think such annotations would've been useful here.

Apr 18 2019, 8:16 AM · Readers-Web-Backlog, Product-Analytics, Analytics

Apr 17 2019

phuedx added a comment to T221181: strange virtual pageview jump on 2019-04-16-03.

There's a spike in VirtualPageview events today (see https://grafana.wikimedia.org/d/000000018/eventlogging-schema?orgId=1&from=1555459200000&to=1555516800000&var-schema=VirtualPageView) which appears to correspond to today's updates to the cluster. Further confirmation?

Apr 17 2019, 4:49 PM · Readers-Web-Backlog, Product-Analytics, Analytics
phuedx added a comment to T221181: strange virtual pageview jump on 2019-04-16-03.

From the SAL:

Apr 17 2019, 1:02 PM · Readers-Web-Backlog, Product-Analytics, Analytics
phuedx claimed T214715: [Spike] How should menus work in Minerva?.
Apr 17 2019, 9:59 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Spike, Advanced Mobile Contributions

Apr 15 2019

phuedx added a comment to T382: RfC: Server-side Javascript error logging.

Thanks @Tgr, that's a big pivot from what I was expecting, but hey, let's do it!

Apr 15 2019, 4:30 PM · Epic, TechCom-RFC
phuedx added a comment to T218627: Upgrade MobileWebMainMenuClickTracking to have an AMC field.

In the likely event I'm doing it wrong, after I click on the hamburger menu, I right click on Random and open that in a new window. <snip />

Apr 15 2019, 11:50 AM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions

Apr 12 2019

phuedx added a comment to T220627: QuickSurveys EventLogging missing ~10% of interactions.

And when do events for QuickSurveyInitiation and QuickSurveysResponses trigger?

Apr 12 2019, 5:05 PM · Readers-Web-Backlog (Tracking), Analytics, Analytics-EventLogging, QuickSurveys
phuedx added a comment to T220627: QuickSurveys EventLogging missing ~10% of interactions.

@ovasileva: This might benefit from some investigation on our side too.

Apr 12 2019, 4:28 PM · Readers-Web-Backlog (Tracking), Analytics, Analytics-EventLogging, QuickSurveys

Apr 10 2019

phuedx added a comment to T212800: AMC feature flag can be superseded by a development query parameter.

Do consider that this change might be useful for setting up automated browser tests targetting AMC mode available/unavailable, since the Node.js stack doesn't support a local LocalSettings.php file.

Apr 10 2019, 2:43 PM · Readers-Web-Backlog, Advanced Mobile Contributions

Apr 9 2019

phuedx added a comment to T219212: Augment ReadingDepth schema with data from Page Lifecycle API.

Additional notes that I raised during today's Backlog Grooming meeting:

Apr 9 2019, 4:32 PM · Reading Depth, Product-Analytics, Readers-Web-Backlog
phuedx added a comment to T219841: Unknown dependency: mw.externalguidance.init.

cc analytics and RelEng as there's potential for a lot of traffic to EventLogging (I've seen 80k a minute) to the WebClientError schema

Apr 9 2019, 10:50 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Release-Engineering-Team, Analytics, Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue (Tracking), ExternalGuidance

Apr 8 2019

phuedx assigned T208980: [Bug] The statsv client should send a request when the page unloads so we are not losing events to Edtadros.
Apr 8 2019, 5:12 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Performance-Team, MediaWiki-extensions-WikimediaEvents
phuedx lowered the priority of T208980: [Bug] The statsv client should send a request when the page unloads so we are not losing events from Normal to Low.
Apr 8 2019, 1:51 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Performance-Team, MediaWiki-extensions-WikimediaEvents

Apr 5 2019

phuedx added a comment to T217724: Investigate 2019-03-01 Proton incident.

@Tgr: When can this work be scheduled?

Apr 5 2019, 3:13 PM · Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), Core Platform Team (Security, stability, performance and scalability (TEC1)), Proton
phuedx added a comment to T217724: Investigate 2019-03-01 Proton incident.

One alternative would be to launch the child Chromium process using firejail, which we're confident (?) does this kind of management.

Apr 5 2019, 3:13 PM · Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), Core Platform Team (Security, stability, performance and scalability (TEC1)), Proton
phuedx added a comment to T217724: Investigate 2019-03-01 Proton incident.

@akosiaris - yes, there is some logic that tries to kill the browser instances if browser.close() promise doesn't succeed. Looks like this code requires some tuning, and most probably it should try to kill the browser instance after some time without waiting for promise resolution/failure.

Apr 5 2019, 3:12 PM · Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), Core Platform Team (Security, stability, performance and scalability (TEC1)), Proton
phuedx added a comment to T213362: Limit what URLs Proton can access.

@Tgr: We'd talked about the deployment of this code having stalled out. Does this need a security review or at least an OK from Security prior to being deployed?

Apr 5 2019, 2:57 PM · Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), Security, Core Platform Team Backlog (Watching / External), Services (watching), Proton
phuedx added a comment to T209295: [EPIC] Enable WebClientError on production.

Work out how to deal with the frustration of non-deduplication. The feedback we got from people who have used EventLogging is that having the stack traces allowed them to fix the common bugs, but the other ones were harder to track down. We have no idea of the spread of our errors - all of them could be different, or many of them could be duplicates. We should think about what queries we can use to de-duplicate errors (And work out how many people they impact) and how our stack trace can be structured to help facilitate that.

Apr 5 2019, 2:22 PM · Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog
phuedx added a comment to T209295: [EPIC] Enable WebClientError on production.

Add stack traces to WebClientError events. Right now we're not including them in the current implementation because of the URL length. These will be essential. See T202026 for more information.

Apr 5 2019, 2:08 PM · Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog
phuedx added a comment to T206248: Report all client-side JavaScript errors.

After thinking about this a little, it'd be useful for extensions/skins to be able to register a module that'll act as an error handler. AIUI the Sentry extension will suffer from the same issue as there's no guarantee that it'll be executed before the things that it intends to monitor will.

Apr 5 2019, 9:55 AM · Readers-Web-Backlog

Apr 4 2019

phuedx awarded T219828: Refine eventlogging pipeline should not refine data for domains that are not wikimedia's a Mountain of Wealth token.
Apr 4 2019, 5:18 PM · Analytics-Kanban, Analytics
phuedx placed T219212: Augment ReadingDepth schema with data from Page Lifecycle API up for grabs.
Apr 4 2019, 2:59 PM · Reading Depth, Product-Analytics, Readers-Web-Backlog
phuedx moved T219212: Augment ReadingDepth schema with data from Page Lifecycle API from Needs Analysis to Triaged but Future on the Readers-Web-Backlog board.
Apr 4 2019, 2:59 PM · Reading Depth, Product-Analytics, Readers-Web-Backlog
phuedx updated the task description for T219212: Augment ReadingDepth schema with data from Page Lifecycle API.
Apr 4 2019, 2:58 PM · Reading Depth, Product-Analytics, Readers-Web-Backlog
phuedx updated the task description for T219212: Augment ReadingDepth schema with data from Page Lifecycle API.
Apr 4 2019, 2:50 PM · Reading Depth, Product-Analytics, Readers-Web-Backlog