In T208755#4762388, @ovasileva wrote:

Thank you @Niedzielski and @pmiazga for all your hard work here.

3. Part of me is wondering if there's somewhere other than the toolbar to put this button — it seems like the obvious place, but also for some reason I can't quite identify yet it feels out of place. If we do keep it in the toolbar I think it might be worth evenly distributing the icons horizontally.

2. Designers review and see if the new treatments make sense for all use cases

Code coverage has gone up

Being bold.

I'd actually be interested in picking this up as a 10% project to better understand our logging infrastructure and deployment of the various EL services. If that'd slow things down a little too much, then I understand – I'd rather see this resolved 🙂

includes/skins/MinervaTemplate.php should not be directly accessing MobileContext

☝️ The task description was slightly out of date and was bold.

AFAICT there's one client that still uses passes a noimages parameter to the parse API: https://github.com/wikimedia/labs-tools-wikidipendenza

The browser tests have been failing for over three weeks now. Unfortunately, I don't have much free time to port them right now. Unless someone does, then we should disable them /cc @zeljkofilipin

Reflecting reality.

As promised, here are the notes that I took whilst running the resetPageRandom.php script on 12th November:

Per the task description (@pmiazga is deploying the first change in the chain and I will be available for QA).

I estimated a 5 because:

Centralising the definition for edit count buckets has obvious advantages. Both QuickSurveys and Popups would benefit:

I8345d95a774531ff62bda4a8766f848a847921ee has been deployed: https://en.wikipedia.org/w/index.php?title=Special%3AAllMessages&prefix=wikibase-page-schema&filter=all&lang=en&limit=50

… and now against all large wikis.

… and now against all medium wikis.

The script is currently running against all small wikis.

The build has since passed. I'm going to be bold and resolve this as it looks like an intermittent infrastructure problem.

Is it fair to say that this work is blocked on the rest of the refactoring work (or, at least, should be scheduled at the end of it?).

@Krinkle: Please feel free to correct me where I'm wrong/add more detail about this 🙂 If there are any sources for the browser/JavaScript VM behaviour differences between desktop and mobile devices, that'd be great!

I also confirmed that no new entries were logged to Logstash using the X-Wikimedia-Debug tool.

I can also confirm that I don't see the above type of output on the bottom of all articles with linked Wikidata items (again, on the Beta Cluster).

This took a little while to test! However, after linking Q390678 to the Foooooo article on the Beta Cluster I see the following at the bottom of that article:

I've rescheduled the change to be deployed in the European Mid-day SWAT window.

I've scheduled rOMWC61479ef8e135: BC: Enable Schema.org page split test for deployment during the Morning SWAT window as I might not be available for the entirety of the European Mid-day SWAT window.

Per T208469#4713958.

Please review ☝️, especially for precision of language.

• A SWAT will be needed to turn it on. Given this is a beta cluster only change, if you find a willing deployer, you can do it outside the normal SWAT windows.

Outstanding work, y'all.

In T207670#4721637, @ovasileva wrote:

In T207670#4687248, @Tbayer wrote:

Thanks for flagging this. I will check with @ovasileva about which of the two are more important from a product perspective, but I guess we will want to drop the page titles and keep the session-related data. (CC @phuedx )

discussed this with @Tbayer and we decided to keep session id and stop collecting page id

👍

Should we revisit using EventLogging to record limit details of errors and getting them ingested into Turnilo?

In T201068#4716018, @Ottomata wrote:

As an engineer, I want to batch produce many events at once so mobile apps can produce events after an offline period.

Do you think you'll need to be able to batch produce (in a single HTTP request) events of different schemas and/or events that are destined to different streams (AKA Kafka topics?). E.g. would you need to produce something like POST [{user login event}, {user search event}, {user read event}, {user pref change event}]?

The browser tests have been failing for some time with the following error:

In T205569#4676373, @dr0ptp4kt wrote:

@phuedx do you think it might be sensible to simply make sendBeacon a pre-requisite at this point for client side event logging?

☝️ I forgot to upload this image on the day.

In T207670#4687248, @Tbayer wrote:

Thanks for flagging this. I will check with @ovasileva about which of the two are more important from a product perspective, but I guess we will want to drop the page titles and keep the session-related data. (CC @phuedx )

AIUI this task led to T208469: Spike in PHP warnings from User.php; triggered from MobileFrontend's new use of ContribsPager with a User object instead of a string, which was blocking the rollout of the -wmf.2 branch.

I'm not sure what there's left to review here. If the errors have disappeared from logstash, then this task can be resolved, right?

Per the latest review for rMSCRd3812f53fc5e: Rewrite Queue to promise-way flow.

In T207280#4678271, @Jdlrobson wrote:

Could the page view API be used for checking links back?

… and how's Graphite coping?

I think that a better way is to track it on the backend by using ?share_link, but I'm afraid there might be some performance impact (requests not hitting cache).
Are there any performance issues related to adding a parameter to the URL and tracking it on the backend?

Tracking republication of Wikimedia content came up on analytics@ recently: https://lists.wikimedia.org/pipermail/analytics/2018-October/006460.html. Obviously, sharing content is different but the conversation seems relevant.

In T206702#4674734, @pmiazga wrote:

• not all browsers support onbeforeunload

I have a couple of concerns with this change that I spoke about with @pmiazga but wanted to raise here too:

In T205569#4666831, @Ottomata wrote:

(BTW, not sure if you've seen T205319: Modern Event Platform: Stream Configuration Service, but I think the use cases there overlap. We won't be working on that task for a while, but we do want to do it.)

1. Default: It just works. The value of mw.user.sessionId() is sent in the event.
2. Not using session sampling: set optional boolean of isSessionSampled = false. The value of mw.user.sessionId() is not sent in the event.

Could we invert this? I think it would be better to not collect the sessionId unless the event designer explicitly wants it.

In T206959#4667281, @Milimetric wrote:

I was thinking people just set debug to true and left that on while debugging EL code locally. Is that not true?

In T206647#4655497, @Jdlrobson wrote:

@phuedx, @ovasileva this would be a good task to pair with @Ryasmeen on

Rather than pinging y'all on separate tasks, I'll send an email!

@Jdlrobson, @Jdrewniak: Is this task a good task for @Ryasmeen to pick up?

In T206776#4659356, @Jdlrobson wrote:

[W76xwgpEEZ8AACAA9jYAAAAJ] Exception caught: Cannot read both schemas (internal_api_error_InvalidArgumentException) (MediawikiApi::ApiError)

suggests this was a issue with beta cluster stability.

Per T204143#4652491.

There were 5 builds triggered on 2018/10/10, of which 2 failed. The build has passed consistently for the last 4 builds.

I apologise for the non-sequitur but I mentioned that I'd follow up with the latest ReadingDepth and PageIssues server-side error rates so that the conversation was all happening in one place.

In T198946#4643217, @phuedx wrote:

As I mentioned during today's standup ritual, there's an additional component that should be taken into account when deciding how to implement this: we'd like this change to be live before the December code freeze.

Our results were inconclusive yet pointing towards sitemaps having no effect on search traffic.

☝️ per T206274#4644090.

Performance-Team might be interested in this task.