Page MenuHomePhabricator

phuedx (Sam Smith)
Engineering Manager, Readers

Projects (11)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Nov 14 2014, 10:42 AM (226 w, 6 d)
Availability
Available
IRC Nick
phuedx
LDAP User
Unknown
MediaWiki User
Phuedx (WMF) [ Global Accounts ]

Recent Activity

Yesterday

phuedx added a comment to T210658: [EPIC] AMC Navigation - page/talk toggle.

Since all the subtasks are resolved, can this be resolved?

Wed, Mar 20, 2:59 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Epic, Advanced Mobile Contributions

Tue, Mar 19

phuedx added a comment to T218243: QuickSurveys will sometimes not show on mobile.

If the code for QuickSurveys loads AFTER MobileFrontend, the hook will be registered too late and the survey will never show.

Tue, Mar 19, 7:03 PM · Mobile, QuickSurveys, Readers-Web-Backlog
phuedx added a comment to T218243: QuickSurveys will sometimes not show on mobile.

The task that led to the introduction of the mobile.betaoptin event: T111188

Tue, Mar 19, 5:01 PM · Mobile, QuickSurveys, Readers-Web-Backlog
phuedx added a comment to T214537: [EPIC] AMC Navigation - changes to main menu.
Tue, Mar 19, 4:40 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
phuedx added a comment to T218349: Rename "mobile web edit" change tag to "mobile web action".

@Jdlrobson: Would changing the message require that any existing workflows are updated or would folk still have to refer to the tag by its name when querying the DB or specifying it as an argument for the tagfilter parameter in an MW API call, for example? That is, would the tag look like it was called "mobile web action" but still actually be called "mobile web edit"?

Tue, Mar 19, 2:58 PM · MobileFrontend, Readers-Web-Backlog

Mon, Mar 18

phuedx updated the task description for T218349: Rename "mobile web edit" change tag to "mobile web action".
Mon, Mar 18, 11:40 AM · MobileFrontend, Readers-Web-Backlog
phuedx updated the task description for T218349: Rename "mobile web edit" change tag to "mobile web action".
Mon, Mar 18, 11:40 AM · MobileFrontend, Readers-Web-Backlog

Fri, Mar 15

phuedx renamed T218349: Rename "mobile web edit" change tag to "mobile web action" from [WIP] Rename "mobile web edit" change tag to "mobile web action" to Rename "mobile web edit" change tag to "mobile web action".
Fri, Mar 15, 2:07 PM · MobileFrontend, Readers-Web-Backlog
phuedx renamed T218349: Rename "mobile web edit" change tag to "mobile web action" from [WIP] Deprecate "mobile web edit" in favour of "mobile web action" to [WIP] Rename "mobile web edit" change tag to "mobile web action".
Fri, Mar 15, 2:07 PM · MobileFrontend, Readers-Web-Backlog
phuedx added a comment to T218349: Rename "mobile web edit" change tag to "mobile web action".

As for on-wiki uses by the general public:

Fri, Mar 15, 12:14 PM · MobileFrontend, Readers-Web-Backlog

Thu, Mar 14

phuedx updated the task description for T218349: Rename "mobile web edit" change tag to "mobile web action".
Thu, Mar 14, 7:52 PM · MobileFrontend, Readers-Web-Backlog
phuedx added a project to T218349: Rename "mobile web edit" change tag to "mobile web action": MobileFrontend.
Thu, Mar 14, 7:36 PM · MobileFrontend, Readers-Web-Backlog
phuedx created T218349: Rename "mobile web edit" change tag to "mobile web action".
Thu, Mar 14, 7:36 PM · MobileFrontend, Readers-Web-Backlog
phuedx moved T119306: WikiEditor on mobile and tablets and touch screen needs support for copying from Needs triage to Triaged on the Mobile board.
Thu, Mar 14, 5:56 PM · Mobile, WikiEditor
phuedx triaged T119306: WikiEditor on mobile and tablets and touch screen needs support for copying as Normal priority.

Would replacing the textarea with a div if the page is protected work? This would be cleaner than manipulating the DOM in JS IMO.

Thu, Mar 14, 5:55 PM · Mobile, WikiEditor
phuedx moved T217526: [BUG] Quote boxes not centred/displayed at the right size in articles from Needs triage to Triaged on the Mobile board.
Thu, Mar 14, 5:46 PM · Reading-Web-Local-Wiki-Issues, Mobile, Reading-Infrastructure-Team-Backlog
phuedx added a comment to T217526: [BUG] Quote boxes not centred/displayed at the right size in articles.

@ovasileva This is probably a bug on mobile web too?

Thu, Mar 14, 5:46 PM · Reading-Web-Local-Wiki-Issues, Mobile, Reading-Infrastructure-Team-Backlog
phuedx updated subscribers of T217526: [BUG] Quote boxes not centred/displayed at the right size in articles.

This appears to have been fixed in https://en.wikipedia.org/w/index.php?title=Calculus&type=revision&diff=887407355&oldid=886050145, which is the fix that @Tacsipacsi proposed in T217526#5012719.

Thu, Mar 14, 5:44 PM · Reading-Web-Local-Wiki-Issues, Mobile, Reading-Infrastructure-Team-Backlog
phuedx updated the task description for T217526: [BUG] Quote boxes not centred/displayed at the right size in articles.
Thu, Mar 14, 5:22 PM · Reading-Web-Local-Wiki-Issues, Mobile, Reading-Infrastructure-Team-Backlog
phuedx updated the task description for T217526: [BUG] Quote boxes not centred/displayed at the right size in articles.
Thu, Mar 14, 5:22 PM · Reading-Web-Local-Wiki-Issues, Mobile, Reading-Infrastructure-Team-Backlog
phuedx moved T218243: QuickSurveys will sometimes not show on mobile from Needs triage to Triaged on the Mobile board.
Thu, Mar 14, 5:18 PM · Mobile, QuickSurveys, Readers-Web-Backlog
phuedx placed T181084: [EPIC] Deploy the mediawiki-services-chromium-render service (Proton) up for grabs.
Thu, Mar 14, 2:11 PM · Reading-Infrastructure-Team-Backlog, Readers-Web-Backlog, Readers-Web-Kanbanana-Board-Old, Proton, Epic

Wed, Mar 13

D3r1ck01 awarded T143189: [EPIC] Split MobileContext god object apart a Like token.
Wed, Mar 13, 7:02 PM · Readers-Web-Backlog, MW-1.28-release (WMF-deploy-2016-08-30_(1.28.0-wmf.17)), Reading-Web-Sprint-79-Uh-oh, Technical-Debt, Epic, MobileFrontend

Tue, Mar 12

phuedx updated the task description for T216495: [EPIC] Diversity quicksurveys.
Tue, Mar 12, 5:26 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Surveys

Fri, Mar 8

phuedx updated the task description for T216495: [EPIC] Diversity quicksurveys.
Fri, Mar 8, 6:40 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Surveys
phuedx added a parent task for T186737: Let me choose whether to present a survey to logged-in or logged-out editors: T216495: [EPIC] Diversity quicksurveys.
Fri, Mar 8, 10:56 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Research, QuickSurveys, Surveys
phuedx added a subtask for T216495: [EPIC] Diversity quicksurveys: T186737: Let me choose whether to present a survey to logged-in or logged-out editors.
Fri, Mar 8, 10:56 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Surveys

Thu, Mar 7

phuedx added a comment to T205437: Resurrect eventlogging_EventError logging to in logstash.

@mforns: I'm pretty sure this is deployed and (re)started as there are log lines appearing in Kibana for the following query: https://logstash.wikimedia.org/goto/36329f5fd2348e181177ff879800d9c0

Thu, Mar 7, 6:35 PM · Analytics-Kanban, Patch-For-Review, Analytics, Analytics-EventLogging

Wed, Mar 6

phuedx updated the task description for T217142: [WIP] [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors.
Wed, Mar 6, 2:06 PM · User-herron, Reading-Infrastructure-Team-Backlog, Wikimedia-Logstash
phuedx added a comment to T217142: [WIP] [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors.

Unless we have a generic schema for client error logs! :) Might not be a bad idea.

Wed, Mar 6, 2:05 PM · User-herron, Reading-Infrastructure-Team-Backlog, Wikimedia-Logstash
phuedx updated the task description for T217142: [WIP] [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors.
Wed, Mar 6, 1:59 PM · User-herron, Reading-Infrastructure-Team-Backlog, Wikimedia-Logstash

Tue, Mar 5

phuedx renamed T186737: Let me choose whether to present a survey to logged-in or logged-out editors from Let me choose whether to present a microsurvey to logged-in or logged-out editors to Let me choose whether to present a survey to logged-in or logged-out editors.
Tue, Mar 5, 5:09 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Research, QuickSurveys, Surveys

Mon, Mar 4

phuedx updated subscribers of T199004: RFC: Add a frontend build step to skins/extensions to our deploy process.

CC @LarsWirzenius per https://lists.wikimedia.org/pipermail/engineering/2019-February/000689.html :)

Mon, Mar 4, 10:07 AM · TechCom-RFC, Proposal, User-Jdlrobson

Thu, Feb 28

phuedx updated subscribers of T217142: [WIP] [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors.

Also CCing @dr0ptp4kt

Thu, Feb 28, 12:12 PM · User-herron, Reading-Infrastructure-Team-Backlog, Wikimedia-Logstash
phuedx updated the task description for T217142: [WIP] [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors.
Thu, Feb 28, 9:42 AM · User-herron, Reading-Infrastructure-Team-Backlog, Wikimedia-Logstash

Wed, Feb 27

phuedx updated the task description for T217142: [WIP] [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors.
Wed, Feb 27, 6:12 PM · User-herron, Reading-Infrastructure-Team-Backlog, Wikimedia-Logstash
Jdlrobson awarded T217142: [WIP] [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors a Mountain of Wealth token.
Wed, Feb 27, 3:53 PM · User-herron, Reading-Infrastructure-Team-Backlog, Wikimedia-Logstash
phuedx updated subscribers of T217142: [WIP] [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors.

CC @Jhernandez, @Tgr, @faidon, @fgiunchedi, @herron for visibility. My apologies in advance for the description churn, y'all.

Wed, Feb 27, 2:23 PM · User-herron, Reading-Infrastructure-Team-Backlog, Wikimedia-Logstash
phuedx updated the task description for T217142: [WIP] [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors.
Wed, Feb 27, 2:20 PM · User-herron, Reading-Infrastructure-Team-Backlog, Wikimedia-Logstash
phuedx added a comment to T213847: Should be possible to sample by country.
  1. Nice find, @Jdlrobson!
  2. Should we discard surveys that required CentralNotice to be loaded if it isn't?
Wed, Feb 27, 12:07 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), QuickSurveys
phuedx closed T217110: Popups schema has the wrong type for popupDelay as Resolved.

@Tbayer pointed me at this task during our 1:1 yesterday.

Wed, Feb 27, 10:30 AM · Readers-Web-Backlog, Product-Analytics, Analytics-Kanban, Analytics
phuedx closed T217110: Popups schema has the wrong type for popupDelay, a subtask of T216771: [Bug] Type mismatch for a few other schemas, as Resolved.
Wed, Feb 27, 10:30 AM · Analytics-Kanban, Analytics

Tue, Feb 26

phuedx created T217142: [WIP] [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors.
Tue, Feb 26, 3:32 PM · User-herron, Reading-Infrastructure-Team-Backlog, Wikimedia-Logstash
phuedx updated the task description for T208980: [Bug] The statsv client should send a request when the page unloads so we are not losing events.
Tue, Feb 26, 9:43 AM · Performance-Team, Readers-Web-Backlog, MediaWiki-extensions-WikimediaEvents

Feb 14 2019

phuedx added a comment to T208980: [Bug] The statsv client should send a request when the page unloads so we are not losing events.

@nray: See @Krinkle's detailed explanation here: T208980#4792762

Feb 14 2019, 5:03 PM · Performance-Team, Readers-Web-Backlog, MediaWiki-extensions-WikimediaEvents
phuedx removed a project from T212371: Separate page issue parsing from pageIssues.js: Patch-For-Review.
Feb 14 2019, 4:50 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Technical-Debt, MinervaNeue, Page-Issue-Warnings
phuedx updated subscribers of T215426: Consider changing mobile site header height (and overlay header height) from 3.35em (53.6px) to 3em (48px).

@ovasileva: This is in Triaged but Future in our backlog but doesn't appear to have a priority.

Feb 14 2019, 4:47 PM · Editing Design , Readers-Web-Backlog (Design), Patch-For-Review, MobileFrontend, MinervaNeue
phuedx moved T215915: In the mobile version of Traditional Chinese, the Wikivoyage is Simplified Chinese from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Feb 14 2019, 4:44 PM · Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, MobileFrontend, Chinese-Sites
phuedx added a project to T215915: In the mobile version of Traditional Chinese, the Wikivoyage is Simplified Chinese: Readers-Web-Backlog.
Feb 14 2019, 4:44 PM · Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, MobileFrontend, Chinese-Sites
phuedx added a comment to T216063: [Bug] Many ReadingDepth validation errors logged.

Following @Tbayer's advice, I did a little digging in wmf.webrequest:

Feb 14 2019, 2:17 PM · Reading Depth, Readers-Web-Backlog (Tracking), Analytics
phuedx updated the task description for T181084: [EPIC] Deploy the mediawiki-services-chromium-render service (Proton).
Feb 14 2019, 1:17 PM · Reading-Infrastructure-Team-Backlog, Readers-Web-Backlog, Readers-Web-Kanbanana-Board-Old, Proton, Epic
phuedx added a comment to T216063: [Bug] Many ReadingDepth validation errors logged.

AFAICT the function that should be decoding and parsing the QSON (Querystring-encoded JSON) string is expecting that character to not be encoded but it is (it's the %3B at the end of the raw event).

Feb 14 2019, 12:15 PM · Reading Depth, Readers-Web-Backlog (Tracking), Analytics
phuedx added a comment to T216063: [Bug] Many ReadingDepth validation errors logged.

The "Extra data:" error is raised by json.loads as it encounters the ; character at the end of the JSON string:

Feb 14 2019, 10:46 AM · Reading Depth, Readers-Web-Backlog (Tracking), Analytics

Feb 13 2019

phuedx added a comment to T211197: Build AMC opt-in toggle.

@Edtadros and I worked through testing the 4th 5th acceptance criterion together during our 1:1 today.

Feb 13 2019, 5:55 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx reassigned T211197: Build AMC opt-in toggle from phuedx to Edtadros.
Feb 13 2019, 2:31 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx added a comment to T215477: Tag Thanks actions with AMC tag.

I guess such a generic hook for log events would need to run inside $logEntry->insert()?

Feb 13 2019, 2:25 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Product-Analytics, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions, Thanks, Growth-Team
phuedx updated the task description for T214444: Update ReadingDepth instrumentation to avoid deprecated schema module (blocks loads event).
Feb 13 2019, 11:23 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Performance-Team (Radar)
phuedx added a comment to T210652: Handoff Proton service to Reading Infrastructure.
Feb 13 2019, 10:13 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Reading-Infrastructure-Team-Backlog, Proton
phuedx edited Description on Proton.
Feb 13 2019, 10:12 AM

Feb 12 2019

phuedx added a comment to T213366: [2 hrs] Decide on handling system updates for Proton.

I've removed this from our (Readers Web's) kanban board as Proton has been handed over to Readers Infrastructure.

Feb 12 2019, 6:15 PM · Reading-Infrastructure-Team-Backlog (Kanban), Security-Team, Operations, Proton
phuedx removed a project from T213366: [2 hrs] Decide on handling system updates for Proton: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3).
Feb 12 2019, 6:13 PM · Reading-Infrastructure-Team-Backlog (Kanban), Security-Team, Operations, Proton
phuedx added a comment to T214444: Update ReadingDepth instrumentation to avoid deprecated schema module (blocks loads event).
  1. Are you expecting an HTTP 204 status in the last QA step for the requests that appear after filtering?
Feb 12 2019, 6:11 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Performance-Team (Radar)
phuedx added a comment to T210652: Handoff Proton service to Reading Infrastructure.

@ovasileva: Could you update https://phabricator.wikimedia.org/project/profile/2960/ accordingly?

Feb 12 2019, 5:13 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Reading-Infrastructure-Team-Backlog, Proton
phuedx closed T210652: Handoff Proton service to Reading Infrastructure as Resolved.
Feb 12 2019, 5:01 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Reading-Infrastructure-Team-Backlog, Proton
phuedx closed T210652: Handoff Proton service to Reading Infrastructure, a subtask of T181084: [EPIC] Deploy the mediawiki-services-chromium-render service (Proton), as Resolved.
Feb 12 2019, 5:01 PM · Reading-Infrastructure-Team-Backlog, Readers-Web-Backlog, Readers-Web-Kanbanana-Board-Old, Proton, Epic
phuedx added a comment to T210652: Handoff Proton service to Reading Infrastructure.

Per our (@Jhernandez, @Tgr, @pmiazga, and me) conversation in last Thursday's Audiences Platform Sync, Proton has officially been handed over to Readers Infrastructure for ongoing maintenance. I'll follow up with an email to readers-web-team@wikimedia.org and ri-team@wikimedia.org to confirm this.

Feb 12 2019, 5:01 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Reading-Infrastructure-Team-Backlog, Proton
phuedx updated the task description for T210652: Handoff Proton service to Reading Infrastructure.
Feb 12 2019, 4:55 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Reading-Infrastructure-Team-Backlog, Proton
phuedx added a comment to T210652: Handoff Proton service to Reading Infrastructure.

Drop proton-staging as it is not used (chromium-pdf.reading-web-staging.eqiad.wmflabs) - can be done after the handoff

Feb 12 2019, 4:47 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Reading-Infrastructure-Team-Backlog, Proton
phuedx updated the task description for T210652: Handoff Proton service to Reading Infrastructure.
Feb 12 2019, 4:44 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Reading-Infrastructure-Team-Backlog, Proton
phuedx added a comment to T186737: Let me choose whether to present a survey to logged-in or logged-out editors.

@Capt_Swing: Thanks for the additional detail. Given that, I think it's reasonable to keep both tasks separate.

Feb 12 2019, 1:32 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Research, QuickSurveys, Surveys

Feb 11 2019

phuedx added a comment to T63737: Thank notification on mobile should support click to undo.

@alexhollender the click to cancel functionality is now live on beta cluster and ready for this weeks train.

Feb 11 2019, 6:55 PM · User-notice, User-Ryasmeen, Growth-Team, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Mobile, Thanks
phuedx claimed T211197: Build AMC opt-in toggle.
Feb 11 2019, 6:14 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx added a comment to T212970: Minerva skin should increment MinervaClientError only once per request.

To minimize the traffic sent to the stats endpoint we should track MinervaClientError counter only once after the request is done, not on every error occurrence.

Feb 11 2019, 1:40 PM · Readers-Web-Backlog, MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend
phuedx added a comment to T215624: AMC – Opt-in for logged out users.

@Joe: Yes. That's correct. Do note that this is the current behaviour for the beta mode of the mobile site (visit https://m.mediawiki.org/wiki/Special:MobileOptions and enable "MediaWiki ß"). I think it's worth wondering how caching best works for both that and this new opt-in feature.

Feb 11 2019, 12:57 PM · Operations, User-Joe, Traffic, Advanced Mobile Contributions

Feb 9 2019

phuedx added a comment to T214384: [Bug] Type mismatch between NavigationTiming EL schema and Hive table schema.

Thanks for hashing this out, y'all. FWIW I think the proposed interim solution seems reasonable.

Feb 9 2019, 8:07 AM · Analytics-Kanban, Patch-For-Review, Performance-Team (Radar), Analytics

Feb 8 2019

phuedx added a subtask for T210653: [EPIC] AMC - Opting in: T215624: AMC – Opt-in for logged out users.
Feb 8 2019, 4:06 PM · Epic, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx added a parent task for T215624: AMC – Opt-in for logged out users: T210653: [EPIC] AMC - Opting in.
Feb 8 2019, 4:06 PM · Operations, User-Joe, Traffic, Advanced Mobile Contributions
phuedx updated subscribers of T215624: AMC – Opt-in for logged out users.

@Joe: Here's the task I promised to create during the Readers Web/Readers Infra/Services/SRE interlock meeting on Wednesday, 23rd January /cc @ggellerman

Feb 8 2019, 3:59 PM · Operations, User-Joe, Traffic, Advanced Mobile Contributions
phuedx created T215624: AMC – Opt-in for logged out users.
Feb 8 2019, 3:58 PM · Operations, User-Joe, Traffic, Advanced Mobile Contributions
phuedx updated the task description for T211197: Build AMC opt-in toggle.
Feb 8 2019, 9:45 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Feb 7 2019

phuedx added a comment to T211197: Build AMC opt-in toggle.

FeaturesManager::isFeatureAvailableInContext will need to be updated to take a User object and check the stored value of AMC. This is needed for the talk tab task (T212216).

Feb 7 2019, 6:43 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx updated the task description for T211197: Build AMC opt-in toggle.
Feb 7 2019, 6:26 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx added a comment to T211197: Build AMC opt-in toggle.

☝️ I pulled out the very technical AC from the AC section and into the Developer notes section as:

Feb 7 2019, 6:22 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx updated the task description for T211197: Build AMC opt-in toggle.
Feb 7 2019, 6:12 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx awarded T213367: Add MediaWiki-Vagrant role for Proton a Love token.
Feb 7 2019, 4:41 PM · Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), MediaWiki-Vagrant, Proton
phuedx added a comment to T214957: Requesting access to researchers group for phuedx.

I apologise for not including an approver on the task. I wasn't actually sure who should approve access in this case but realise now that @Nuria would've been the sensible choice.

Feb 7 2019, 2:38 PM · Patch-For-Review, Research, Operations, SRE-Access-Requests

Feb 6 2019

phuedx added a comment to T214658: Separate Lazy loading code from Skin.js.

Thanks!

Feb 6 2019, 5:34 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
phuedx added a comment to T198218: Generate list of most used special pages.

Here is the same limited to desktop, but for five months (January-May) instead of one. It confirms that the high number for RecentChangesLinked above wasn't an outlier - it got 13x as much traffic as RecentChanges, which I would have expected to be much more relevant and useful.

_c0 views
https://en.wikipedia.org/wiki/wiki.phtml 61495

Feb 6 2019, 1:50 PM · Chinese-Sites, Advanced Mobile Contributions, Reading-analysis, Readers-Web-Backlog (Tracking), Product-Analytics
phuedx added a comment to T214658: Separate Lazy loading code from Skin.js.

What's the rationale for this skipping Needs QA (the first time it moved to Ready for Signoff, I guess)?

Feb 6 2019, 11:27 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
phuedx placed T214444: Update ReadingDepth instrumentation to avoid deprecated schema module (blocks loads event) up for grabs.
Feb 6 2019, 11:19 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Performance-Team (Radar)
phuedx added a comment to T214444: Update ReadingDepth instrumentation to avoid deprecated schema module (blocks loads event).
Feb 6 2019, 11:19 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Performance-Team (Radar)
phuedx added a comment to T215370: TalkOverlay should not extend Overlay.

AFAICT there's no instrumentation about how (or how frequently) our various overlays are being interacted with. Nevertheless, it's a production feature, so we should do our best to make sure that we don't introduce regressions while doing this refactoring. With that in mind, could we add tests so that this can go through Needs QA.

Feb 6 2019, 9:56 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Feb 5 2019

phuedx claimed T214444: Update ReadingDepth instrumentation to avoid deprecated schema module (blocks loads event).
Feb 5 2019, 7:00 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Performance-Team (Radar)
phuedx claimed T214444: Update ReadingDepth instrumentation to avoid deprecated schema module (blocks loads event).

I'll add a note as to why my proposed change should work and testing instructions for reviewing engineers and @Edtadros.

Feb 5 2019, 5:28 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Performance-Team (Radar)
phuedx added a comment to T214724: Remove AMC Article/Talk tabs from Main page.

There is also a main page stylesheet.

Feb 5 2019, 5:08 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx awarded T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests a Love token.
Feb 5 2019, 12:06 PM · MediaWiki-Core-Testing, Release-Engineering-Team (Kanban), Quibble, User-zeljkofilipin
phuedx added a comment to T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests.

Is there any chance that you did get time to look at this during All Hands, @hashar? I know it was very busy.

Feb 5 2019, 12:06 PM · MediaWiki-Core-Testing, Release-Engineering-Team (Kanban), Quibble, User-zeljkofilipin

Jan 30 2019

phuedx added a comment to T214935: Examine clickthrough ratios for different page elements of action=history pages.
select
    round(sum(if(uri_query like '%Special:Log%', 1, 0)) / sum(1) * 100, 2) as log,
    round(sum(if(uri_query like '%Special:AbuseLog%', 1, 0)) / sum(1) * 100, 2) as abuse_log,
    sum(1) as all_clickthroughs
from
    wmf.webrequest
where
    year = 2019
    and month = 1
    and day = 28
Jan 30 2019, 1:36 AM · Readers-Web-Backlog, Product-Analytics

Jan 29 2019

phuedx updated the task description for T214957: Requesting access to researchers group for phuedx.
Jan 29 2019, 11:22 PM · Patch-For-Review, Research, Operations, SRE-Access-Requests
phuedx created T214957: Requesting access to researchers group for phuedx.
Jan 29 2019, 11:22 PM · Patch-For-Review, Research, Operations, SRE-Access-Requests