Page MenuHomePhabricator

phuedx (Sam Smith)
Senior Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 14 2014, 10:42 AM (275 w, 2 d)
Availability
Available
IRC Nick
phuedx
LDAP User
Unknown
MediaWiki User
Phuedx (WMF) [ Global Accounts ]

Recent Activity

Yesterday

phuedx added a comment to T244481: Provide basic FeatureManagement in Vector codebase.

@polishdeveloper: Sorry for the lack of context for the change above. There were/are a lot of good questions about the design of the feature management system (FMS) that emerged during review. Given the need to land an FMS in Vector soon, I proposed that we land the simplest version of your proposal that we could all agree on. Included in my patch is a list of steps that gets us from point A to what's described in this task.

Sat, Feb 22, 3:46 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Vector, Desktop Improvements

Thu, Feb 20

phuedx reassigned T243071: Update PrefUpdate schema to include edit count from phuedx to Niedzielski.

@Niedzielski IIRC you said that you had experience with QAing EventLogging on the Beta Cluster and that you'd be willing to help @Edtadros QA this.

Thu, Feb 20, 6:27 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
phuedx updated the task description for T243071: Update PrefUpdate schema to include edit count .
Thu, Feb 20, 6:24 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2019-20-Q3)

Wed, Feb 19

phuedx updated subscribers of T243071: Update PrefUpdate schema to include edit count .

I'll add notes for @Edtadros.

Wed, Feb 19, 6:10 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
phuedx added a comment to T196159: Remove instrumentation for Schema:Print.

@Edtadros: I can confirm that the patch has been deployed to all wikis.

Wed, Feb 19, 6:05 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MediaWiki-extensions-WikimediaEvents, Product-Analytics
phuedx updated subscribers of T242381: Add a Vector skin version preference.
Wed, Feb 19, 5:23 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
phuedx claimed T243071: Update PrefUpdate schema to include edit count .
Wed, Feb 19, 5:22 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
phuedx added a comment to T232140: Separate out logo handling into square image logos and long text/wordmark banner logos.

☝️ @Jdlrobson I've left a question about the deprecation notice for wgMinervaCustomLogos not being shown in one scenario.

Wed, Feb 19, 12:27 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), ContentTranslation, Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Patch-For-Review, Logos, MediaWiki-Interface
phuedx moved T232140: Separate out logo handling into square image logos and long text/wordmark banner logos from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Wed, Feb 19, 11:51 AM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), ContentTranslation, Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Patch-For-Review, Logos, MediaWiki-Interface
phuedx updated the task description for T245292: Don't lazily load messages when showing a survey.
Wed, Feb 19, 7:08 AM · Readers-Web-Backlog (Tracking), QuickSurveys
phuedx renamed T245292: Don't lazily load messages when showing a survey from Don't lazily load messages to Don't lazily load messages when showing a survey.
Wed, Feb 19, 7:08 AM · Readers-Web-Backlog (Tracking), QuickSurveys
phuedx triaged T245292: Don't lazily load messages when showing a survey as Low priority.

Prioritising this as Low as it's not work that must be done as part of Desktop Improvements.

Wed, Feb 19, 7:08 AM · Readers-Web-Backlog (Tracking), QuickSurveys
phuedx added a project to T245292: Don't lazily load messages when showing a survey: Performance-Team.

CC Performance-Team. Whenever you can, I'd appreciate a review of this approach.

Wed, Feb 19, 7:05 AM · Readers-Web-Backlog (Tracking), QuickSurveys

Tue, Feb 18

phuedx claimed T244481: Provide basic FeatureManagement in Vector codebase.
Tue, Feb 18, 6:27 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Vector, Desktop Improvements
phuedx moved T244481: Provide basic FeatureManagement in Vector codebase from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Tue, Feb 18, 6:27 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Vector, Desktop Improvements
phuedx added a comment to T243281: Build opt-out button for logged-in users with new vector on.

We estimated this as a large because there was some debate about how/where the CSS for the button should live.

Tue, Feb 18, 5:34 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
phuedx added a comment to T243281: Build opt-out button for logged-in users with new vector on.

Firstly, apologies for the late comment here.

Tue, Feb 18, 5:32 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
phuedx placed T243071: Update PrefUpdate schema to include edit count up for grabs.
Tue, Feb 18, 10:03 AM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2019-20-Q3)

Mon, Feb 17

phuedx reassigned T196159: Remove instrumentation for Schema:Print from phuedx to Edtadros.
Mon, Feb 17, 10:46 AM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MediaWiki-extensions-WikimediaEvents, Product-Analytics
phuedx placed T237230: Long edit summary/titles/user breaking AMC special pages up for grabs.

Unlicking this 🍪 as T242381: Add a Vector skin version preference and T244481: Provide basic FeatureManagement in Vector codebase need attention.

Mon, Feb 17, 10:44 AM · Patch-For-Review, OOUI, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Advanced Mobile Contributions
phuedx reassigned T244614: Investigate and fix <link rel="alternate"/> tags in page source from Dbrant to Edtadros.
Mon, Feb 17, 10:22 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), MobileFrontend, Wikipedia-Android-App-Backlog, Android-app-Bugs, SEO
phuedx updated the task description for T244614: Investigate and fix <link rel="alternate"/> tags in page source.
Mon, Feb 17, 10:22 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), MobileFrontend, Wikipedia-Android-App-Backlog, Android-app-Bugs, SEO
phuedx moved T244614: Investigate and fix <link rel="alternate"/> tags in page source from Ready for Signoff to Needs QA on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Mon, Feb 17, 10:08 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), MobileFrontend, Wikipedia-Android-App-Backlog, Android-app-Bugs, SEO
phuedx edited projects for T244614: Investigate and fix <link rel="alternate"/> tags in page source, added: Readers-Web-Backlog (Kanbanana-2019-20-Q3); removed Readers-Web-Backlog.

<snip /> at least I'm not sure how to QA this other than verify the link is removed from the output HTML when it hits production

Mon, Feb 17, 10:08 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), MobileFrontend, Wikipedia-Android-App-Backlog, Android-app-Bugs, SEO
phuedx added a comment to T244614: Investigate and fix <link rel="alternate"/> tags in page source.

Neither config variable removed in https://gerrit.wikimedia.org/r/571560 are used anywhere other than WMF production 👍

Mon, Feb 17, 10:06 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), MobileFrontend, Wikipedia-Android-App-Backlog, Android-app-Bugs, SEO

Fri, Feb 14

phuedx created T245292: Don't lazily load messages when showing a survey.
Fri, Feb 14, 6:59 PM · Readers-Web-Backlog (Tracking), QuickSurveys
phuedx removed a project from T245275: Increase QuickSurveys' observability: Epic.
Fri, Feb 14, 5:24 PM · Readers-Web-Backlog, QuickSurveys
phuedx added a comment to T196159: Remove instrumentation for Schema:Print.

@phuedx Can you confirm that the code has been removed in production as well please?

Fri, Feb 14, 5:12 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MediaWiki-extensions-WikimediaEvents, Product-Analytics
phuedx created T245275: Increase QuickSurveys' observability.
Fri, Feb 14, 3:25 PM · Readers-Web-Backlog, QuickSurveys
phuedx moved T244614: Investigate and fix <link rel="alternate"/> tags in page source from Needs Analysis to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.

I'm moving this into Needs Code Review after a discussion with @ovasileva.

Fri, Feb 14, 2:30 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), MobileFrontend, Wikipedia-Android-App-Backlog, Android-app-Bugs, SEO
phuedx edited projects for T244614: Investigate and fix <link rel="alternate"/> tags in page source, added: Readers-Web-Backlog (Kanbanana-2019-20-Q3); removed Readers-Web-Backlog.
Fri, Feb 14, 1:26 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), MobileFrontend, Wikipedia-Android-App-Backlog, Android-app-Bugs, SEO
phuedx added a comment to T242381: Add a Vector skin version preference.
  • Questions to bounce with @phuedx:
    • Do you think I should add support for a "useskinversion" query parameter? This would kind of give us the ability to have URLs that are fully skin + version aware which I think would be very useful and may help with testing too. If so, should that be in the feature manager task, a new task, or somewhere else?
Fri, Feb 14, 11:51 AM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Thu, Feb 13

phuedx claimed T237230: Long edit summary/titles/user breaking AMC special pages.
Thu, Feb 13, 2:44 PM · Patch-For-Review, OOUI, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Advanced Mobile Contributions
phuedx moved T237230: Long edit summary/titles/user breaking AMC special pages from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Thu, Feb 13, 2:44 PM · Patch-For-Review, OOUI, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Advanced Mobile Contributions
phuedx reassigned T244436: [Regression, Production] user contributions icon missing on AMC mode from phuedx to Jdlrobson.
Thu, Feb 13, 1:24 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Regression, MinervaNeue
phuedx updated subscribers of T239258: Migrate JavaScript API documentation from jsduck to JSDoc.

There's a minor nit from @Volker_E on https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/571841/.

Thu, Feb 13, 1:24 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Vector, Technical-Debt
phuedx moved T239258: Migrate JavaScript API documentation from jsduck to JSDoc from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Thu, Feb 13, 1:23 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Vector, Technical-Debt
phuedx awarded Blog Post: Parsoid in PHP, or There and Back Again a Mountain of Wealth token.
Thu, Feb 13, 1:13 PM · Parsoid
phuedx added a comment to T244436: [Regression, Production] user contributions icon missing on AMC mode.

I recommended that @Edtadros move this to Needs More Work as:

Thu, Feb 13, 10:08 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Regression, MinervaNeue

Wed, Feb 12

phuedx added a comment to T196159: Remove instrumentation for Schema:Print.

@Edtadros: To confirm, I can verify that the code has been removed from the codebase. That removal will be deployed to all Wikipedias tomorrow (Thursday, 13th February).

Wed, Feb 12, 6:49 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MediaWiki-extensions-WikimediaEvents, Product-Analytics
phuedx added a comment to T214641: [Technical] The LoadingOverlay and src/mobile.startup/rlModuleLoader.js pattern should be removed - it results in overlay flashes during switches.

Per T214641#5861539, this is a technical change that has affected the UX of the categories overlay. It should go through design review.

Wed, Feb 12, 6:14 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
phuedx reassigned T214641: [Technical] The LoadingOverlay and src/mobile.startup/rlModuleLoader.js pattern should be removed - it results in overlay flashes during switches from phuedx to alexhollender.
Wed, Feb 12, 6:13 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
phuedx claimed T243071: Update PrefUpdate schema to include edit count .

Sorry for the noise @alexhollender!

Wed, Feb 12, 6:12 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
phuedx moved T243071: Update PrefUpdate schema to include edit count from Needs Design Review to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Wed, Feb 12, 6:12 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
phuedx reassigned T243071: Update PrefUpdate schema to include edit count from phuedx to alexhollender.
Wed, Feb 12, 9:59 AM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2019-20-Q3)

Tue, Feb 11

phuedx moved T243071: Update PrefUpdate schema to include edit count from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Tue, Feb 11, 7:41 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
phuedx added a comment to T232140: Separate out logo handling into square image logos and long text/wordmark banner logos.

Moved to Needs More Work as https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/551670/ is currently V-1.

Tue, Feb 11, 6:13 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), ContentTranslation, Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Patch-For-Review, Logos, MediaWiki-Interface
phuedx moved T232140: Separate out logo handling into square image logos and long text/wordmark banner logos from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Tue, Feb 11, 6:07 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), ContentTranslation, Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Patch-For-Review, Logos, MediaWiki-Interface
phuedx reassigned T196159: Remove instrumentation for Schema:Print from phuedx to Edtadros.
Tue, Feb 11, 6:07 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MediaWiki-extensions-WikimediaEvents, Product-Analytics
phuedx claimed T214641: [Technical] The LoadingOverlay and src/mobile.startup/rlModuleLoader.js pattern should be removed - it results in overlay flashes during switches.
Tue, Feb 11, 6:07 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
phuedx added a comment to T244481: Provide basic FeatureManagement in Vector codebase.

As discussed:

Tue, Feb 11, 2:28 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Vector, Desktop Improvements
phuedx moved T232140: Separate out logo handling into square image logos and long text/wordmark banner logos from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Tue, Feb 11, 10:42 AM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), ContentTranslation, Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Patch-For-Review, Logos, MediaWiki-Interface
phuedx added a comment to T243281: Build opt-out button for logged-in users with new vector on.

If you don't mind, I'll address your minor points first followed by your major points.

Tue, Feb 11, 10:03 AM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Mon, Feb 10

phuedx added a comment to T239269: [SPIKE 16hrs] Add coding convention for new commits to Vector.

Hey @nray! Is there anything else that needs review?

Mon, Feb 10, 1:07 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Spike, Vector, Technical-Debt
phuedx claimed T243071: Update PrefUpdate schema to include edit count .
Mon, Feb 10, 12:53 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
phuedx moved T243071: Update PrefUpdate schema to include edit count from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Mon, Feb 10, 12:53 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
phuedx placed T243281: Build opt-out button for logged-in users with new vector on up for grabs.
Mon, Feb 10, 12:52 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
phuedx moved T243281: Build opt-out button for logged-in users with new vector on from Needs Analysis to Upcoming on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Mon, Feb 10, 12:52 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
phuedx added a comment to T243281: Build opt-out button for logged-in users with new vector on.

My recommendation is option 3 from T243281#5860154. I see the performance impact and incidental complexity being far outweighed by the UX of the button being usable for everyone immediately. In the common/best case, instrumentation is also free.

Mon, Feb 10, 12:49 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Sat, Feb 8

phuedx added a comment to T243281: Build opt-out button for logged-in users with new vector on.

I mention "array manipulation" above as a negative. To clarify, I mean that since the sidebar is internally represented as an array (strictly, an array with keys that are strings… map-ish), we must manipulate it directly in a hook handler. For those playing along, we're binding to two protocols: the hook (when and how it's run); and the keys of the array that represents the sidebar. However, I believe that at least the former's modification/deprecation are governed by MediaWiki's deprecation policy and that the latter woud be unlikely to change as it's the name of a system message.

Sat, Feb 8, 4:47 AM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Fri, Feb 7

phuedx added a comment to T243281: Build opt-out button for logged-in users with new vector on.

Things we know:

Fri, Feb 7, 5:39 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
phuedx claimed T243281: Build opt-out button for logged-in users with new vector on.
Fri, Feb 7, 2:02 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
phuedx added a comment to T244481: Provide basic FeatureManagement in Vector codebase.

hasSet( $setName, IContextSource ) to check if has access (granted and/or enabled by himself ) to given set

Fri, Feb 7, 1:01 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Vector, Desktop Improvements
phuedx moved T196159: Remove instrumentation for Schema:Print from Needs Code Review to Needs QA on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.

@Edtadros: I'm not sure how to handle removal of code. If you'd like to talk about it for 10 minutes, then LMK. Would

Fri, Feb 7, 11:02 AM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MediaWiki-extensions-WikimediaEvents, Product-Analytics

Thu, Feb 6

phuedx added a comment to T244436: [Regression, Production] user contributions icon missing on AMC mode.

☝️ The above could be deployed during the morning or evening SWAT deployment windows.

Thu, Feb 6, 6:33 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Regression, MinervaNeue
phuedx added a comment to T196159: Remove instrumentation for Schema:Print.

Once code is removed, please add a note on the Schema:Print documentation page and also mark the schema as inactive. Just add status=inactive to schema definition

Thu, Feb 6, 6:23 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MediaWiki-extensions-WikimediaEvents, Product-Analytics
phuedx updated the task description for T196159: Remove instrumentation for Schema:Print.
Thu, Feb 6, 6:23 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MediaWiki-extensions-WikimediaEvents, Product-Analytics
phuedx claimed T196159: Remove instrumentation for Schema:Print.
Thu, Feb 6, 6:06 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MediaWiki-extensions-WikimediaEvents, Product-Analytics
phuedx closed T237635: [SPIKE] What should feature management look like in desktop improvements?, a subtask of T236176: [EPIC] Build opt-in/opt-out mechanism for desktop improvements project, as Resolved.
Thu, Feb 6, 5:58 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
phuedx closed T237635: [SPIKE] What should feature management look like in desktop improvements? as Resolved.
Thu, Feb 6, 5:58 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
phuedx added a comment to T237635: [SPIKE] What should feature management look like in desktop improvements?.

I'll create a task that covers exactly that and no more /cc @ovasileva.

Thu, Feb 6, 5:58 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
phuedx placed T237635: [SPIKE] What should feature management look like in desktop improvements? up for grabs.
Thu, Feb 6, 2:12 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
phuedx moved T237635: [SPIKE] What should feature management look like in desktop improvements? from Doing to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Thu, Feb 6, 2:12 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
phuedx added a comment to T237635: [SPIKE] What should feature management look like in desktop improvements?.

I agree with @Niedzielski that the feature flagging system implemented in MobileFrontend should be ported to Vector immediately and refined as necessary whilst we're implementing features in Vector – @Niedzielski: Do correct me if I'm misrepresenting you here. I'll create a task that covers exactly that and no more /cc @ovasileva.

Thu, Feb 6, 2:10 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
phuedx updated the task description for T243071: Update PrefUpdate schema to include edit count .
Thu, Feb 6, 11:35 AM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
phuedx added a comment to T238029: Code for InukaPageView instrumentation.

A very special thanks to @phuedx for reviewing and merging the patch!!

Thu, Feb 6, 11:26 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Traffic, Operations, Performance-Team (Radar), Inuka-Team (Kanban)
phuedx moved T243071: Update PrefUpdate schema to include edit count from Blocked on Others to Ready for Development on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.

As discussed, this isn't blocked on T210106: Provide a reusable getEditCountBucket function for analytics purposes.

Thu, Feb 6, 10:44 AM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
phuedx updated the task description for T244436: [Regression, Production] user contributions icon missing on AMC mode.
Thu, Feb 6, 9:43 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Regression, MinervaNeue

Tue, Feb 4

Niedzielski awarded T111329: [GOAL] Page previews on mobileweb a Love token.
Tue, Feb 4, 5:39 PM · Readers-Web-Backlog (Needs Product Owner Decisions), Reading Epics (Page Previews), Goal, Page-Previews
phuedx moved T237635: [SPIKE] What should feature management look like in desktop improvements? from Ready for Signoff to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Tue, Feb 4, 2:57 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Mon, Feb 3

phuedx added a comment to T243783: MobileDiff drops whitespaces from edits.

The suggested fix is inline (pun intended) with the treatment for the desktop diff 👍

Mon, Feb 3, 11:23 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), MobileFrontend (MobileFrontend Special Pages), Readers-Web-Backlog (Kanbanana-2019-20-Q3)

Fri, Jan 31

phuedx updated subscribers of T242674: Add storybook to Vector.
Fri, Jan 31, 12:19 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Desktop Improvements, Vector, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
phuedx added a comment to T242674: Add storybook to Vector.

As I said during my review, we should standardise on quoting styles for the *stories.js* files rather than allow a free-for-all. Storybook stories are no different from the other parts of the codebase.

Fri, Jan 31, 12:18 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Desktop Improvements, Vector, Readers-Web-Backlog (Kanbanana-2019-20-Q3)

Thu, Jan 30

phuedx added a comment to T243925: Grant +2 gerrit rights for @polishdeveloper.

FWIW I support this request.

Thu, Jan 30, 9:43 AM · MediaWiki-Gerrit-Group-Requests, Gerrit-Privilege-Requests
phuedx updated phuedx.
Thu, Jan 30, 9:42 AM

Tue, Jan 28

phuedx assigned T243235: Regression: Desktop diff styles for moved paragraphs load alongside mobile to Edtadros.
Tue, Jan 28, 6:10 PM · Regression, MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Structured-Data-Backlog, User-Jdlrobson, Desktop Improvements, Multi-Content-Revisions
phuedx added a comment to T243235: Regression: Desktop diff styles for moved paragraphs load alongside mobile.

Related to this, on https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/411429 the move paragraph doesn't seem to match the mocks in T197491 anymore.

Tue, Jan 28, 6:10 PM · Regression, MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Structured-Data-Backlog, User-Jdlrobson, Desktop Improvements, Multi-Content-Revisions
phuedx added a comment to T242310: Regression: issues with MobileDiff.

@Jdlrobson: Can this be tested on the beta cluster?

Tue, Jan 28, 6:00 PM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Readers-Web-Backlog (Kanbanana-2019-20-Q3), VisualEditor-VisualDiffs, VisualEditor, Regression, MobileFrontend (MobileFrontend Special Pages)

Mon, Jan 27

phuedx updated subscribers of T242310: Regression: issues with MobileDiff.

@Jdlrobson: There's an open question on https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/566105/ from both @nray and me.

Mon, Jan 27, 6:21 PM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Readers-Web-Backlog (Kanbanana-2019-20-Q3), VisualEditor-VisualDiffs, VisualEditor, Regression, MobileFrontend (MobileFrontend Special Pages)
phuedx moved T242310: Regression: issues with MobileDiff from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Mon, Jan 27, 6:20 PM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Readers-Web-Backlog (Kanbanana-2019-20-Q3), VisualEditor-VisualDiffs, VisualEditor, Regression, MobileFrontend (MobileFrontend Special Pages)
phuedx assigned T242310: Regression: issues with MobileDiff to Jdlrobson.
Mon, Jan 27, 6:20 PM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Readers-Web-Backlog (Kanbanana-2019-20-Q3), VisualEditor-VisualDiffs, VisualEditor, Regression, MobileFrontend (MobileFrontend Special Pages)

Jan 23 2020

phuedx added a comment to T243071: Update PrefUpdate schema to include edit count .

I submitted the above change as a proof of concept for an approach that would allow us to centralise the user edit count bucketer in WikimediaEvents while not requiring that repositories bind to some API (requiring a hard dependency).

Jan 23 2020, 4:32 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
phuedx added a comment to T210106: Provide a reusable getEditCountBucket function for analytics purposes.

The Readers Web side of the conversation has been revived since we opened T243071: Update PrefUpdate schema to include edit count . I submitted the above change as a proof of concept for an approach that would allow us to centralise the user edit count bucketer in WikimediaEvents while not requiring that repositories bind to some API (requiring a hard dependency).

Jan 23 2020, 4:32 PM · Patch-For-Review, Analytics, Front-end-Standards-Group, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents, Readers-Web-Backlog

Jan 22 2020

phuedx updated the task description for T241179: Remove Special:MobileMenu.
Jan 22 2020, 3:21 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Readers-Web-Backlog (Kanbanana-2019-20-Q3), MobileFrontend
phuedx assigned T241179: Remove Special:MobileMenu to Edtadros.
Jan 22 2020, 3:16 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Readers-Web-Backlog (Kanbanana-2019-20-Q3), MobileFrontend
phuedx moved T241179: Remove Special:MobileMenu from Needs Code Review to Needs QA on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Jan 22 2020, 3:15 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Readers-Web-Backlog (Kanbanana-2019-20-Q3), MobileFrontend

Jan 21 2020

phuedx added a comment to T243071: Update PrefUpdate schema to include edit count .

I think there's a solid case for migrating the user edit count bucketing code from the clients (see below) to the server. I think that there's a case to be made for putting User#getEditCountBucket in Core, WikimediaEvents, and EventLogging.

Jan 21 2020, 7:43 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
phuedx added a comment to T237635: [SPIKE] What should feature management look like in desktop improvements?.

@polishdeveloper: I'm happy to help out with this prior to the EOM January deadline.

Jan 21 2020, 6:09 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
phuedx added a comment to T237635: [SPIKE] What should feature management look like in desktop improvements?.

@pmiazga - noting that we decided to create a separate task to track feature management within vector in the time between now and when the RfC is resolved.

Jan 21 2020, 2:43 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
phuedx moved T242674: Add storybook to Vector from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Jan 21 2020, 2:41 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Desktop Improvements, Vector, Readers-Web-Backlog (Kanbanana-2019-20-Q3)