phuedx (Sam Smith)
Engineering Manager, Readers

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Nov 14 2014, 10:42 AM (201 w, 1 d)
Availability
Available
IRC Nick
phuedx
LDAP User
Unknown
MediaWiki User
Phuedx (WMF) [ Global Accounts ]

Recent Activity

Yesterday

phuedx added a comment to T204853: Security Issue Access Request for MBinder_WMF.

I support @MBinder_WMF's request.

Fri, Sep 21, 5:07 PM · Security-Team, Security

Thu, Sep 20

phuedx moved T202306: Remove EventLogging code from RelatedArticles from Needs QA to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.

https://gerrit.wikimedia.org/r/460410 hasn't been merged and is V:-1.

Thu, Sep 20, 5:16 PM · Performance-Team (Radar), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), RelatedArticles
phuedx added a comment to T203814: Turn on MinervaErrorLogSamplingRate (Schema:WebClientError).

After talking with @Ottomata on irc about the reasons why eventlogging is not well suited to do error logging I have written a wikitech page on this regard: https://wikitech.wikimedia.org/wiki/Analytics/Systems/EventLogging/NotErrorLogging#Eventlogging_is_not_Well_suited_to_do_error_logging

Thu, Sep 20, 4:34 PM · Patch-For-Review, Wikimedia-Site-requests, Analytics, MobileFrontend (MobileFrontend.js), Readers-Web-Backlog
phuedx closed T177379: [Spike] Design interface for the new renderer service, a subtask of T163472: [EPIC] Provide a way to download articles in PDF on the mobile website, as Declined.
Thu, Sep 20, 3:30 PM · Readers-Web-Backlog, Proton, Epic, New-Readers
phuedx closed T177379: [Spike] Design interface for the new renderer service as Declined.

Per T177219#4493965, this is no longer needed.

Thu, Sep 20, 3:30 PM · Readers-Web-Backlog (Design), Spike, Proton

Wed, Sep 19

phuedx added a comment to T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests.

As far as I can see it, this should be done in Quibble. I'm not familiar with it, so it's unlikely I would be working on this.

Wed, Sep 19, 1:31 PM · MediaWiki-Core-Tests, Release-Engineering-Team (Kanban), Quibble, User-zeljkofilipin

Mon, Sep 17

phuedx closed T181118: [EPIC] Build a Chromium-based PDF renderer service as Resolved.

All subtasks have been resolved. Being bold.

Mon, Sep 17, 9:40 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Proton, Epic
phuedx closed T181118: [EPIC] Build a Chromium-based PDF renderer service, a subtask of T172815: Improve stability and maintainability of our browser-based PDF render service, as Resolved.
Mon, Sep 17, 9:40 AM · Electron-PDFs, OfflineContentGenerator, Operations, Services (designing)
phuedx closed T181118: [EPIC] Build a Chromium-based PDF renderer service, a subtask of T181079: [GOAL] Provide an expanded reading experience by improving the ways that users can download articles of interest for later consumption, as Resolved.
Mon, Sep 17, 9:40 AM · Readers-Web-Backlog, Reading Epics, Proton, Goal
phuedx closed T181118: [EPIC] Build a Chromium-based PDF renderer service, a subtask of T181084: [EPIC] Deploy the mediawiki-services-chromium-render service, as Resolved.
Mon, Sep 17, 9:40 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Readers-Web-Kanbanana-Board-Old, Proton, Epic

Thu, Sep 13

phuedx moved T203992: Random italicized text under Reading preferences section on Special: Preferences > Appearance tab from To Do to Needs Design Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.

@alexhollender: A friendly heads up that, per T203992#4579032, this change will be live on all wikis next Thursday (2018/09/20) and so should be reviewed by you. You can see the change in action here: https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences#mw-prefsection-rendering

Thu, Sep 13, 11:37 AM · Readers-Web-Backlog (Tracking), Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Page-Previews, MediaWiki-User-preferences, MediaWiki-Special-pages
phuedx edited projects for T203992: Random italicized text under Reading preferences section on Special: Preferences > Appearance tab, added: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1); removed Readers-Web-Backlog.
Thu, Sep 13, 11:32 AM · Readers-Web-Backlog (Tracking), Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Page-Previews, MediaWiki-User-preferences, MediaWiki-Special-pages
phuedx added a project to T203992: Random italicized text under Reading preferences section on Special: Preferences > Appearance tab: Readers-Web-Backlog.
Thu, Sep 13, 11:32 AM · Readers-Web-Backlog (Tracking), Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Page-Previews, MediaWiki-User-preferences, MediaWiki-Special-pages
phuedx added a comment to T204143: ReadingDepth events are not being sent in browsers where navigator.sendBeacon should be supported but in practice isn't.

On http://readers-web-master.wmflabs.org however, ReadingDepth doesn't seem to be logging at all, leading me to believe that maybe the WikimediaEvents repo isn't installed there. @Niedzielski can you confirm that? (I wasn't able to log into the server myself :/ )

Thu, Sep 13, 11:24 AM · Patch-For-Review, Product-Analytics, Reading-analysis, Readers-Web-Backlog

Wed, Sep 12

phuedx updated the task description for T204055: Consistently represent asynchronous code execution.
Wed, Sep 12, 2:44 PM · Readers-Web-Backlog, Services (watching), Technical-Debt, Proton

Tue, Sep 11

phuedx added a comment to T203817: Continue webpack + test transition of mobile.startup.

Will this change make it even easier to extract the time module to a library that can be used by other teams.

Tue, Sep 11, 4:45 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Technical-Debt, MobileFrontend (MobileFrontend.js), User-Jdlrobson, MinervaNeue
phuedx set the point value for T198946: Add Schema property 'sameAs' pointing to Wikidata entries to 13.
Tue, Sep 11, 4:27 PM · Readers-Web-Backlog, MediaWiki-extensions-WikibaseClient, Wikidata, SEO
phuedx added a comment to T198946: Add Schema property 'sameAs' pointing to Wikidata entries.

Following on from @ovasileva's comment above, we (Web) also agreed that there are enough known unknowns (where the code lives and how we post-analysis requests) to warrant an estimate of 13 points.

Tue, Sep 11, 4:27 PM · Readers-Web-Backlog, MediaWiki-extensions-WikibaseClient, Wikidata, SEO
phuedx closed T178071: [EPIC] Complete the First Deployment tutorial/checklist for the trial render service, a subtask of T181084: [EPIC] Deploy the mediawiki-services-chromium-render service, as Resolved.
Tue, Sep 11, 1:57 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Readers-Web-Kanbanana-Board-Old, Proton, Epic
phuedx closed T178071: [EPIC] Complete the First Deployment tutorial/checklist for the trial render service as Resolved.

All subtasks of this task are resolved. Being bold.

Tue, Sep 11, 1:57 PM · Epic, Readers-Web-Backlog, Proton, Electron-PDFs
phuedx added a subtask for T186748: New service request: chromium-render/deploy: T204055: Consistently represent asynchronous code execution.
Tue, Sep 11, 1:55 PM · User-notice, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, Readers-Web-Kanbanana-Board-Old, Services (blocked), Service-deployment-requests, Proton, Electron-PDFs, Operations
phuedx added a parent task for T204055: Consistently represent asynchronous code execution: T186748: New service request: chromium-render/deploy.
Tue, Sep 11, 1:55 PM · Readers-Web-Backlog, Services (watching), Technical-Debt, Proton
phuedx created T204055: Consistently represent asynchronous code execution.
Tue, Sep 11, 1:46 PM · Readers-Web-Backlog, Services (watching), Technical-Debt, Proton
phuedx moved T181623: Chromium-render doesn't handle browser connection abort well from Blocked on Others to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.

@pmiazga: Could you provide instructions on how to test this?

Tue, Sep 11, 9:29 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work

Mon, Sep 10

phuedx added a comment to T199000: Remove redundant/non-critical styling rules in Minerva.

🤘

Mon, Sep 10, 5:22 PM · User-Ryasmeen, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Audiences-QA, Readers-Web-Kanbanana-Board-Old, MinervaNeue, CSS, User-Jdlrobson
phuedx updated the task description for T177765: Security review of mediawiki-services-chromium-render.
Mon, Sep 10, 5:18 PM · Services (watching), Security-Reviews
phuedx added a comment to T177765: Security review of mediawiki-services-chromium-render.

@Bawolff: How's this going? Sorry if I've missed an update elsewhere.

Mon, Sep 10, 5:17 PM · Services (watching), Security-Reviews

Thu, Sep 6

phuedx added a comment to T198946: Add Schema property 'sameAs' pointing to Wikidata entries.

OTOH the Google Rich Cards extension seems to add these script tags already (without the sameAs property AFAICT).

Thu, Sep 6, 12:04 PM · Readers-Web-Backlog, MediaWiki-extensions-WikibaseClient, Wikidata, SEO

Wed, Sep 5

phuedx added a comment to T203522: Popups php unit tests mysteriously failing and blocking merges.

^ Formalising that this blocks T202748 and T203013.

Wed, Sep 5, 5:25 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)
phuedx added a parent task for T203522: Popups php unit tests mysteriously failing and blocking merges: T203013: Page previews should use mw.user.getPageviewToken().
Wed, Sep 5, 5:24 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)
phuedx added a subtask for T203013: Page previews should use mw.user.getPageviewToken(): T203522: Popups php unit tests mysteriously failing and blocking merges.
Wed, Sep 5, 5:24 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, Page-Previews
phuedx added a parent task for T203522: Popups php unit tests mysteriously failing and blocking merges: T202748: [Bug] Popup build synchronization tests are not failing when they ought to.
Wed, Sep 5, 5:24 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)
phuedx added a subtask for T202748: [Bug] Popup build synchronization tests are not failing when they ought to: T203522: Popups php unit tests mysteriously failing and blocking merges.
Wed, Sep 5, 5:24 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Page-Previews
phuedx added a comment to T198946: Add Schema property 'sameAs' pointing to Wikidata entries.

To me, rather than creating a new extension this feels like something that should live in one of the Wikibase extensions. Can we reach out to Wikimedia DE to see where would be appropriate?

Wed, Sep 5, 9:53 AM · Readers-Web-Backlog, MediaWiki-extensions-WikibaseClient, Wikidata, SEO

Mon, Sep 3

phuedx updated subscribers of T198946: Add Schema property 'sameAs' pointing to Wikidata entries.

Quoting from @dr0ptp4kt's notes of the meeting on Wednesday, 29th August:

Mon, Sep 3, 5:50 PM · Readers-Web-Backlog, MediaWiki-extensions-WikibaseClient, Wikidata, SEO

Fri, Aug 31

phuedx added a comment to T118063: Reconsider the schema of the Edit event log.

I can confirm that I see the same behaviour described in T118063#4547350 – it's always good when browsers behave as specified!

Fri, Aug 31, 10:40 AM · Epic, Product-Analytics, VisualEditor, VisualEditor-MediaWiki, Contributors-Analysis

Thu, Aug 30

phuedx added a comment to T203013: Page previews should use mw.user.getPageviewToken().

Also, if all we need is to differentiate a handful of events beaconed from the same page view, we may want to consider a JavaScript number that increments. Would that suffice?

Thu, Aug 30, 9:30 AM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, Page-Previews

Wed, Aug 29

phuedx updated subscribers of T203013: Page previews should use mw.user.getPageviewToken().
Wed, Aug 29, 5:32 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, Page-Previews
phuedx updated the task description for T203013: Page previews should use mw.user.getPageviewToken().
Wed, Aug 29, 5:28 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, Page-Previews
phuedx added a comment to T203013: Page previews should use mw.user.getPageviewToken().

Note: be careful as page previews also has a concept of a linkInteractionToken for which there is no shared/well-defined API.

Wed, Aug 29, 5:26 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, Page-Previews
phuedx updated the task description for T200792: Run A/B test on page issues.
Wed, Aug 29, 4:28 PM · Page-Issue-Warnings, User-notice, Wikimedia-Site-requests, Readers-Web-Backlog
phuedx updated the task description for T200792: Run A/B test on page issues.
Wed, Aug 29, 4:23 PM · Page-Issue-Warnings, User-notice, Wikimedia-Site-requests, Readers-Web-Backlog

Tue, Aug 28

phuedx added a comment to T186748: New service request: chromium-render/deploy.

☝️ per @mobrovac's review of https://gerrit.wikimedia.org/r/#/c/mediawiki/services/chromium-render/+/451817/.

Tue, Aug 28, 2:56 PM · User-notice, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, Readers-Web-Kanbanana-Board-Old, Services (blocked), Service-deployment-requests, Proton, Electron-PDFs, Operations
phuedx moved T186748: New service request: chromium-render/deploy from Blocked on Others to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Tue, Aug 28, 2:55 PM · User-notice, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, Readers-Web-Kanbanana-Board-Old, Services (blocked), Service-deployment-requests, Proton, Electron-PDFs, Operations
phuedx moved T202940: [subtask] Various page issues events sending NaN for sectionNumbers in old treatment from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Tue, Aug 28, 2:41 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Page-Issue-Warnings
phuedx moved T202940: [subtask] Various page issues events sending NaN for sectionNumbers in old treatment from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Tue, Aug 28, 2:36 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Page-Issue-Warnings
phuedx added a comment to T202748: [Bug] Popup build synchronization tests are not failing when they ought to.

I would go so far as to say that this is UBN!

Tue, Aug 28, 2:32 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Page-Previews
phuedx moved T202940: [subtask] Various page issues events sending NaN for sectionNumbers in old treatment from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Tue, Aug 28, 2:22 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Page-Issue-Warnings
phuedx added a comment to T137449: Audit and update Dashboard (125) query to include/exclude correct Phab projects.

A few suggestions:

  • TextExtracts, Monobook and Vector should be made security-only. Vector we might want to clarify we review tasks related to current goals.
  • WikidataPageBanner, QuickSurveys - currently 7 days but we've not been doing that. Maybe bump to 14.
Tue, Aug 28, 11:13 AM · Readers-Web-Backlog, Reading-Web-WMF-Team-Process-Improvement

Fri, Aug 24

phuedx added a comment to T202026: Report client-side JavaScript errors in MobileFrontend practically.

👍

Fri, Aug 24, 2:24 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MobileFrontend (MobileFrontend.js)
phuedx added a comment to T202026: Report client-side JavaScript errors in MobileFrontend practically.

I've defined https://meta.wikimedia.org/wiki/Schema:ClientSideError and I've made a few editorial changes to the names provided in the description.

Fri, Aug 24, 11:38 AM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MobileFrontend (MobileFrontend.js)

Thu, Aug 23

phuedx awarded T199800: Enabling moved paragraphs everywhere and for mobile diffs a Mountain of Wealth token.
Thu, Aug 23, 3:40 PM · WMDE-QWERTY-Sprint-2018-08-14, MediaWiki-History-or-Diffs, wikidiff2, TCB-Team

Aug 23 2018

phuedx updated the task description for T202557: [Bug] Special:MobileOptions heading padding should be consistent.
Aug 23 2018, 9:37 AM · Google-Code-in-2018, Need-volunteer, Easy, Mobile, MobileFrontend, Readers-Web-Backlog

Aug 22 2018

phuedx placed T191528: Mobile page issues - allow page issues to display different severity levels up for grabs.
Aug 22 2018, 6:39 PM · User-Ryasmeen, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board-Old, Page-Issue-Warnings, Design
phuedx placed T200518: [Bug] Lazy loaded image placeholders larger than viewport cause horizontal scrollbar on small screens up for grabs.
Aug 22 2018, 6:38 PM · User-Ryasmeen, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Audiences-QA, Readers-Web-Kanbanana-Board-Old, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), MobileFrontend
phuedx moved T200518: [Bug] Lazy loaded image placeholders larger than viewport cause horizontal scrollbar on small screens from Needs QA to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.

I met with @Jdlrobson about this after today's kickoff ritual. We tested this in production (enwiki), and proved to ourselves that the fix works by following the QA steps in the description with the window set to 450px and 375px widths.

Aug 22 2018, 6:38 PM · User-Ryasmeen, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Audiences-QA, Readers-Web-Kanbanana-Board-Old, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), MobileFrontend
phuedx added a project to T202557: [Bug] Special:MobileOptions heading padding should be consistent: Mobile.
Aug 22 2018, 5:28 PM · Google-Code-in-2018, Need-volunteer, Easy, Mobile, MobileFrontend, Readers-Web-Backlog
phuedx added a project to T202557: [Bug] Special:MobileOptions heading padding should be consistent: MobileFrontend.
Aug 22 2018, 5:28 PM · Google-Code-in-2018, Need-volunteer, Easy, Mobile, MobileFrontend, Readers-Web-Backlog
phuedx placed T143189: [EPIC] Split MobileContext god object apart up for grabs.
Aug 22 2018, 5:26 PM · Readers-Web-Backlog, MW-1.28-release (WMF-deploy-2016-08-30_(1.28.0-wmf.17)), Reading-Web-Sprint-79-Uh-oh, Technical-Debt, Epic, MobileFrontend
phuedx placed T177057: Clarify production deployment requirements, outline and blockers up for grabs.
Aug 22 2018, 5:26 PM · Epic, Marvin
phuedx added a comment to T199000: Remove redundant/non-critical styling rules in Minerva.

Thanks for following up, @Jdlrobson.

Aug 22 2018, 5:09 PM · User-Ryasmeen, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Audiences-QA, Readers-Web-Kanbanana-Board-Old, MinervaNeue, CSS, User-Jdlrobson
phuedx moved T200518: [Bug] Lazy loaded image placeholders larger than viewport cause horizontal scrollbar on small screens from Needs Code Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.
Aug 22 2018, 5:08 PM · User-Ryasmeen, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Audiences-QA, Readers-Web-Kanbanana-Board-Old, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), MobileFrontend
phuedx moved T200518: [Bug] Lazy loaded image placeholders larger than viewport cause horizontal scrollbar on small screens from Needs QA to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.
Aug 22 2018, 5:08 PM · User-Ryasmeen, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Audiences-QA, Readers-Web-Kanbanana-Board-Old, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), MobileFrontend
phuedx created T202557: [Bug] Special:MobileOptions heading padding should be consistent.
Aug 22 2018, 5:01 PM · Google-Code-in-2018, Need-volunteer, Easy, Mobile, MobileFrontend, Readers-Web-Backlog
phuedx claimed T195880: Problems with external referrals?.
Aug 22 2018, 3:56 PM · Readers-Web-Backlog, Analytics
phuedx added a comment to T199000: Remove redundant/non-critical styling rules in Minerva.

When JS is disabled we don't show the icons. This was the case before the patches and now. We can revisit this now as icons can be shipped as uris rather than data uris but out of scope for this patch.

Aug 22 2018, 3:21 PM · User-Ryasmeen, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Audiences-QA, Readers-Web-Kanbanana-Board-Old, MinervaNeue, CSS, User-Jdlrobson
phuedx closed T202021: Regression: Notifications, Special:MobileOptions broken! as Resolved.

I tested this on the BC briefly and saw:

Aug 22 2018, 3:09 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Regression, Unplanned-Sprint-Work, Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board-Old, MinervaNeue
phuedx placed T197932: Display section issues modal up for grabs.

@ovasileva: Since you're the PO and you've just QA'd this, who do you think should sign it off?

Aug 22 2018, 2:40 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Ryasmeen, Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Readers-Web-Kanbanana-Board-Old, Page-Issue-Warnings
phuedx claimed T200518: [Bug] Lazy loaded image placeholders larger than viewport cause horizontal scrollbar on small screens.
Aug 22 2018, 2:12 PM · User-Ryasmeen, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Audiences-QA, Readers-Web-Kanbanana-Board-Old, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), MobileFrontend
phuedx added a comment to T200518: [Bug] Lazy loaded image placeholders larger than viewport cause horizontal scrollbar on small screens.

Hrrm. I'm seeing the same thing that @nray saw in T200518#4467436 on both reading-web-staging and readers-web-master, i.e. not what @alexhollender saw in T200518#4499137.

Aug 22 2018, 2:08 PM · User-Ryasmeen, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Audiences-QA, Readers-Web-Kanbanana-Board-Old, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), MobileFrontend
phuedx updated the task description for T200518: [Bug] Lazy loaded image placeholders larger than viewport cause horizontal scrollbar on small screens.
Aug 22 2018, 1:18 PM · User-Ryasmeen, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Audiences-QA, Readers-Web-Kanbanana-Board-Old, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), MobileFrontend
phuedx added a comment to T199000: Remove redundant/non-critical styling rules in Minerva.

I'm going to leave this in Needs QA for now until we figure out if the horizontal padding of the wikitext editor textarea has indeed changed.

Aug 22 2018, 1:17 PM · User-Ryasmeen, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Audiences-QA, Readers-Web-Kanbanana-Board-Old, MinervaNeue, CSS, User-Jdlrobson
phuedx added a comment to T199000: Remove redundant/non-critical styling rules in Minerva.

Following on from my comment above, I've noticed a couple of differences in the treatments of the last modified bar with JavaScript enabled and disabled.

Aug 22 2018, 1:07 PM · User-Ryasmeen, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Audiences-QA, Readers-Web-Kanbanana-Board-Old, MinervaNeue, CSS, User-Jdlrobson
phuedx added a comment to T199000: Remove redundant/non-critical styling rules in Minerva.

Search icon in mobile view and search icon inside Special:Search/SearchOverlay

Aug 22 2018, 12:52 PM · User-Ryasmeen, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Audiences-QA, Readers-Web-Kanbanana-Board-Old, MinervaNeue, CSS, User-Jdlrobson
phuedx claimed T199000: Remove redundant/non-critical styling rules in Minerva.

Claiming this per Readers Web's discussion about clearing down the Needs QA column during yesterday's standup.

Aug 22 2018, 12:03 PM · User-Ryasmeen, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Audiences-QA, Readers-Web-Kanbanana-Board-Old, MinervaNeue, CSS, User-Jdlrobson

Aug 21 2018

phuedx added a comment to T197931: Truncate page issues.

🎉🎉🎉 Excellent work, y'all!

Aug 21 2018, 9:47 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board-Old, Page-Issue-Warnings

Aug 16 2018

phuedx placed T198947: There should not be multiple h1 tags on mobile page HTML: Restructure mobile web header for SEO and accessibility up for grabs.
Aug 16 2018, 10:37 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board-Old, Accessibility, MinervaNeue, Mobile, SEO
phuedx placed T198579: Popups triggers "deprecated ResourceLoader module jquery.hidpi" on several pages up for grabs.
Aug 16 2018, 10:37 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board-Old, Easy, Page-Previews
phuedx added a comment to T202026: Report client-side JavaScript errors in MobileFrontend practically.

Create a new ErrorLog schema.

Aug 16 2018, 9:28 AM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MobileFrontend (MobileFrontend.js)

Aug 15 2018

phuedx added a comment to T181623: Chromium-render doesn't handle browser connection abort well.

@mobrovac/@Pchelolo: Could you review rMSCR3e074fd4abf8: Handle the stopping chromium rendering correctly and rMSCR130e32ee19dd: To prevent resource starvation, try to kill chromium after 3s at your earliest convenience?

Aug 15 2018, 1:48 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work
phuedx moved T201842: Use ContentHandler to obtain DifferenceEngine in MobileFrontend from Triaged but Future to Current Sprint (and resolved 2018-19 Q1) pre-milestone on the Readers-Web-Backlog board.
Aug 15 2018, 10:06 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Readers-Web-Kanbanana-Board-Old, MobileFrontend, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2)
phuedx moved T201842: Use ContentHandler to obtain DifferenceEngine in MobileFrontend from To Do to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.
Aug 15 2018, 10:06 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Readers-Web-Kanbanana-Board-Old, MobileFrontend, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2)
phuedx triaged T201842: Use ContentHandler to obtain DifferenceEngine in MobileFrontend as High priority.

Quoting @Tgr from IRC:

Aug 15 2018, 10:05 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Readers-Web-Kanbanana-Board-Old, MobileFrontend, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2)
phuedx awarded T193172: [Bug] Visiting a missing image or connection dropping causes the ImageOverlay to load forever a Party Time token.
Aug 15 2018, 4:22 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board-Old, MobileFrontend
phuedx added a comment to T201954: Add the print button to mobile browsers other than Chrome.

Prioritise as necessary!

Aug 15 2018, 4:18 AM · Readers-Web-Backlog (Design), Proton, New-Readers

Aug 14 2018

phuedx updated subscribers of T181623: Chromium-render doesn't handle browser connection abort well.

Notes from yesterday's standup ritual:

Aug 14 2018, 11:07 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work
phuedx updated subscribers of T186748: New service request: chromium-render/deploy.

Further to the above, AIUI both T181623: Chromium-render doesn't handle browser connection abort well and T177765: Security review of mediawiki-services-chromium-render block Proton's deployment. @pmiazga has submitted two changes for the former and @charlotteportero has just let me know that the latter is being worked on and is expected to be resolved within two weeks.

Aug 14 2018, 9:16 AM · User-notice, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, Readers-Web-Kanbanana-Board-Old, Services (blocked), Service-deployment-requests, Proton, Electron-PDFs, Operations

Aug 13 2018

phuedx added a comment to T181623: Chromium-render doesn't handle browser connection abort well.

Regarding T181623#4495059, can anyone in Readers Web review @pmiazga's changes? I'll also ask during today's standup ritual.

Aug 13 2018, 11:39 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work
phuedx added a comment to T191532: Mobile page issues - instrument page issues.

@Tbayer: Did you want to set up a meeting with an engineer to go through the instrumentation manually (further to the QA steps that @Jdlrobson added). IIRC we did that for Page Previews and it was useful.

Aug 13 2018, 11:03 AM · User-Ryasmeen, Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Page-Issue-Warnings
phuedx added a comment to T199282: Regression: Increase in time to first interactive; lead paragraph doesn't move on Barack Obama due to mw-empty-elt.

Sorry if we have and I've missed the comment but have we determined that the spike that @Jdlrobson previously observed (see below) has flattened out?

Aug 13 2018, 10:51 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Ryasmeen, Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), Patch-For-Review, Readers-Web-Kanbanana-Board-Old, Regression, Performance

Aug 7 2018

phuedx updated the task description for T201124: Provide standard/reproducible way to access a PageToken.
Aug 7 2018, 4:56 PM · MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, Analytics, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents, Page-Previews, Readers-Web-Kanbanana-Board-Old, Technical-Debt, Performance-Team (Radar), Page-Issue-Warnings
phuedx awarded Blog Post: Wikipedia goes 100% Forward Secret a Mountain of Wealth token.
Aug 7 2018, 5:21 AM · Traffic

Aug 6 2018

phuedx added a comment to T201068: Modern Event Platform: Scalable Event Intake.

Could you elaborate on that? There would be validation upon event message intake (i.e. that they conform to a particular schema).

Aug 6 2018, 4:57 PM · Services (watching), Analytics-EventLogging, EventBus, Analytics, Analytics-Kanban

Aug 3 2018

phuedx closed T200867: Uncaught TypeError: Cannot read property 'getLeadSectionElement' of undefined as Resolved.

Being bold… again!

Aug 3 2018, 5:25 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Regression, Readers-Web-Kanbanana-Board-Old
phuedx added a comment to T192622: [EPIC] Page previews post-deploy cleanup.

🎉🎉🎉

Aug 3 2018, 5:17 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Epic, Page-Previews, Readers-Web-Kanbanana-Board-Old
phuedx added a comment to T200792: Run A/B test on page issues.

I stand corrected. Especially about the note about the control group, which I think I confused in the construction of the Page Previews A/B tests when we were running them. Thanks, @Tbayer!

Aug 3 2018, 1:48 PM · Page-Issue-Warnings, User-notice, Wikimedia-Site-requests, Readers-Web-Backlog
phuedx added a comment to T200792: Run A/B test on page issues.

I didn't mean to cause confusion with my comment. If I have, then I apologise.

Aug 3 2018, 9:41 AM · Page-Issue-Warnings, User-notice, Wikimedia-Site-requests, Readers-Web-Backlog
phuedx added a comment to T201068: Modern Event Platform: Scalable Event Intake.

As an engineer, I want good client libraries to produce events so that I don't have to write them myself.

Aug 3 2018, 9:31 AM · Services (watching), Analytics-EventLogging, EventBus, Analytics, Analytics-Kanban
phuedx added a comment to T200792: Run A/B test on page issues.

An A/B test by definition will split users into 2 equal buckets - 50% group A and 50% group B. The sampling rate defines the total number of users in the test,soif we are using a sampling rate of 10% of 100 users, that will be 10 users, with 5 in group A and 5 in group B.

Aug 3 2018, 9:28 AM · Page-Issue-Warnings, User-notice, Wikimedia-Site-requests, Readers-Web-Backlog
phuedx placed T200867: Uncaught TypeError: Cannot read property 'getLeadSectionElement' of undefined up for grabs.
Aug 3 2018, 8:32 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Regression, Readers-Web-Kanbanana-Board-Old