Page MenuHomePhabricator

phuedx (Sam Smith)
Senior Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 14 2014, 10:42 AM (306 w, 1 d)
Availability
Available
IRC Nick
phuedx
LDAP User
Unknown
MediaWiki User
Phuedx (WMF) [ Global Accounts ]

Recent Activity

Fri, Sep 25

phuedx added a comment to T263032: Deploy the new location of the search bar to new vector and begin A/B test on test wikis.

Just a note to say that the current sample size for the SearchSatisfaction instrumentation is 1% of all sessions across all wikis. I've discussed this with @ovasileva and we're fairly confident that no further changes need to be made.

Fri, Sep 25, 2:01 PM · Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)

Thu, Sep 24

phuedx added a comment to T257698: Instrument Vue.js search.

This is blocked on T256041: Build the wvui-search-form component for Vue.js search.

Thu, Sep 24, 3:06 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Product-Infrastructure-Team-Backlog, Product-Analytics, Vue.js (Vue.js-Search)
phuedx moved T257698: Instrument Vue.js search from Doing to Blocked on Others on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Thu, Sep 24, 3:03 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Product-Infrastructure-Team-Backlog, Product-Analytics, Vue.js (Vue.js-Search)
phuedx placed T256100: Add skin version and search version fields to search satisfaction schema up for grabs.
Thu, Sep 24, 12:53 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Vue.js (Vue.js-Search), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements

Tue, Sep 22

phuedx added a comment to T256100: Add skin version and search version fields to search satisfaction schema.

Here's my notes on setting up my local development environment (MediaWiki Docker) to test this:

Tue, Sep 22, 12:33 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Vue.js (Vue.js-Search), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
phuedx added a comment to T259250: A/B test setup for search changes.

@Edtadros and I went through the following scenarios:

Tue, Sep 22, 10:09 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Vue.js (Vue.js-Search), Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)

Mon, Sep 21

phuedx moved T256100: Add skin version and search version fields to search satisfaction schema from Doing to Needs QA on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.

This will be QA'd alongside T259250.

Mon, Sep 21, 11:14 AM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Vue.js (Vue.js-Search), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
phuedx moved T252850: Fix a tagline's small font on the logos of some projects from Design to Triaged but Future on the Readers-Web-Backlog board.
Mon, Sep 21, 11:10 AM · Readers-Web-Backlog, Desktop Improvements, Accessibility, Design, Logos
phuedx closed T261804: Technical: Drop getContentTransformations and setContentTransformations in MobileContext as Resolved.

👍

Mon, Sep 21, 11:04 AM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Readers-Web-Backlog (Kanbanana-2020-21-Q1), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
phuedx closed T261804: Technical: Drop getContentTransformations and setContentTransformations in MobileContext, a subtask of T143189: [EPIC] Split MobileContext god object apart, as Resolved.
Mon, Sep 21, 11:04 AM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MW-1.28-release (WMF-deploy-2016-08-30_(1.28.0-wmf.17)), Reading-Web-Sprint-79-Uh-oh, Technical-Debt, Epic
phuedx added a comment to T235812: Make Getting Started temporarily suppress the VE dialog by adding "vehidebetadialog" to the query string.

@phuedx - Since I can't get any traction with the Growth team on this, any chance you'd like to own it?

Mon, Sep 21, 9:51 AM · Growth-Team (Current Sprint), MediaWiki-extensions-GettingStarted

Wed, Sep 16

phuedx added a comment to T262300: Instrumentation Data-QA Checklist for SearchSatisfaction schema changes.

Here are a handful of events that I've seen during the development of T256100: Add skin version and search version fields to search satisfaction schema:

Wed, Sep 16, 5:27 PM · Product-Analytics (Kanban), Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
phuedx placed T256100: Add skin version and search version fields to search satisfaction schema up for grabs.
Wed, Sep 16, 5:09 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Vue.js (Vue.js-Search), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
phuedx moved T256100: Add skin version and search version fields to search satisfaction schema from Needs QA to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Wed, Sep 16, 5:09 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Vue.js (Vue.js-Search), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
phuedx added a comment to T256100: Add skin version and search version fields to search satisfaction schema.

A couple of notes about the changes that've been made and what to expect:

Wed, Sep 16, 3:47 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Vue.js (Vue.js-Search), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements

Tue, Sep 15

phuedx claimed T256100: Add skin version and search version fields to search satisfaction schema.

Per the SearchSatisfaction Instrumentation & Data-QA meeting, I'll add more notes about fields that will be populated and for @Edtadros to do QA in his local development environment.

Tue, Sep 15, 3:43 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Vue.js (Vue.js-Search), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
phuedx reassigned T256100: Add skin version and search version fields to search satisfaction schema from phuedx to Edtadros.
Tue, Sep 15, 3:06 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Vue.js (Vue.js-Search), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
phuedx claimed T257698: Instrument Vue.js search.
Tue, Sep 15, 11:38 AM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Product-Infrastructure-Team-Backlog, Product-Analytics, Vue.js (Vue.js-Search)
phuedx moved T257698: Instrument Vue.js search from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Tue, Sep 15, 11:38 AM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Product-Infrastructure-Team-Backlog, Product-Analytics, Vue.js (Vue.js-Search)
phuedx moved T256100: Add skin version and search version fields to search satisfaction schema from Ready for Signoff to Needs QA on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.

This is particularly tricky to test anywhere other that your local development environment as the sampling/bucketing code that enables the instrument is in WikimediaEvents/modules/ext.wikimediaEvents/searchSatisfaction.js. That being said, it doesn't mean it shouldn't be QA'd. I'd be happy to pair with @Edtadros on this.

Tue, Sep 15, 11:38 AM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Vue.js (Vue.js-Search), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
phuedx closed T260065: Pass server-rendered search form state to client on initial render of Vue.js search as Resolved.

Closing this as resolved since I tested @Niedzielski's patch locally prior to merging it and we're deferring QA of the feature until after the feature branch is merged into master and deployed to the BC.

Tue, Sep 15, 11:13 AM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)
phuedx closed T260065: Pass server-rendered search form state to client on initial render of Vue.js search, a subtask of T249299: [Epic] Build the new Vue.js search experience, as Resolved.
Tue, Sep 15, 11:12 AM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search), Epic, Desktop Improvements
phuedx moved T261769: MobileFormatter follow up work from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.

I've left a couple of minor nits on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/626162/ and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/627436 is V:-1.

Tue, Sep 15, 10:57 AM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1)

Mon, Sep 14

phuedx added a comment to T262213: XSS on Pages viewed on Mobile.

Patches to master, REL1_{31,34,35} have been submitted and merged.

Mon, Sep 14, 12:47 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Mobile, MobileFrontend, Vuln-XSS, Security, Security-Team

Fri, Sep 11

phuedx added a comment to T262213: XSS on Pages viewed on Mobile.

I'm doing the backports now…

Fri, Sep 11, 11:42 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Mobile, MobileFrontend, Vuln-XSS, Security, Security-Team
phuedx moved T259250: A/B test setup for search changes from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Fri, Sep 11, 11:40 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Vue.js (Vue.js-Search), Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
phuedx moved T259250: A/B test setup for search changes from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Fri, Sep 11, 11:39 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Vue.js (Vue.js-Search), Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
phuedx added a comment to T258971: PrefUpdate event.isDefault field is not recoded correctly for some user properties.

@MNeisler: Thanks for the ping. I've written up the bug in T262661: BetaFeatures not strictly compatible with PrefUpdate instrumentation or vice versa. I also came across T77058: Show Metrics Dashboard for Beta Features in my Phab travels, which may be of interest.

Fri, Sep 11, 11:32 AM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Product-Analytics
phuedx triaged T262661: BetaFeatures not strictly compatible with PrefUpdate instrumentation or vice versa as Low priority.

Per the note in the description.

Fri, Sep 11, 11:30 AM · MediaWiki-extensions-WikimediaEvents, BetaFeatures
phuedx created T262661: BetaFeatures not strictly compatible with PrefUpdate instrumentation or vice versa.
Fri, Sep 11, 11:30 AM · MediaWiki-extensions-WikimediaEvents, BetaFeatures
phuedx updated the task description for T262580: Drop support for the deprecated mobileview "noimages" api parameter.
Fri, Sep 11, 9:18 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Patch-For-Review, User-Jdlrobson, MobileFrontend (MobileFrontend and MinervaNeue architecture)

Thu, Sep 10

phuedx claimed T262213: XSS on Pages viewed on Mobile.

I'm doing the backports now…

Thu, Sep 10, 5:10 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Mobile, MobileFrontend, Vuln-XSS, Security, Security-Team

Wed, Sep 9

Jdlrobson awarded T229042: Reading_depth: deactivate eventlogging instrumentation a Like token.
Wed, Sep 9, 4:46 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Patch-For-Review, Performance-Team (Radar), Readers-Web-Backlog, Analytics-Radar, Reading Depth, Product-Analytics
phuedx claimed T259250: A/B test setup for search changes.
Wed, Sep 9, 4:24 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Vue.js (Vue.js-Search), Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
phuedx moved T256100: Add skin version and search version fields to search satisfaction schema from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Wed, Sep 9, 4:24 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Vue.js (Vue.js-Search), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
phuedx added a comment to T256100: Add skin version and search version fields to search satisfaction schema.

Thanks for the ping, @Jdlrobson! I've updated the patch and removed my -2.

Wed, Sep 9, 4:22 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Vue.js (Vue.js-Search), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
phuedx closed T229042: Reading_depth: deactivate eventlogging instrumentation as Resolved.
Wed, Sep 9, 2:08 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Patch-For-Review, Performance-Team (Radar), Readers-Web-Backlog, Analytics-Radar, Reading Depth, Product-Analytics
phuedx added a comment to T229042: Reading_depth: deactivate eventlogging instrumentation.

I've updated the schema's documentation/talk page on metawiki.

Wed, Sep 9, 2:07 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Patch-For-Review, Performance-Team (Radar), Readers-Web-Backlog, Analytics-Radar, Reading Depth, Product-Analytics
phuedx added a comment to T262213: XSS on Pages viewed on Mobile.

AIUI backports to REL1_{31,34,35} still need to be done. Is that correct?

Wed, Sep 9, 10:35 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Mobile, MobileFrontend, Vuln-XSS, Security, Security-Team
phuedx added a comment to T262213: XSS on Pages viewed on Mobile.

@dcipoletti has confirmed that, at least from our side, that this task can be opened up via Slack.

Wed, Sep 9, 10:34 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Mobile, MobileFrontend, Vuln-XSS, Security, Security-Team
phuedx added a comment to T229042: Reading_depth: deactivate eventlogging instrumentation.

The production payload for readingDepth.js is still being transferred and parsed on all page views. Can this be removed?

Wed, Sep 9, 9:29 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Patch-For-Review, Performance-Team (Radar), Readers-Web-Backlog, Analytics-Radar, Reading Depth, Product-Analytics

Tue, Sep 8

phuedx added a comment to T262213: XSS on Pages viewed on Mobile.

Are you happy for the patch to go into gerrit? This is going to be needed "soon" as basically every patch that changes resources/dist/mobile.common.js and resources/dist/mobile.common.js.map.json is going to cause the security patch to not apply as part of the train. And as it's not just a trivial rebase (as it's a rebase + running webpack build stuff), it's more work than most patches.

Tue, Sep 8, 5:11 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Mobile, MobileFrontend, Vuln-XSS, Security, Security-Team
phuedx added a comment to T262213: XSS on Pages viewed on Mobile.

A couple more notes about the scope of the attack:

Tue, Sep 8, 4:15 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Mobile, MobileFrontend, Vuln-XSS, Security, Security-Team
phuedx added a comment to T262213: XSS on Pages viewed on Mobile.

Here's a brief writeup of the problem and why the fix makes sense:

Tue, Sep 8, 2:36 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Mobile, MobileFrontend, Vuln-XSS, Security, Security-Team

Mon, Sep 7

phuedx added a comment to T262213: XSS on Pages viewed on Mobile.

Brief update: There's a patch inbound from @nray. We've got a good handle on the issue.

Mon, Sep 7, 9:29 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Mobile, MobileFrontend, Vuln-XSS, Security, Security-Team
phuedx added a comment to T262213: XSS on Pages viewed on Mobile.

To confirm what @nray says above:

Mon, Sep 7, 6:53 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Mobile, MobileFrontend, Vuln-XSS, Security, Security-Team
phuedx added a comment to T262213: XSS on Pages viewed on Mobile.

Thanks @Platonides. Changing your example to

Mon, Sep 7, 6:14 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Mobile, MobileFrontend, Vuln-XSS, Security, Security-Team
phuedx added a comment to T261842: Create schema to track users opting in/out of desktop improvements.

Did we confirm that we're not rewriting the preferences table based on whether someone has interacted with other preferences?

Mon, Sep 7, 4:49 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
phuedx placed T259250: A/B test setup for search changes up for grabs.
Mon, Sep 7, 3:38 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Vue.js (Vue.js-Search), Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
phuedx closed T258971: PrefUpdate event.isDefault field is not recoded correctly for some user properties as Resolved.

I'm being bold and resolving this as T261842: Create schema to track users opting in/out of desktop improvements has been created.

Mon, Sep 7, 3:38 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Product-Analytics
phuedx added a comment to T261842: Create schema to track users opting in/out of desktop improvements.

We will need the following

  • Session ID
Mon, Sep 7, 3:32 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
phuedx moved T259250: A/B test setup for search changes from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.

@Jdlrobson's changes LGTM but I've left a question on https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/623644 that could simplify the implementation a little.

Mon, Sep 7, 2:00 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Vue.js (Vue.js-Search), Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
phuedx claimed T259250: A/B test setup for search changes.
Mon, Sep 7, 1:22 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Vue.js (Vue.js-Search), Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
phuedx closed T240622: [Technical debt payoff] Remove InlineDiffFormatter and InlineDifferenceEngine from MobileFrontend as Resolved.

FTR https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/623372 was merged. Being bold and resolving this task.

Mon, Sep 7, 10:21 AM · MW-1.36-notes (1.36.0-wmf.6; 2020-08-25), Readers-Web-Backlog (Kanbanana-2020-21-Q1), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), MobileFrontend, User-Jdlrobson, Desktop Improvements, Multi-Content-Revisions, Technical-Debt (RW-Tech-Debt)
phuedx closed T240622: [Technical debt payoff] Remove InlineDiffFormatter and InlineDifferenceEngine from MobileFrontend, a subtask of T117279: [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff), as Resolved.
Mon, Sep 7, 10:20 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), User-Jdlrobson, Desktop Improvements, TechCom, MobileFrontend (MobileFrontend Special Pages), Multi-Content-Revisions, Readers-Web-Backlog (Tracking), Technical-Debt (RW-Tech-Debt)
phuedx moved T257698: Instrument Vue.js search from Needs Analysis to Upcoming on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Mon, Sep 7, 9:08 AM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Product-Infrastructure-Team-Backlog, Product-Analytics, Vue.js (Vue.js-Search)
phuedx added a comment to T257698: Instrument Vue.js search.

It's worth pointing out that if we do choose to ignore the protocol for 4 and 5 above, we'll still have to reconcile the Vue.js-based search widget with the protocol or vice versa if/when it's deployed.

Mon, Sep 7, 9:07 AM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Product-Infrastructure-Team-Backlog, Product-Analytics, Vue.js (Vue.js-Search)

Fri, Aug 28

phuedx updated the task description for T259250: A/B test setup for search changes.
Fri, Aug 28, 11:26 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Vue.js (Vue.js-Search), Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
phuedx updated the task description for T259250: A/B test setup for search changes.
Fri, Aug 28, 11:24 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Vue.js (Vue.js-Search), Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
phuedx added a comment to T259250: A/B test setup for search changes.

Currently the search in header feature is controlled by a feature flag $wgVectorIsSearchInHeader . This would need to be changed to use SearchInHeaderLookup (like SkinVersionLookup). For logged in users, the A/B test would need to be applied based on User id using a mod operator.

Fri, Aug 28, 11:24 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Vue.js (Vue.js-Search), Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)

Aug 27 2020

phuedx added a comment to T257698: Instrument Vue.js search.

I'm going to start by defining some terms – that this has to be done should probably be taken as a warning sign for a long comment!

Aug 27 2020, 5:57 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Product-Infrastructure-Team-Backlog, Product-Analytics, Vue.js (Vue.js-Search)

Aug 26 2020

phuedx claimed T240622: [Technical debt payoff] Remove InlineDiffFormatter and InlineDifferenceEngine from MobileFrontend.
Aug 26 2020, 5:08 PM · MW-1.36-notes (1.36.0-wmf.6; 2020-08-25), Readers-Web-Backlog (Kanbanana-2020-21-Q1), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), MobileFrontend, User-Jdlrobson, Desktop Improvements, Multi-Content-Revisions, Technical-Debt (RW-Tech-Debt)
phuedx added a comment to T257953: [Technical debt payoff] Drop MFSpecialCaseMainPage, from MobileFrontend.

https://www.mediawiki.org/wiki/Mobile_Gateway/Mobile_homepage_formatting needs to be updated.

Aug 26 2020, 2:04 PM · MW-1.36-notes (1.36.0-wmf.6; 2020-08-25), Technical-Debt, Readers-Web-Backlog (Kanbanana-2020-21-Q1), MW-1.36-release, User-Jdlrobson, MobileFrontend

Aug 25 2020

phuedx added a comment to T259250: A/B test setup for search changes.

We skipped estimating this task during today's HOLD FOR READERS WEB meeting as @Jdlrobson is OoO.

Aug 25 2020, 4:43 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Vue.js (Vue.js-Search), Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
phuedx placed T256100: Add skin version and search version fields to search satisfaction schema up for grabs.
Aug 25 2020, 11:58 AM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Vue.js (Vue.js-Search), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
phuedx moved T256100: Add skin version and search version fields to search satisfaction schema from Needs Analysis to Upcoming on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Aug 25 2020, 11:58 AM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Vue.js (Vue.js-Search), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
phuedx updated the task description for T256100: Add skin version and search version fields to search satisfaction schema.
Aug 25 2020, 11:58 AM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Vue.js (Vue.js-Search), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
phuedx updated the task description for T256100: Add skin version and search version fields to search satisfaction schema.
Aug 25 2020, 11:12 AM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Vue.js (Vue.js-Search), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements

Aug 24 2020

phuedx added a comment to T258971: PrefUpdate event.isDefault field is not recoded correctly for some user properties.

Likewise, a default hasn't been set for the discussiontools-betaenable user preference. We should notify the authors.

Aug 24 2020, 6:18 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Product-Analytics
phuedx added a comment to T260867: PrefUpdate captures user preference modifications at registration.

this is just instrumentation work, right?

Aug 24 2020, 4:31 PM · Patch-For-Review, Analytics-Radar, Product-Analytics, Growth-Team
phuedx assigned T258580: Desktop improvements only default for logged out users to ovasileva.

Being bold.

Aug 24 2020, 1:49 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
phuedx added a comment to T260065: Pass server-rendered search form state to client on initial render of Vue.js search.

@Niedzielski: I followed the default process for this card and moved it to Needs QA. If it shouldn't be there, then LMK.

Aug 24 2020, 12:56 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)
phuedx reassigned T260065: Pass server-rendered search form state to client on initial render of Vue.js search from phuedx to Edtadros.
Aug 24 2020, 12:56 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)
phuedx updated subscribers of T260867: PrefUpdate captures user preference modifications at registration.

This appears to have been caused by rEWMV30731c2c748a: PrefUpdate: Add property tracking filter, which removed the PrefUpdateInstrumentation::isKnownSettingsPage test prior to sending the PrefUpdate events. That test would pass if the current request was to a known settings page or the options API, which was being used as a proxy for whether the user was updating their preferences themselves. PrefUpdate events logged in that case are no longer distinguishable from those logged due to calls to User::saveSettings on the server-side.

Aug 24 2020, 11:04 AM · Patch-For-Review, Analytics-Radar, Product-Analytics, Growth-Team

Aug 21 2020

phuedx added a comment to T258971: PrefUpdate event.isDefault field is not recoded correctly for some user properties.

Further to my comment above (T258971#6348418), determining what the default value of the property complicated by us potentially treating newly-created users and existing users differently (see the VectorDefaultSkinVersionForNewAccounts and VectorDefaultSkinVersionForExistingAccounts configuration variables respectively). Remembering that the instrument runs whenever the user updates their preferences (or we update them on their behalf) and is implemented outside of the Vector codebase, we'd need a mechanism to signal to the instrument what we think that the default value for the preference should be.

Aug 21 2020, 4:49 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Product-Analytics
phuedx closed T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped as Resolved.

Thanks all!

Aug 21 2020, 12:29 PM · MW-1.35-notes, MW-1.35-release, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Patch-For-Review, Performance-Team (Radar), Vue.js (Vue.js-Search), MediaWiki-Interface, Desktop Improvements
phuedx closed T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped, a subtask of T249299: [Epic] Build the new Vue.js search experience, as Resolved.
Aug 21 2020, 12:28 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search), Epic, Desktop Improvements
phuedx closed T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped, a subtask of T257127: "Global account info" looks sortable on mobile but isn't, as Resolved.
Aug 21 2020, 12:28 PM · MediaWiki-extensions-CentralAuth
phuedx updated subscribers of T255458: Enable $wgMFNoindexPages for all wikis.

I've been bold and estimated this task since it's Ready for Signoff already (/cc @MBinder_WMF). I voted an XS as this was a configuration change and we don't include Product Analytics' work in our estimates.

Aug 21 2020, 11:57 AM · Readers-Web-Backlog (Kanbanana-2020-21-Q1)
phuedx set the point value for T255458: Enable $wgMFNoindexPages for all wikis to 1.
Aug 21 2020, 11:54 AM · Readers-Web-Backlog (Kanbanana-2020-21-Q1)
phuedx added a comment to T255458: Enable $wgMFNoindexPages for all wikis.

@MNeisler @ovasileva: Is there a task tracking the quick review of search-referred pageviews or would you prefer that this be the task so as not to fragment the conversation too much? If the former, then I'll happily sign this task off.

Aug 21 2020, 11:53 AM · Readers-Web-Backlog (Kanbanana-2020-21-Q1)
phuedx moved T259250: A/B test setup for search changes from Needs Analysis to Upcoming on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Aug 21 2020, 11:48 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Vue.js (Vue.js-Search), Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
phuedx updated the task description for T259250: A/B test setup for search changes.
Aug 21 2020, 11:48 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Vue.js (Vue.js-Search), Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)

Aug 20 2020

phuedx claimed T260065: Pass server-rendered search form state to client on initial render of Vue.js search.
Aug 20 2020, 5:20 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)
phuedx placed T258493: [Spike 8hrs] "Use Legacy Vector" is not working as a global preference up for grabs.
Aug 20 2020, 5:19 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), User-notice, MediaWiki-extensions-GlobalPreferences, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
phuedx claimed T255458: Enable $wgMFNoindexPages for all wikis.
Aug 20 2020, 5:17 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1)
phuedx moved T197188: Lazy loaded images: MobileFormatter should take into account mobile image dimension adjustments from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Aug 20 2020, 12:20 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Performance Issue, MobileFrontend
phuedx moved T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Aug 20 2020, 12:19 PM · MW-1.35-notes, MW-1.35-release, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Patch-For-Review, Performance-Team (Radar), Vue.js (Vue.js-Search), MediaWiki-Interface, Desktop Improvements

Aug 19 2020

phuedx moved T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped from Ready for Signoff to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/619157 and https://gerrit.wikimedia.org/r/c/mediawiki/core/+/620897 still need code review.

Aug 19 2020, 5:37 PM · MW-1.35-notes, MW-1.35-release, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Patch-For-Review, Performance-Team (Radar), Vue.js (Vue.js-Search), MediaWiki-Interface, Desktop Improvements
phuedx updated the task description for T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped.
Aug 19 2020, 5:20 PM · MW-1.35-notes, MW-1.35-release, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Patch-For-Review, Performance-Team (Radar), Vue.js (Vue.js-Search), MediaWiki-Interface, Desktop Improvements
phuedx updated the task description for T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped.
Aug 19 2020, 3:38 PM · MW-1.35-notes, MW-1.35-release, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Patch-For-Review, Performance-Team (Radar), Vue.js (Vue.js-Search), MediaWiki-Interface, Desktop Improvements
phuedx closed T246491: Special:GlobalPreferences does not deal well with "conditional preferences" (using hide-if) as Resolved.

Thanks to @Samwilson for the fix and to @Jdlrobson for the merge.

Aug 19 2020, 2:14 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), GrowthExperiments, Desktop Improvements, Vector, Community-Tech, MediaWiki-extensions-GlobalPreferences, Growth-Team
phuedx moved T258493: [Spike 8hrs] "Use Legacy Vector" is not working as a global preference from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Aug 19 2020, 11:29 AM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), User-notice, MediaWiki-extensions-GlobalPreferences, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements

Aug 17 2020

phuedx moved T249366: [Spike] What should we instrument in the new Vue.js search experience? from Needs Analysis to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.

Being bold.

Aug 17 2020, 5:08 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search), Discovery, Spike
phuedx added a project to T249366: [Spike] What should we instrument in the new Vue.js search experience?: Readers-Web-Backlog (Kanbanana-2020-21-Q1).
Aug 17 2020, 5:06 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search), Discovery, Spike
phuedx updated the task description for T249366: [Spike] What should we instrument in the new Vue.js search experience?.
Aug 17 2020, 5:02 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search), Discovery, Spike
phuedx added a comment to T259250: A/B test setup for search changes.

Per T249366: [Spike] What should we instrument in the new Vue.js search experience?, we're resolved to use the SearchSatisfaction schema to gather data for this A/B test (and afterwards?). As I mentioned above, searchSatisfaction.js contains modules that deal with session management and sampling and bucketing the user. This leaves us with one of three adventures to choose from:

Aug 17 2020, 2:46 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Vue.js (Vue.js-Search), Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)

Aug 14 2020

phuedx added a comment to T249366: [Spike] What should we instrument in the new Vue.js search experience?.

@phuedx, @Niedzielski - would it make sense to close this task?

Aug 14 2020, 11:24 AM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search), Discovery, Spike

Aug 12 2020

phuedx claimed T256100: Add skin version and search version fields to search satisfaction schema.
Aug 12 2020, 2:05 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Vue.js (Vue.js-Search), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements

Aug 10 2020

phuedx updated the task description for T260065: Pass server-rendered search form state to client on initial render of Vue.js search.
Aug 10 2020, 4:30 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)