Page MenuHomePhabricator

phuedx (Sam Smith)
Engineering Manager, Readers

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Nov 14 2014, 10:42 AM (248 w, 4 d)
Availability
Available
IRC Nick
phuedx
LDAP User
Unknown
MediaWiki User
Phuedx (WMF) [ Global Accounts ]

Recent Activity

Today

phuedx added a project to T229042: Reading_depth remove eventlogging instrumentation?: Reading Depth.
Tue, Aug 20, 9:28 AM · Reading Depth, Readers-Web-Backlog (Needs Product Owner Decisions), Product-Analytics, Analytics

Yesterday

phuedx moved T200093: Use Paint Timing API instead of deprecated chrome.loadTimes() in ReadingDepth schema from Backlog to Feature requests on the Reading Depth board.
Mon, Aug 19, 12:44 PM · Readers-Web-Backlog (Needs Product Owner Decisions), Reading Depth, Performance-Team (Radar), MediaWiki-extensions-WikimediaEvents, Technical-Debt
phuedx moved T207899: ReadingDepth events should only be sent for pageviews from Backlog to Feature requests on the Reading Depth board.
Mon, Aug 19, 12:44 PM · Readers-Web-Backlog (Needs Product Owner Decisions), Reading Depth
phuedx moved T208594: ReadingDepth: Add some new fields to the schema from Backlog to Feature requests on the Reading Depth board.
Mon, Aug 19, 12:44 PM · Readers-Web-Backlog (Needs Product Owner Decisions), Reading Depth
phuedx moved T219212: Augment ReadingDepth schema with data from Page Lifecycle API from Backlog to Feature requests on the Reading Depth board.
Mon, Aug 19, 12:44 PM · Readers-Web-Backlog (Needs Product Owner Decisions), Reading Depth, Product-Analytics
phuedx removed a project from T148262: Vet and explore new readership engagement metric: Patch-For-Review.
Mon, Aug 19, 12:43 PM · Reading Depth, Product-Analytics, Reading-analysis
phuedx moved T212330: [Bug] Many JSON decode ReadingDepth schema errors from wikiyy from Backlog to EventLogging related on the Reading Depth board.
Mon, Aug 19, 12:42 PM · Reading Depth, Readers-Web-Backlog (Tracking), Analytics
phuedx moved T216063: [Bug] Many ReadingDepth validation errors logged from Backlog to EventLogging related on the Reading Depth board.
Mon, Aug 19, 12:42 PM · Reading Depth, Readers-Web-Backlog (Tracking), Analytics
phuedx closed T228890: Notification icon should be visible when the notification drawer is open as Resolved.

Confirmed in Chrome (76.0.3809.100) on macOS Mojave (10.14.6) in production.

Mon, Aug 19, 10:10 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue
phuedx closed T225768: [Bug] Minerva's History Action "Compare selected revisions" button is missing padding [desktop] as Resolved.

Padding is restored

Mon, Aug 19, 10:04 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, good first bug, UI-Standardization, MinervaNeue, MediaWiki-History-and-Diffs

Thu, Aug 15

phuedx added a comment to T230185: Wrong section in edit summary of mobile editor.

When saving, I was not given the option to see or edit the section in the summary.

Thu, Aug 15, 11:31 AM · Readers-Web-Backlog (Tracking), VisualEditor, MobileFrontend, Mobile
phuedx moved T229802: Homepage: Add information about the how "mentorship" works to newcomers who are unfamiliar with this concept from Needs triage to Growth on the Mobile board.
Thu, Aug 15, 11:11 AM · Growth-Team (Current Sprint), Mobile, Desktop, GrowthExperiments- MentorshipModule, Growth Design, GrowthExperiments-Homepage
phuedx moved T229805: Homepage: Allow mentors to provide more information about themselves to newcomers from Needs triage to Growth on the Mobile board.
Thu, Aug 15, 11:11 AM · Mobile, Desktop, GrowthExperiments- MentorshipModule, Growth Design, GrowthExperiments-Homepage
phuedx moved T229808: Homepage: Surface mentor answers more prominently in the mentor module from Needs triage to Growth on the Mobile board.
Thu, Aug 15, 11:11 AM · GrowthExperiments- MentorshipModule, GrowthExperiments-Homepage, Desktop, Mobile, Growth Design, Growth-Team
phuedx moved T230014: Homepage: layout and UI fixes from Needs triage to Growth on the Mobile board.
Thu, Aug 15, 11:11 AM · Mobile, Desktop, Growth-Team (Current Sprint), GrowthExperiments-Homepage
phuedx moved T230333: Homepage: number of pageviews in mobile impact preview should be abbreviated from Needs triage to Growth on the Mobile board.
Thu, Aug 15, 11:11 AM · Mobile, GrowthExperiments-Homepage, Growth-Team, GrowthExperiments
phuedx moved T230349: Homepage: module headers in mobile Start module dialog should have no padding from Needs triage to Growth on the Mobile board.
Thu, Aug 15, 11:11 AM · Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
phuedx moved T230350: Homepage: user info text vertical stacking issues in mobile account creation module from Needs triage to Growth on the Mobile board.
Thu, Aug 15, 11:11 AM · Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
phuedx moved T230352: Homepage: account age text styling issues in mobile account creation module from Needs triage to Growth on the Mobile board.
Thu, Aug 15, 11:11 AM · Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
phuedx moved T230355: Homepage: icons alignment issue in mobile Start module dialog from Needs triage to Growth on the Mobile board.
Thu, Aug 15, 11:11 AM · Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
phuedx moved T230360: Homepage: modules padding issues in mobile Start module dialog from Needs triage to Growth on the Mobile board.
Thu, Aug 15, 11:11 AM · Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
phuedx moved T230364: Homepage: light text style tracking issue in mobile homepage module previews from Needs triage to Growth on the Mobile board.
Thu, Aug 15, 11:11 AM · Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
phuedx moved T230365: Homepage: incorrect text style in mobile help module preview from Needs triage to Growth on the Mobile board.
Thu, Aug 15, 11:10 AM · Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
phuedx moved T230368: Homepage: margin issues with light text in mobile Impact module dialog from Needs triage to Growth on the Mobile board.
Thu, Aug 15, 11:10 AM · Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
phuedx moved T230370: Homepage: size issue with mentor's username in mobile mentor module preview and dialog from Needs triage to Growth on the Mobile board.
Thu, Aug 15, 11:10 AM · Patch-For-Review, Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
phuedx moved T230373: Homepage: mentor text style issues in mobile Mentorship module dialog from Needs triage to Growth on the Mobile board.
Thu, Aug 15, 11:10 AM · Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
phuedx moved T230374: Homepage: mentor message text style issue in mobile mentorship module dialog from Needs triage to Growth on the Mobile board.
Thu, Aug 15, 11:10 AM · Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
phuedx moved T230375: Homepage: text style issues in recent questions list of mobile mentor and help module dialogs from Needs triage to Growth on the Mobile board.
Thu, Aug 15, 11:10 AM · Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
phuedx moved T230376: Homepage: vertical alignment issues in mobile Impact module preview from Needs triage to Growth on the Mobile board.
Thu, Aug 15, 11:10 AM · Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
phuedx moved T230377: Homepage: text size issue of pageviews number in Impact module from Needs triage to Growth on the Mobile board.
Thu, Aug 15, 11:10 AM · Desktop, Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage

Wed, Aug 14

phuedx added a comment to T228794: Investigate technical needs for native mobile diffs, including supporting APIs.

Unfortunately, I can find no such API.

Wed, Aug 14, 1:49 PM · Spike, iOS-app-v6.4-Seamonkey-On-A-Hoverboard, Wikipedia-iOS-App-Backlog
phuedx added a comment to T228794: Investigate technical needs for native mobile diffs, including supporting APIs.
  • There is no structured diff data API because of performance reasons. The diffing modules used in production are C++ code that generates HTML directly. Fun times.
Wed, Aug 14, 12:58 PM · Spike, iOS-app-v6.4-Seamonkey-On-A-Hoverboard, Wikipedia-iOS-App-Backlog

Mon, Aug 12

phuedx added a comment to T229875: [Bug] iPadOS 13 shows the desktop version of Safari with a broken layout.

We shouldn't add <meta name="viewport" content="width=device-width, user-scalable=no, initial-scale=1, shrink-to-fit=no"> to Vector. When Monobook did that it annoyed a lot of people and I wouldn't advise it as it seems many users use Vector on their mobile devices exactly because they don't want a responsive layout.

Mon, Aug 12, 1:57 PM · Operations, Traffic, Readers-Web-Backlog
phuedx added a comment to T225213: [SPIKE 8hr] Main Menu should work without javascript.

for non-JS users requires an extra page load.

Remember menu usage is very low (https://grafana.wikimedia.org/d/000000566/overview?panelId=22&fullscreen&orgId=1 logs events for 50% of all page views). Most people don't interact with the main menu. They want to read the article.

Mon, Aug 12, 12:54 PM · Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue
phuedx added a comment to T225213: [SPIKE 8hr] Main Menu should work without javascript.

Firstly, forgive the lateness of my reply and also if I've missed any discussion of this task (or the more general topic) while I've been away.

Mon, Aug 12, 12:37 PM · Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue
phuedx added a comment to T229042: Reading_depth remove eventlogging instrumentation?.

I'm not against disabling the instrumentation for now (but keeping the dataset per T229042#5370440), given the… alarmingly high event rate. To be clear, disabling the instrumentation must include not sending it to the client.

Mon, Aug 12, 9:55 AM · Reading Depth, Readers-Web-Backlog (Needs Product Owner Decisions), Product-Analytics, Analytics

Wed, Aug 7

Jhernandez awarded T217142: [WIP] [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors a Mountain of Wealth token.
Wed, Aug 7, 6:41 PM · observability, User-fgiunchedi, Better Use Of Data, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Patch-For-Review, User-herron, Reading-Infrastructure-Team-Backlog, Wikimedia-Logstash

Mon, Aug 5

phuedx closed T220016: Create, and deploy working MobileWebUIActionsTracking schema as Resolved.

Per T220016#5385166 and T228681#5388069.

Mon, Aug 5, 9:18 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
phuedx updated the task description for T228681: Decommision MobileWebMainMenuClickTracking.
Mon, Aug 5, 9:00 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue
phuedx updated the task description for T228681: Decommision MobileWebMainMenuClickTracking.
Mon, Aug 5, 8:59 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue
phuedx updated the task description for T228681: Decommision MobileWebMainMenuClickTracking.
Mon, Aug 5, 8:58 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue
phuedx moved T228681: Decommision MobileWebMainMenuClickTracking from Ready for Signoff to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

@Jdlrobson's change above will need to be merged, deployed to the Beta Cluster, and deployed to the production servers. Since we're confident that this is effectively a NOOP change (the new instrumentation is working as expected – see T228681#5388069 above), the change can be deployed at any time provided that this is communicated in #wikimedia-operations.

Mon, Aug 5, 8:57 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue

Fri, Aug 2

phuedx added a comment to T229399: [Bug] [AMC] 1px gap at bottom of page actions without download icon (due to font size usage).

@Jdlrobson @phuedx I just checked production in Safari/MacOS and I can't reproduce this issue. Would it make sense to spend our time elsewhere? I feel like we're over investing in a very minor bug.

Fri, Aug 2, 9:57 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions

Thu, Aug 1

phuedx added a comment to T216063: [Bug] Many ReadingDepth validation errors logged.

Correct. Those prefixes must be added by whatever application is proxying our content.

Thu, Aug 1, 4:23 PM · Reading Depth, Readers-Web-Backlog (Tracking), Analytics
phuedx added a comment to T216063: [Bug] Many ReadingDepth validation errors logged.

These failures are expected, though, the spec does not account for such prefixes, it just expects an encoded JSON blob. Is this something the client has no control over somehow? Actually, yeah, how are these URLs even generated?

Thu, Aug 1, 3:17 PM · Reading Depth, Readers-Web-Backlog (Tracking), Analytics

Wed, Jul 31

phuedx added a comment to T225959: [Bug] Overflow menu has blank entry on community portal when no Wikidata item exists.

Note also that the above might fix T229399: [Bug] [AMC] 1px gap at bottom of page actions without download icon (due to font size usage) too.

Wed, Jul 31, 5:28 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
phuedx raised the priority of T229399: [Bug] [AMC] 1px gap at bottom of page actions without download icon (due to font size usage) from Normal to Needs Triage.
Wed, Jul 31, 5:12 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
phuedx updated the task description for T228681: Decommision MobileWebMainMenuClickTracking.
Wed, Jul 31, 5:05 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue
phuedx closed T214540: [EPIC] AMC Navigation - user menu, a subtask of T210655: [EPIC] AMC Navigation, as Resolved.
Wed, Jul 31, 12:36 PM · Epic, Advanced Mobile Contributions, Readers-Web-Backlog
phuedx closed T214540: [EPIC] AMC Navigation - user menu, a subtask of T228916: Deploy AMC to all Wikipedias, as Resolved.
Wed, Jul 31, 12:36 PM · User-notice, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
phuedx closed T214540: [EPIC] AMC Navigation - user menu as Resolved.

This looks great to me 💪 Excellent work everyone!

Wed, Jul 31, 12:36 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions
phuedx triaged T229399: [Bug] [AMC] 1px gap at bottom of page actions without download icon (due to font size usage) as Normal priority.
Wed, Jul 31, 11:41 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
phuedx added a comment to T214540: [EPIC] AMC Navigation - user menu.

As you suggest, I agree it'd be a great idea to persist that styling while the menu is open, cc @Jdrewniak. I will create a task for that.

Wed, Jul 31, 11:10 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions
phuedx updated the task description for T214540: [EPIC] AMC Navigation - user menu.
Wed, Jul 31, 10:59 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions
phuedx closed T228278: Edits lost when writing replies on talk page before leaving the page as Resolved.

LGTM 💪 I tested this on the BC as did @Edtadros in T228278#5378507. The patch will be deployed to group0 wikis tomorrow.

Wed, Jul 31, 10:43 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue
phuedx closed T228235: Edits lost when clicking back from talk overlay as Resolved.

LGTM 💪

Wed, Jul 31, 10:20 AM · Advanced Mobile Contributions, MobileFrontend, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)

Tue, Jul 30

phuedx moved T201131: Bug: Order of some paragraphs is flipped on mobile from Ready for Signoff to Blocked on Others on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

The changes and the QA LGTM and I'd be happy to sign this off. However, the changes will be deployed to enwiki this Thursday so I'm inclined to wait and double-check the page in production.

Tue, Jul 30, 6:50 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend
phuedx placed T220016: Create, and deploy working MobileWebUIActionsTracking schema up for grabs.
Tue, Jul 30, 6:42 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
phuedx moved T220016: Create, and deploy working MobileWebUIActionsTracking schema from Ready for Signoff to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Per T220016#5377322. Alternatively, I'm happy to sign this off and create an "enable the instrumentation" task.

Tue, Jul 30, 6:42 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
phuedx added a comment to T220016: Create, and deploy working MobileWebUIActionsTracking schema.

I clarified with @pmiazga that it's expected that we're not sending seen events for UI elements yet. That is, we're tracking UI element interactions as we were before.

Tue, Jul 30, 5:22 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
phuedx claimed T228235: Edits lost when clicking back from talk overlay.
Tue, Jul 30, 8:59 AM · Advanced Mobile Contributions, MobileFrontend, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
phuedx claimed T220016: Create, and deploy working MobileWebUIActionsTracking schema.
Tue, Jul 30, 8:59 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions

Jul 4 2019

phuedx added a comment to T227073: Inventory MobileFrontend/MinervaNeue browser tests.

@Edtadros has started working on this here (viewable by those with a @wikimedia.org email address).

Jul 4 2019, 4:12 PM · Readers-Web-Backlog, MinervaNeue, MobileFrontend
phuedx moved T209410: sameAs schema doesn't report dateModified if article has only one edit from Needs Prioritization to Triaged but Future on the Readers-Web-Backlog board.
Jul 4 2019, 4:08 PM · Readers-Web-Backlog, SEO, Wikidata
phuedx added a comment to T209410: sameAs schema doesn't report dateModified if article has only one edit.

I did some digging on this task during today's chores. Here's what I think I know:

Jul 4 2019, 4:06 PM · Readers-Web-Backlog, SEO, Wikidata
phuedx added a comment to T216063: [Bug] Many ReadingDepth validation errors logged.

In the last 24 hour period, 11 more ReadingDepth events with odd URLs have caused processing errors. See https://logstash.wikimedia.org/goto/dbe9713837e22a6d5a0d64f09fae1ec2. For these events, the QSON is terminated as we expect but it's prefixed with either iorg_domain_internal=... or operator_user=....

Jul 4 2019, 3:14 PM · Reading Depth, Readers-Web-Backlog (Tracking), Analytics

Jul 2 2019

phuedx added a comment to T226164: Invalid MobileWebSearch events being logged.

Noise in EventLogging should be considered a high priority to fix as it creates problems for all people working with our infrastructure, so I suggest we fix this sooner rather than later.

Jul 2 2019, 5:22 PM · MinervaNeue (Desktop), Readers-Web-Backlog, Mobile, MobileFrontend
phuedx added a comment to T226490: Minerva Discussion tab do not respect MinervaPageActions config flag.

In today's grooming ritual, we wondered aloud whether the MinervaPageActions config is actually needed – it was but is it still?

Jul 2 2019, 4:57 PM · Advanced Mobile Contributions, MinervaNeue, Readers-Web-Backlog
phuedx created T227073: Inventory MobileFrontend/MinervaNeue browser tests.
Jul 2 2019, 10:08 AM · Readers-Web-Backlog, MinervaNeue, MobileFrontend
phuedx added a comment to T221695: [Bug] Infobox in "Iraq war" article on enwiki not full width on mobile-html.

@phuedx @JoeWalsh it would be great if we could determine some kind of process for making these change requests with support from community liasons to get them to the correct people.

Jul 2 2019, 8:45 AM · Readers-Web-Backlog (Tracking), MinervaNeue, Page Content Service, Reading-Infrastructure-Team-Backlog

Jul 1 2019

phuedx added a comment to T217142: [WIP] [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors.
  • tags (which contain lots of useful information such as MediaWiki version, language, skin...) are handled extremely poorly by kibana in their current format. They should be converted into top-level properties (preferably with field names matching those in PHP errors so that Kibana visualisations / saved searches can be reused). Not sure what's the right place for that: client, EventGate, logstash filter? (The last one has its own domain language so it would be the most painful to maintain.)
Jul 1 2019, 2:50 PM · observability, User-fgiunchedi, Better Use Of Data, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Patch-For-Review, User-herron, Reading-Infrastructure-Team-Backlog, Wikimedia-Logstash

Jun 27 2019

phuedx added a comment to T225877: Two link rel="canonical" if $wgEnableCanonicalServerLink and $mfNoIndexPages is true.

Following on from @DIKW_Pyramid's comment above:

Jun 27 2019, 11:51 AM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend

Jun 25 2019

phuedx updated the task description for T226490: Minerva Discussion tab do not respect MinervaPageActions config flag.
Jun 25 2019, 2:02 PM · Advanced Mobile Contributions, MinervaNeue, Readers-Web-Backlog
pmiazga awarded T217142: [WIP] [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors a Love token.
Jun 25 2019, 11:51 AM · observability, User-fgiunchedi, Better Use Of Data, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Patch-For-Review, User-herron, Reading-Infrastructure-Team-Backlog, Wikimedia-Logstash

Jun 20 2019

phuedx triaged T226143: Minerva: Add support for SkinAfterContent hook as Normal priority.
Jun 20 2019, 10:09 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, MinervaNeue
phuedx moved T224379: mobile app is killing tabs to force article of the day from Needs triage to Apps on the Mobile board.
Jun 20 2019, 10:06 AM · Mobile
phuedx moved T226106: Three clicks required to exit talk overlay from Needs triage to MinervaNeue on the Mobile board.
Jun 20 2019, 10:06 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, MinervaNeue, Mobile
phuedx moved T225180: Sharing a text from Wikipedia App into Twitter gives @Wikipedia handle, which shouldn't from Needs triage to Apps on the Mobile board.
Jun 20 2019, 10:05 AM · Android-app-feature-mobile-html, Mobile
phuedx moved T226009: add link to Wikidata on Wikipedia mobile view from Needs triage to Triaged on the Mobile board.
Jun 20 2019, 10:04 AM · Readers-Web-Backlog (Tracking), Advanced Mobile Contributions, MobileFrontend, Mobile, Wikidata
phuedx moved T226146: Homepage: minor mobile instrumentation issues from Needs triage to Triaged on the Mobile board.
Jun 20 2019, 10:03 AM · GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
phuedx moved T226147: Homepage: impact clock icon issues on mobile from Needs triage to Triaged on the Mobile board.
Jun 20 2019, 10:03 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Mobile, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
phuedx moved T226112: Homepage: mobile homepage and user page auto scroll down (on iOS Safari 10 and iOS Chrome 60.0.3112.89) from Needs triage to Triaged on the Mobile board.
Jun 20 2019, 10:02 AM · Mobile, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
phuedx moved T225499: Fix Special:RecentChanges dropdown widget on mobile from Triaged to MinervaNeue on the Mobile board.
Jun 20 2019, 10:02 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), OOUI, Mobile, Advanced Mobile Contributions
phuedx moved T225499: Fix Special:RecentChanges dropdown widget on mobile from Needs triage to Triaged on the Mobile board.
Jun 20 2019, 10:00 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), OOUI, Mobile, Advanced Mobile Contributions
phuedx moved T226041: Homepage and help panel: ask question dialog should be aware of back button from Needs triage to Triaged on the Mobile board.
Jun 20 2019, 10:00 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage, GrowthExperiments-Help panel
phuedx edited projects for T226164: Invalid MobileWebSearch events being logged, added: Mobile; removed Analytics-EventLogging, Analytics.
Jun 20 2019, 9:54 AM · MinervaNeue (Desktop), Readers-Web-Backlog, Mobile, MobileFrontend
Restricted Application added a project to T226164: Invalid MobileWebSearch events being logged: Analytics.
Jun 20 2019, 9:54 AM · MinervaNeue (Desktop), Readers-Web-Backlog, Mobile, MobileFrontend

Jun 19 2019

phuedx added a comment to T220558: ImageGateway should utilize browser cache when calling MediaWIki API.

Can we use MediaWiki API caching instead and drop the cache?

Jun 19 2019, 4:44 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Tracking), Technical-Debt
phuedx updated the task description for T220558: ImageGateway should utilize browser cache when calling MediaWIki API.
Jun 19 2019, 4:33 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Tracking), Technical-Debt

Jun 18 2019

phuedx added a comment to T225213: [SPIKE 8hr] Main Menu should work without javascript.

Could we also consider moving the Wikimedia-specific instrumentation for the main menu into the WikimediaEvents extension?

Jun 18 2019, 4:49 PM · Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue
phuedx added a comment to T225213: [SPIKE 8hr] Main Menu should work without javascript.

As I mentioned in today's grooming, there's a whole bunch of (now overly-complicated) machinery that we created in order to defer the parsing/DOM construction for the main menu as it's the very top element in #mw-mf-viewport. I think that reevaluating this machinery is well worth it!

Jun 18 2019, 4:45 PM · Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue
phuedx awarded T225213: [SPIKE 8hr] Main Menu should work without javascript a Like token.
Jun 18 2019, 4:35 PM · Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue
phuedx awarded T225946: [SPIKE 8hrs] Determine Appropriate Action for Mobile Frontend lazy-loading images performance issues a Mountain of Wealth token.
Jun 18 2019, 8:43 AM · Readers-Web-Backlog (Tracking), Performance-Team (Radar), MobileFrontend

Jun 11 2019

phuedx added a comment to T218206: AMC Navigation - make main menu scrollable.

I think this could be as simple as adding the following rules:

Jun 11 2019, 4:48 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
phuedx added a comment to T223363: Cleanup Special:RecentChanges filters appearance on Minerva (mobile).

Is the level of specificity of some of the example CSS rules required, e.g. .mw-rcfilters-ui-filterTagMultiselectWidget-views-select-widget.oo-ui-widget.oo-ui-widget-enabled.oo-ui-selectWidget.oo-ui-selectWidget-unpressed.oo-ui-selectWidget-depressed.oo-ui-buttonSelectWidget ?

Jun 11 2019, 4:36 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions, Growth-Team, Mobile, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page

Jun 7 2019

phuedx updated the task description for T225260: BUG: Notifications tray (mobile) - margins and borders.
Jun 7 2019, 7:33 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Mobile
phuedx triaged T225260: BUG: Notifications tray (mobile) - margins and borders as Normal priority.

… gIven that the bugs are minor.

Jun 7 2019, 7:28 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Mobile
phuedx moved T225260: BUG: Notifications tray (mobile) - margins and borders from Triaged to MobileFrontend specific on the Mobile board.
Jun 7 2019, 7:27 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Mobile
phuedx moved T225260: BUG: Notifications tray (mobile) - margins and borders from Needs triage to Triaged on the Mobile board.
Jun 7 2019, 7:27 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Mobile
phuedx updated the task description for T225260: BUG: Notifications tray (mobile) - margins and borders.
Jun 7 2019, 7:26 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Mobile