phuedx (Sam Smith)
Engineering Manager, Readers

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Nov 14 2014, 10:42 AM (209 w, 4 d)
Availability
Available
IRC Nick
phuedx
LDAP User
Unknown
MediaWiki User
Phuedx (WMF) [ Global Accounts ]

Recent Activity

Yesterday

phuedx added a comment to T208755: Launch A/B test for sameAs property.

Thank you @Niedzielski and @pmiazga for all your hard work here.

Tue, Nov 20, 3:53 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), SEO

Mon, Nov 19

phuedx added a comment to T181195: Add a share button to the mobile site (starting by enabling in beta).
  1. Part of me is wondering if there's somewhere other than the toolbar to put this button — it seems like the obvious place, but also for some reason I can't quite identify yet it feels out of place. If we do keep it in the toolbar I think it might be worth evenly distributing the icons horizontally.
Mon, Nov 19, 2:41 PM · Readers-Web-Backlog (Design), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26))
phuedx added a comment to T209708: Research Design Improvements to MobileFrontend Loading Overlay.
  1. Designers review and see if the new treatments make sense for all use cases
Mon, Nov 19, 2:33 PM · Readers-Web-Backlog (Design), Design, VisualEditor
phuedx moved T209765: PHPUnit: Cover NULL cases for getPluralLicenseInfo() in MobileFrontendSkinHooks class from Ready for Signoff to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Mon, Nov 19, 2:26 PM · Readers-Web-Backlog, User-D3r1ck01, MobileFrontend
phuedx added a comment to T209765: PHPUnit: Cover NULL cases for getPluralLicenseInfo() in MobileFrontendSkinHooks class.

Code coverage has gone up

Mon, Nov 19, 2:25 PM · Readers-Web-Backlog, User-D3r1ck01, MobileFrontend
phuedx closed T208185: Outputting '<sup>β</sup>` on every page, not only on beta, as part of the logo is disadvantageous as Resolved.

Being bold.

Mon, Nov 19, 2:19 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), goodfirstbug, Google-Code-in-2018, SEO, MinervaNeue

Fri, Nov 16

phuedx added a comment to T205437: Resurrect eventlogging_EventError logging to in logstash.

I'd actually be interested in picking this up as a 10% project to better understand our logging infrastructure and deployment of the various EL services. If that'd slow things down a little too much, then I understand – I'd rather see this resolved 🙂

Fri, Nov 16, 1:26 PM · Analytics, Analytics-EventLogging

Thu, Nov 15

phuedx closed T208987: PHPUnit: Cover all model/MobileCollection class methods as Resolved.
+-----------------------------+-------+--------+
| Filename                    | Old % | New %  |
+-----------------------------+-------+--------+
| models/MobileCollection.php | 0     | 100.00 |
+-----------------------------+-------+--------+
Thu, Nov 15, 5:30 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, User-D3r1ck01, MobileFrontend
phuedx closed T208987: PHPUnit: Cover all model/MobileCollection class methods, a subtask of T208761: [Epic] Improve PHPUnit coverage in MobileFrontend to medium, as Resolved.
Thu, Nov 15, 5:30 PM · User-D3r1ck01, Readers-Web-Backlog, Epic, MobileFrontend
phuedx placed T208185: Outputting '<sup>β</sup>` on every page, not only on beta, as part of the logo is disadvantageous up for grabs.
Thu, Nov 15, 3:45 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), goodfirstbug, Google-Code-in-2018, SEO, MinervaNeue
phuedx updated the task description for T208185: Outputting '<sup>β</sup>` on every page, not only on beta, as part of the logo is disadvantageous.
Thu, Nov 15, 3:44 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), goodfirstbug, Google-Code-in-2018, SEO, MinervaNeue
phuedx added a comment to T208185: Outputting '<sup>β</sup>` on every page, not only on beta, as part of the logo is disadvantageous.

includes/skins/MinervaTemplate.php should not be directly accessing MobileContext

Thu, Nov 15, 3:42 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), goodfirstbug, Google-Code-in-2018, SEO, MinervaNeue
phuedx updated the task description for T208185: Outputting '<sup>β</sup>` on every page, not only on beta, as part of the logo is disadvantageous.
Thu, Nov 15, 3:41 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), goodfirstbug, Google-Code-in-2018, SEO, MinervaNeue
phuedx claimed T208185: Outputting '<sup>β</sup>` on every page, not only on beta, as part of the logo is disadvantageous.
Thu, Nov 15, 3:39 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), goodfirstbug, Google-Code-in-2018, SEO, MinervaNeue
phuedx added a comment to T208755: Launch A/B test for sameAs property.

☝️ The task description was slightly out of date and was bold.

Thu, Nov 15, 1:21 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), SEO
phuedx updated the task description for T208755: Launch A/B test for sameAs property.
Thu, Nov 15, 1:18 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), SEO
phuedx updated the task description for T208755: Launch A/B test for sameAs property.
Thu, Nov 15, 1:12 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), SEO

Wed, Nov 14

phuedx added a comment to T99009: Remove noimages transform (was inconsistent parameter names for action=mobileview when you compare with action=parse).

AFAICT there's one client that still uses passes a noimages parameter to the parse API: https://github.com/wikimedia/labs-tools-wikidipendenza

Wed, Nov 14, 4:41 PM · Technical-Debt, Readers-Web-Backlog (Tracking), Patch-For-Review, Mobile-Apps, MobileFrontend, MediaWiki-API
phuedx added a comment to T180224: Port GettingStarted Selenium tests from Ruby to Node.js.

The browser tests have been failing for over three weeks now. Unfortunately, I don't have much free time to port them right now. Unless someone does, then we should disable them /cc @zeljkofilipin

Wed, Nov 14, 1:45 PM · Growth-Team, Patch-For-Review, MediaWiki-extensions-GettingStarted
phuedx assigned T209352: [Spike 2hrs] BetaCluster incorrectly points SameAS to production Wikidata to Niedzielski.

Reflecting reality.

Wed, Nov 14, 12:23 PM · Patch-For-Review, Wikidata, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), SEO
phuedx updated subscribers of T208909: [Bug] Update old nonuniformly distributed page_random values.

As promised, here are the notes that I took whilst running the resetPageRandom.php script on 12th November:

Wed, Nov 14, 9:57 AM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), DBA, MediaWiki-General-or-Unknown
phuedx created P7803 T208909 - Wikis by number of affected rows.
Wed, Nov 14, 9:51 AM
phuedx reassigned T208755: Launch A/B test for sameAs property from phuedx to pmiazga.

Per the task description (@pmiazga is deploying the first change in the chain and I will be available for QA).

Wed, Nov 14, 9:33 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), SEO

Tue, Nov 13

phuedx added a comment to T209314: Popups: Upgrade Popups dependencies .

I estimated a 5 because:

Tue, Nov 13, 6:03 PM · Readers-Web-Backlog, Page-Previews
phuedx added a comment to T204866: MFA: Deprecate mobile.startup/user.

Centralising the definition for edit count buckets has obvious advantages. Both QuickSurveys and Popups would benefit:

Tue, Nov 13, 5:53 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Technical-Debt, MobileFrontend (MobileFrontend.js)
phuedx updated the task description for T209185: Add test coverage for rlModuleLoader.js.
Tue, Nov 13, 5:36 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend.js)
phuedx added a comment to T208755: Launch A/B test for sameAs property.

I8345d95a774531ff62bda4a8766f848a847921ee has been deployed: https://en.wikipedia.org/w/index.php?title=Special%3AAllMessages&prefix=wikibase-page-schema&filter=all&lang=en&limit=50

Tue, Nov 13, 12:56 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), SEO
phuedx updated the task description for T208755: Launch A/B test for sameAs property.
Tue, Nov 13, 12:52 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), SEO
phuedx updated the task description for T208755: Launch A/B test for sameAs property.
Tue, Nov 13, 11:31 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), SEO

Mon, Nov 12

phuedx added a comment to T208909: [Bug] Update old nonuniformly distributed page_random values.

… and now against all large wikis.

Mon, Nov 12, 4:18 PM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), DBA, MediaWiki-General-or-Unknown
phuedx added a comment to T208909: [Bug] Update old nonuniformly distributed page_random values.

… and now against all medium wikis.

Mon, Nov 12, 3:17 PM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), DBA, MediaWiki-General-or-Unknown
phuedx added a comment to T208909: [Bug] Update old nonuniformly distributed page_random values.

The script is currently running against all small wikis.

Mon, Nov 12, 2:05 PM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), DBA, MediaWiki-General-or-Unknown
phuedx claimed T208909: [Bug] Update old nonuniformly distributed page_random values.
Mon, Nov 12, 1:23 PM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), DBA, MediaWiki-General-or-Unknown
phuedx moved T208909: [Bug] Update old nonuniformly distributed page_random values from Blocked on Others to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Mon, Nov 12, 1:23 PM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), DBA, MediaWiki-General-or-Unknown

Thu, Nov 8

phuedx placed T206406: Main Page on a wiki doesn't have a Discussion page / Talk page on Mobile View up for grabs.
Thu, Nov 8, 6:05 PM · User-Ryasmeen, Audiences-QA, MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, User-D3r1ck01, MobileFrontend
phuedx closed T208997: [Bug] selenium-daily-beta-Popups Jenkins job failing acquiring DISPLAY port 94 as Resolved.

The build has since passed. I'm going to be bold and resolve this as it looks like an intermittent infrastructure problem.

Thu, Nov 8, 12:33 PM · Release-Engineering-Team, Page-Previews, Readers-Web-Backlog
phuedx triaged T208915: MobileFrontend modules: Cleanup some deprecation calls as Normal priority.

Is it fair to say that this work is blocked on the rest of the refactoring work (or, at least, should be scheduled at the end of it?).

Thu, Nov 8, 11:49 AM · MobileFrontend (MobileFrontend.js), Readers-Web-Backlog

Wed, Nov 7

phuedx added a project to T208909: [Bug] Update old nonuniformly distributed page_random values: DBA.
Wed, Nov 7, 6:43 PM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), DBA, MediaWiki-General-or-Unknown
phuedx added a comment to T208980: [Bug] The statsv client should send a request when the page unloads.

@Krinkle: Please feel free to correct me where I'm wrong/add more detail about this 🙂 If there are any sources for the browser/JavaScript VM behaviour differences between desktop and mobile devices, that'd be great!

Wed, Nov 7, 6:42 PM · MediaWiki-extensions-WikimediaEvents
phuedx updated the task description for T208980: [Bug] The statsv client should send a request when the page unloads.
Wed, Nov 7, 6:42 PM · MediaWiki-extensions-WikimediaEvents
phuedx created T208980: [Bug] The statsv client should send a request when the page unloads.
Wed, Nov 7, 6:34 PM · MediaWiki-extensions-WikimediaEvents
phuedx added a comment to T208763: Enable page schemas on the beta cluster.

I also confirmed that no new entries were logged to Logstash using the X-Wikimedia-Debug tool.

Wed, Nov 7, 2:39 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), SEO
phuedx added a comment to T208763: Enable page schemas on the beta cluster.

I can also confirm that I don't see the above type of output on the bottom of all articles with linked Wikidata items (again, on the Beta Cluster).

Wed, Nov 7, 12:43 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), SEO
phuedx added a comment to T208763: Enable page schemas on the beta cluster.

This took a little while to test! However, after linking Q390678 to the Foooooo article on the Beta Cluster I see the following at the bottom of that article:

Wed, Nov 7, 12:42 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), SEO
phuedx moved T208763: Enable page schemas on the beta cluster from Ready for Signoff to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Wed, Nov 7, 12:09 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), SEO
phuedx moved T208763: Enable page schemas on the beta cluster from Needs More Work to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Wed, Nov 7, 12:08 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), SEO
phuedx claimed T208763: Enable page schemas on the beta cluster.
Wed, Nov 7, 12:07 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), SEO
phuedx added a comment to T208763: Enable page schemas on the beta cluster.

I've rescheduled the change to be deployed in the European Mid-day SWAT window.

Wed, Nov 7, 11:48 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), SEO
phuedx added a comment to T208763: Enable page schemas on the beta cluster.

I've scheduled rOMWC61479ef8e135: BC: Enable Schema.org page split test for deployment during the Morning SWAT window as I might not be available for the entirety of the European Mid-day SWAT window.

Wed, Nov 7, 11:04 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), SEO
phuedx closed T208469: Spike in PHP warnings from User.php; triggered from MobileFrontend's new use of ContribsPager with a User object instead of a string as Resolved.

Per T208469#4713958.

Wed, Nov 7, 9:21 AM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend, Wikimedia-production-error
phuedx closed T208469: Spike in PHP warnings from User.php; triggered from MobileFrontend's new use of ContribsPager with a User object instead of a string, a subtask of T199066: PHP error "Revision::ensureTitle: Could not determine title for page " in SpecialMobileContributions, as Resolved.
Wed, Nov 7, 9:21 AM · User-Ryasmeen, Audiences-QA, MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), MobileFrontend (MobileFrontend Special Pages), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Growth-Team, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Technical-Debt (RW-Tech-Debt), Wikimedia-production-error, MediaWiki-Special-pages

Tue, Nov 6

phuedx added a comment to T208763: Enable page schemas on the beta cluster.

Please review ☝️, especially for precision of language.

Tue, Nov 6, 12:46 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), SEO
phuedx added a comment to T208763: Enable page schemas on the beta cluster.
  • A SWAT will be needed to turn it on. Given this is a beta cluster only change, if you find a willing deployer, you can do it outside the normal SWAT windows.
Tue, Nov 6, 11:51 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), SEO
phuedx updated the task description for T208763: Enable page schemas on the beta cluster.
Tue, Nov 6, 11:45 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), SEO
phuedx added a comment to T185206: RelatedSites: Code stewardship review.

Outstanding work, y'all.

Tue, Nov 6, 11:38 AM · Community-Tech, MediaWiki-extensions-RelatedSites, Code-Stewardship-Reviews
phuedx updated the task description for T200793: Disable page issues A/B test.
Tue, Nov 6, 11:02 AM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2)
phuedx added a comment to T207670: Popups schema is keeping page/session id longer than 90 days.

Thanks for flagging this. I will check with @ovasileva about which of the two are more important from a product perspective, but I guess we will want to drop the page titles and keep the session-related data. (CC @phuedx )

discussed this with @Tbayer and we decided to keep session id and stop collecting page id

Tue, Nov 6, 11:01 AM · Product-Analytics, Readers-Web-Backlog, Analytics
phuedx closed T200793: Disable page issues A/B test as Resolved.

👍

Tue, Nov 6, 10:52 AM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2)
phuedx closed T200793: Disable page issues A/B test, a subtask of T159262: [EPIC] Improve page issues, as Resolved.
Tue, Nov 6, 10:52 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Readers-Web-Kanbanana-Board-Old, Page-Issue-Warnings, Epic, Design
phuedx closed T200793: Disable page issues A/B test, a subtask of T200794: Analyze results of page issues A/B test, as Resolved.
Tue, Nov 6, 10:52 AM · Readers-Web-Backlog (Tracking), Product-Analytics, Reading-analysis

Mon, Nov 5

phuedx added a comment to T208606: Bucket WebClientError's by browser domain and domain.

Should we revisit using EventLogging to record limit details of errors and getting them ingested into Turnilo?

Mon, Nov 5, 2:55 PM · Readers-Web-Backlog
phuedx added a comment to T201068: Modern Event Platform: Stream Intake Service.

As an engineer, I want to batch produce many events at once so mobile apps can produce events after an offline period.

Do you think you'll need to be able to batch produce (in a single HTTP request) events of different schemas and/or events that are destined to different streams (AKA Kafka topics?). E.g. would you need to produce something like POST [{user login event}, {user search event}, {user read event}, {user pref change event}]?

Mon, Nov 5, 12:29 PM · Services (watching), Analytics-EventLogging, EventBus, Analytics-Kanban
phuedx added a comment to T180224: Port GettingStarted Selenium tests from Ruby to Node.js.

The browser tests have been failing for some time with the following error:

Mon, Nov 5, 10:33 AM · Growth-Team, Patch-For-Review, MediaWiki-extensions-GettingStarted
phuedx added a comment to T205569: Define cross-schema event stitching approach.

@phuedx do you think it might be sensible to simply make sendBeacon a pre-requisite at this point for client side event logging?

Mon, Nov 5, 9:26 AM · Reading-Admin

Fri, Nov 2

phuedx added a comment to T206072: Wikimedia Technical Conference 2018 Session - Determining use cases and requirements for the APIs that we build.

☝️ I forgot to upload this image on the day.

Fri, Nov 2, 10:24 AM · Wikimedia-Technical-Conference-2018
phuedx added a comment to T207670: Popups schema is keeping page/session id longer than 90 days.

Thanks for flagging this. I will check with @ovasileva about which of the two are more important from a product perspective, but I guess we will want to drop the page titles and keep the session-related data. (CC @phuedx )

Fri, Nov 2, 10:21 AM · Product-Analytics, Readers-Web-Backlog, Analytics
phuedx added a comment to T199066: PHP error "Revision::ensureTitle: Could not determine title for page " in SpecialMobileContributions.

AIUI this task led to T208469: Spike in PHP warnings from User.php; triggered from MobileFrontend's new use of ContribsPager with a User object instead of a string, which was blocking the rollout of the -wmf.2 branch.

Fri, Nov 2, 9:57 AM · User-Ryasmeen, Audiences-QA, MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), MobileFrontend (MobileFrontend Special Pages), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Growth-Team, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Technical-Debt (RW-Tech-Debt), Wikimedia-production-error, MediaWiki-Special-pages
phuedx added a subtask for T199066: PHP error "Revision::ensureTitle: Could not determine title for page " in SpecialMobileContributions: T208469: Spike in PHP warnings from User.php; triggered from MobileFrontend's new use of ContribsPager with a User object instead of a string.
Fri, Nov 2, 9:56 AM · User-Ryasmeen, Audiences-QA, MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), MobileFrontend (MobileFrontend Special Pages), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Growth-Team, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Technical-Debt (RW-Tech-Debt), Wikimedia-production-error, MediaWiki-Special-pages
phuedx added a parent task for T208469: Spike in PHP warnings from User.php; triggered from MobileFrontend's new use of ContribsPager with a User object instead of a string: T199066: PHP error "Revision::ensureTitle: Could not determine title for page " in SpecialMobileContributions.
Fri, Nov 2, 9:55 AM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend, Wikimedia-production-error
phuedx added a comment to T208469: Spike in PHP warnings from User.php; triggered from MobileFrontend's new use of ContribsPager with a User object instead of a string.

I'm not sure what there's left to review here. If the errors have disappeared from logstash, then this task can be resolved, right?

Fri, Nov 2, 9:51 AM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend, Wikimedia-production-error

Thu, Nov 1

phuedx added a comment to T204055: Consistently represent asynchronous code execution.

Per the latest review for rMSCRd3812f53fc5e: Rewrite Queue to promise-way flow.

Thu, Nov 1, 5:54 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Services (watching), Technical-Debt, Proton
phuedx moved T204055: Consistently represent asynchronous code execution from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Thu, Nov 1, 5:52 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Services (watching), Technical-Debt, Proton
phuedx claimed T208469: Spike in PHP warnings from User.php; triggered from MobileFrontend's new use of ContribsPager with a User object instead of a string.
Thu, Nov 1, 5:08 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend, Wikimedia-production-error

Sun, Oct 28

phuedx added a comment to T207280: Track share button usage.

Could the page view API be used for checking links back?

Sun, Oct 28, 8:12 PM · Readers-Web-Backlog, MinervaNeue

Oct 19 2018

phuedx added a comment to T206702: Enable client side error counting on Minerva production (wikipedia only).

… and how's Graphite coping?

Oct 19 2018, 8:09 AM · Readers-Web-Backlog, Patch-For-Review, Wikimedia-Site-requests

Oct 18 2018

phuedx added a comment to T207280: Track share button usage.

I think that a better way is to track it on the backend by using ?share_link, but I'm afraid there might be some performance impact (requests not hitting cache).
Are there any performance issues related to adding a parameter to the URL and tracking it on the backend?

Oct 18 2018, 6:42 AM · Readers-Web-Backlog, MinervaNeue
phuedx added a comment to T207280: Track share button usage.

Tracking republication of Wikimedia content came up on analytics@ recently: https://lists.wikimedia.org/pipermail/analytics/2018-October/006460.html. Obviously, sharing content is different but the conversation seems relevant.

Oct 18 2018, 6:01 AM · Readers-Web-Backlog, MinervaNeue

Oct 17 2018

phuedx added a comment to T206702: Enable client side error counting on Minerva production (wikipedia only).
  • not all browsers support onbeforeunload
Oct 17 2018, 7:37 PM · Readers-Web-Backlog, Patch-For-Review, Wikimedia-Site-requests
phuedx added a comment to T206702: Enable client side error counting on Minerva production (wikipedia only).

I have a couple of concerns with this change that I spoke about with @pmiazga but wanted to raise here too:

Oct 17 2018, 4:05 PM · Readers-Web-Backlog, Patch-For-Review, Wikimedia-Site-requests

Oct 16 2018

phuedx added a comment to T205569: Define cross-schema event stitching approach.

(BTW, not sure if you've seen T205319: Modern Event Platform: Stream Configuration Service, but I think the use cases there overlap. We won't be working on that task for a while, but we do want to do it.)

  1. Default: It just works. The value of mw.user.sessionId() is sent in the event.
  2. Not using session sampling: set optional boolean of isSessionSampled = false. The value of mw.user.sessionId() is not sent in the event.

Could we invert this? I think it would be better to not collect the sessionId unless the event designer explicitly wants it.

Oct 16 2018, 3:12 PM · Reading-Admin

Oct 15 2018

phuedx added a comment to T206959: It should be possible to see the number of server-side validation errors for a schema in Grafana.

I was thinking people just set debug to true and left that on while debugging EL code locally. Is that not true?

Oct 15 2018, 7:10 PM · Analytics-EventLogging, Analytics
phuedx awarded T205437: Resurrect eventlogging_EventError logging to in logstash a Like token.
Oct 15 2018, 3:02 PM · Analytics, Analytics-EventLogging

Oct 14 2018

phuedx created T206959: It should be possible to see the number of server-side validation errors for a schema in Grafana.
Oct 14 2018, 7:42 PM · Analytics-EventLogging, Analytics

Oct 12 2018

phuedx added a comment to T206647: Prepare selenium browser test for page issues A/B test.

@phuedx, @ovasileva this would be a good task to pair with @Ryasmeen on

Oct 12 2018, 11:17 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Page-Issue-Warnings
phuedx added a comment to T111472: QA: No browser tests covering QuickSurveys in mobile skin.

Rather than pinging y'all on separate tasks, I'll send an email!

Oct 12 2018, 11:14 AM · Readers-Web-Backlog (Tracking), QuickSurveys
phuedx updated subscribers of T111472: QA: No browser tests covering QuickSurveys in mobile skin.

@Jdlrobson, @Jdrewniak: Is this task a good task for @Ryasmeen to pick up?

Oct 12 2018, 11:13 AM · Readers-Web-Backlog (Tracking), QuickSurveys
phuedx closed T206776: Stability issues with beta cluster caused selenium-QuickSurveys to fail as Resolved.
[W76xwgpEEZ8AACAA9jYAAAAJ] Exception caught: Cannot read both schemas (internal_api_error_InvalidArgumentException) (MediawikiApi::ApiError)

suggests this was a issue with beta cluster stability.

Oct 12 2018, 10:07 AM · Continuous-Integration-Infrastructure, Beta-Cluster-Infrastructure, Readers-Web-Backlog (Tracking), QuickSurveys

Oct 11 2018

phuedx moved T204143: ReadingDepth events are not being sent in browsers where navigator.sendBeacon should be supported but in practice isn't from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

Per T204143#4652491.

Oct 11 2018, 5:05 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Product-Analytics, Reading-analysis
phuedx edited projects for T204143: ReadingDepth events are not being sent in browsers where navigator.sendBeacon should be supported but in practice isn't, added: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Readers-Web-Backlog.
Oct 11 2018, 5:04 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Product-Analytics, Reading-analysis
phuedx added a comment to T206640: selenium-daily-beta-Popups CI job failing.

There were 5 builds triggered on 2018/10/10, of which 2 failed. The build has passed consistently for the last 4 builds.

Oct 11 2018, 4:56 PM · User-zeljkofilipin, Release-Engineering-Team (Kanban), Continuous-Integration-Infrastructure, Readers-Web-Backlog (Tracking), Page-Previews
phuedx created T206776: Stability issues with beta cluster caused selenium-QuickSurveys to fail.
Oct 11 2018, 4:52 PM · Continuous-Integration-Infrastructure, Beta-Cluster-Infrastructure, Readers-Web-Backlog (Tracking), QuickSurveys

Oct 10 2018

phuedx added a comment to T204143: ReadingDepth events are not being sent in browsers where navigator.sendBeacon should be supported but in practice isn't.

I apologise for the non-sequitur but I mentioned that I'd follow up with the latest ReadingDepth and PageIssues server-side error rates so that the conversation was all happening in one place.

Oct 10 2018, 4:37 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Product-Analytics, Reading-analysis
phuedx awarded Blog Post: Best friends forever a Mountain of Wealth token.
Oct 10 2018, 4:13 PM · Performance-Team

Oct 9 2018

phuedx added a comment to T198946: Add Schema property 'sameAs' pointing to Wikidata entries.

As I mentioned during today's standup ritual, there's an additional component that should be taken into account when deciding how to implement this: we'd like this change to be live before the December code freeze.

Oct 9 2018, 12:14 PM · Performance-Team (Radar), MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Wikidata-Campsite, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MediaWiki-extensions-WikibaseClient, Wikidata, SEO
phuedx added a comment to T206496: Create sitemaps for Indonesian, Portuguese, Punjabi, Dutch, and Korean Wikipedias.

Our results were inconclusive yet pointing towards sitemaps having no effect on search traffic.

Oct 9 2018, 9:52 AM · Performance-Team, Patch-For-Review, SEO

Oct 5 2018

phuedx updated the task description for T206072: Wikimedia Technical Conference 2018 Session - Determining use cases and requirements for the APIs that we build.
Oct 5 2018, 12:38 PM · Wikimedia-Technical-Conference-2018
phuedx added a comment to T206047: SpecialWatchlistQuery is being deprecated, remove usage in SpecialMobileWatchlist.

☝️ per T206274#4644090.

Oct 5 2018, 12:36 PM · User-Ryasmeen, Audiences-QA, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Technical-Debt, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2)
phuedx added a subtask for T206047: SpecialWatchlistQuery is being deprecated, remove usage in SpecialMobileWatchlist: T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster.
Oct 5 2018, 12:36 PM · User-Ryasmeen, Audiences-QA, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Technical-Debt, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2)
phuedx added a parent task for T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster: T206047: SpecialWatchlistQuery is being deprecated, remove usage in SpecialMobileWatchlist.
Oct 5 2018, 12:36 PM · Growth-Team, StructuredDiscussions, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Audiences-QA, Wikidata, MediaWiki-extensions-WikibaseClient, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2)

Oct 4 2018

phuedx added a comment to T206250: Remove wgCategories from mw.config.

Performance-Team might be interested in this task.

Oct 4 2018, 6:33 PM · Performance-Team (Radar), Readers-Web-Backlog (Tracking), Technical-Debt (Deprecation), MediaWiki-Interface, Front-end-Standards-Group