phuedx (Sam Smith)
Engineering Manager, Readers

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Nov 14 2014, 10:42 AM (218 w, 4 d)
Availability
Available
IRC Nick
phuedx
LDAP User
Unknown
MediaWiki User
Phuedx (WMF) [ Global Accounts ]

Recent Activity

Today

phuedx assigned T213363: Fix or clarify Proton Puppeteer sandboxing and SSL settings to pmiazga.
Tue, Jan 22, 6:12 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Reading-Infrastructure-Team-Backlog, Proton
phuedx added a comment to T211691: [Regression] Menu panel has black background when another drawer is first opened.

☝️ Per today's standup ritual.

Tue, Jan 22, 6:11 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, Regression, MobileFrontend
phuedx reassigned T211691: [Regression] Menu panel has black background when another drawer is first opened from Jdrewniak to Edtadros.
Tue, Jan 22, 6:09 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, Regression, MobileFrontend
phuedx claimed T210554: Deploy page issues to enwiki and all remaining projects.
Tue, Jan 22, 6:06 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Wikimedia-Site-requests, Page-Issue-Warnings
phuedx renamed T214384: [Bug] Type mismatch between NavigationTiming EL schema and Hive table schema from [Bug] Type mistmatch between NavigationTiming EL schema and Hive table schema to [Bug] Type mismatch between NavigationTiming EL schema and Hive table schema.
Tue, Jan 22, 1:39 PM · Performance-Team (Radar), Analytics
phuedx edited projects for T214384: [Bug] Type mismatch between NavigationTiming EL schema and Hive table schema, added: Analytics; removed Readers-Web-Backlog.
Tue, Jan 22, 1:30 PM · Performance-Team (Radar), Analytics
phuedx renamed T214384: [Bug] Type mismatch between NavigationTiming EL schema and Hive table schema from [Bug] Mistmatch between NavigationTiming EL schema and Hive table schema to [Bug] Type mistmatch between NavigationTiming EL schema and Hive table schema.
Tue, Jan 22, 1:30 PM · Performance-Team (Radar), Analytics
phuedx added a comment to T214384: [Bug] Type mismatch between NavigationTiming EL schema and Hive table schema.

@Nuria, @Krinkle: Sorry it took me a little while to file this since I stumbled across it.

Tue, Jan 22, 1:28 PM · Performance-Team (Radar), Analytics
phuedx created T214384: [Bug] Type mismatch between NavigationTiming EL schema and Hive table schema.
Tue, Jan 22, 1:28 PM · Performance-Team (Radar), Analytics

Yesterday

phuedx updated subscribers of T212959: Create AMC edit tag.

☝️ /cc @Edtadros

Mon, Jan 21, 6:10 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx added a comment to T200794: Analyze results of page issues A/B test.

For posterity, the draft report is published here: https://www.mediawiki.org/wiki/Reading/Web/Projects/Mobile_Page_Issues/AB_tests

Mon, Jan 21, 6:01 PM · Readers-Web-Backlog (Tracking), Product-Analytics, Reading-analysis

Fri, Jan 18

phuedx closed T212516: WikimediaEvents do not track logged in beta users on Special:MobileOptions as Resolved.

We appear to be capturing the appropriate information in the PrefUpdate schema (see below) though it's a shame we don't capture the source of the update as well.

Fri, Jan 18, 2:52 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Advanced Mobile Contributions, MobileFrontend, MediaWiki-extensions-WikimediaEvents
phuedx closed T212516: WikimediaEvents do not track logged in beta users on Special:MobileOptions, a subtask of T211197: Build AMC opt-in toggle, as Resolved.
Fri, Jan 18, 2:52 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx added a comment to T212961: Add X-Analytics tag for AMC webrequests.

@ovasileva has sent the request. We're waiting for a response.

Fri, Jan 18, 2:19 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx moved T212961: Add X-Analytics tag for AMC webrequests from Doing to Blocked on Others on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Fri, Jan 18, 2:18 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Thu, Jan 17

phuedx added a comment to T213362: Limit what URLs Proton can access.

Hrrm… I thought we might be able to listen to the response event. I'd assumed that the headers property was mutable but you might be right.

Thu, Jan 17, 6:05 PM · Security, Core Platform Team Backlog (Watching / External), Services (watching), Reading-Infrastructure-Team-Backlog, Proton
phuedx updated subscribers of T213883: Issues with switching between editors when wikitext editor is default .

This seems High priority to me, @ovasileva. It also seems like a regression, right?

Thu, Jan 17, 3:11 PM · Readers-Web-Backlog (Tracking), VisualEditor, MinervaNeue, Mobile
phuedx moved T213883: Issues with switching between editors when wikitext editor is default from Needs triage to MinervaNeue on the Mobile board.
Thu, Jan 17, 3:10 PM · Readers-Web-Backlog (Tracking), VisualEditor, MinervaNeue, Mobile
phuedx triaged T213883: Issues with switching between editors when wikitext editor is default as High priority.
Thu, Jan 17, 3:09 PM · Readers-Web-Backlog (Tracking), VisualEditor, MinervaNeue, Mobile
phuedx edited projects for T213883: Issues with switching between editors when wikitext editor is default , added: MinervaNeue; removed MobileFrontend.
Thu, Jan 17, 3:09 PM · Readers-Web-Backlog (Tracking), VisualEditor, MinervaNeue, Mobile
phuedx updated the task description for T214047: [Bug] SSL failure doesn't cause browser test to be marked as failed.
Thu, Jan 17, 2:41 PM · Release-Engineering-Team (Backlog), Browser-Tests
phuedx updated the task description for T214047: [Bug] SSL failure doesn't cause browser test to be marked as failed.
Thu, Jan 17, 2:40 PM · Release-Engineering-Team (Backlog), Browser-Tests
phuedx created T214047: [Bug] SSL failure doesn't cause browser test to be marked as failed.
Thu, Jan 17, 2:39 PM · Release-Engineering-Team (Backlog), Browser-Tests
phuedx added a comment to T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests.

Ping @hashar, @zeljkofilipin: Has any progress been made on this? Like the Wikidata folk, Readers Web can't move forward with T190710: Minerva Ruby and Node.js browser tests running side by side because of this issue.

Thu, Jan 17, 2:13 PM · MediaWiki-Core-Tests, Release-Engineering-Team (Kanban), Quibble, User-zeljkofilipin
phuedx placed T212516: WikimediaEvents do not track logged in beta users on Special:MobileOptions up for grabs.
Thu, Jan 17, 10:06 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Advanced Mobile Contributions, MobileFrontend, MediaWiki-extensions-WikimediaEvents
phuedx moved T212516: WikimediaEvents do not track logged in beta users on Special:MobileOptions from Needs QA to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Thu, Jan 17, 10:06 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Advanced Mobile Contributions, MobileFrontend, MediaWiki-extensions-WikimediaEvents
phuedx added a comment to T212516: WikimediaEvents do not track logged in beta users on Special:MobileOptions.

Yesterday afternoon, I opted in and out of mobile beta mode whilst logged in with my Phuedx (WMF) account (ID: 22867088, see [1]).

Thu, Jan 17, 10:02 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Advanced Mobile Contributions, MobileFrontend, MediaWiki-extensions-WikimediaEvents
phuedx moved T212959: Create AMC edit tag from Needs QA to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.

Since rEMFR7999d121a130: Introduce `advanced mobile edit` change tag introduces both the tag _and_ the tagging of edits made by users opted into AMC, we should update the QA steps so that the latter is exercised.

Thu, Jan 17, 9:37 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx added a comment to T213362: Limit what URLs Proton can access.

We definitely do not want the CSP to vary by user agent, so we need to look how narrow we can make the CSP without breaking anything. I think wikidomain + *.wikimedia.org + wikidata (just in case) should work well. I'll look into it.

Thu, Jan 17, 9:35 AM · Security, Core Platform Team Backlog (Watching / External), Services (watching), Reading-Infrastructure-Team-Backlog, Proton
phuedx assigned T212961: Add X-Analytics tag for AMC webrequests to ovasileva.

Olga's currently drafting the request.

Thu, Jan 17, 9:18 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx moved T212961: Add X-Analytics tag for AMC webrequests from Blocked on Others to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Thu, Jan 17, 9:17 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Wed, Jan 16

phuedx added a comment to T212465: [EPIC] None of our View's should exhibit 2 levels of inheritance.

Can I ask that an outcome of this epic be well-written documentation about how to author new overlays both within and without the MobileFrontend/MinervaNeue codebases?

Wed, Jan 16, 2:39 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Epic, MobileFrontend, MinervaNeue
phuedx added a comment to T212961: Add X-Analytics tag for AMC webrequests.

Do note that the

Wed, Jan 16, 12:36 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Tue, Jan 15

phuedx claimed T212516: WikimediaEvents do not track logged in beta users on Special:MobileOptions.
Tue, Jan 15, 6:03 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Advanced Mobile Contributions, MobileFrontend, MediaWiki-extensions-WikimediaEvents
phuedx updated subscribers of T213362: Limit what URLs Proton can access.

☝️ /cc @Pchelolo @mobrovac

Tue, Jan 15, 11:40 AM · Security, Core Platform Team Backlog (Watching / External), Services (watching), Reading-Infrastructure-Team-Backlog, Proton

Fri, Jan 11

phuedx updated the task description for T213459: Minimise the code QuickSurveys loads when there are no surveys running.
Fri, Jan 11, 4:43 PM · Performance-Team (Radar), Readers-Web-Backlog, QuickSurveys
phuedx added a comment to T213459: Minimise the code QuickSurveys loads when there are no surveys running.

Very neat, @Krinkle! That approach'll require a fair bit of explanation in the QuickSurveys documentation for future developers (covered by AC 3)

Fri, Jan 11, 4:42 PM · Performance-Team (Radar), Readers-Web-Backlog, QuickSurveys

Thu, Jan 10

phuedx added a comment to T213459: Minimise the code QuickSurveys loads when there are no surveys running.

I removed the duplicate information from the description but should clarify the following:

Thu, Jan 10, 5:56 PM · Performance-Team (Radar), Readers-Web-Backlog, QuickSurveys
phuedx updated the task description for T213459: Minimise the code QuickSurveys loads when there are no surveys running.
Thu, Jan 10, 5:54 PM · Performance-Team (Radar), Readers-Web-Backlog, QuickSurveys
bmansurov awarded T213459: Minimise the code QuickSurveys loads when there are no surveys running a Hungry Hippo token.
Thu, Jan 10, 5:52 PM · Performance-Team (Radar), Readers-Web-Backlog, QuickSurveys
phuedx created T213459: Minimise the code QuickSurveys loads when there are no surveys running.
Thu, Jan 10, 5:28 PM · Performance-Team (Radar), Readers-Web-Backlog, QuickSurveys
phuedx added a comment to T209882: Deploy/Undeploy Quicksurvey for reader trust.

The client-side error rate has since fallen to its previous level: https://grafana.wikimedia.org/d/000000566/reading-web-dashboard?orgId=1&panelId=15&fullscreen&from=1547035200000&to=now&refresh=5m

Thu, Jan 10, 2:40 PM · Readers-Web-Backlog (Tracking), User-Jdlrobson, Patch-For-Review, Research
phuedx added a comment to T209882: Deploy/Undeploy Quicksurvey for reader trust.

@Jdlrobson thanks for spotting this. I wonder what a proper fix would be. There's got to be a way of removing that config. Hopefully the fix reduces the errors.

Thu, Jan 10, 12:36 PM · Readers-Web-Backlog (Tracking), User-Jdlrobson, Patch-For-Review, Research
phuedx updated subscribers of T213363: Fix or clarify Proton Puppeteer sandboxing and SSL settings.

AIUI the service runner running Proton is firejailed. Is that correct @pmiazga, @Pchelolo?

Thu, Jan 10, 12:04 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Reading-Infrastructure-Team-Backlog, Proton
phuedx added a comment to T212959: Create AMC edit tag.

☝️ Formalizing T212959#4867678.

Thu, Jan 10, 10:59 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx added a subtask for T212959: Create AMC edit tag: T211197: Build AMC opt-in toggle.
Thu, Jan 10, 10:58 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx added a parent task for T211197: Build AMC opt-in toggle: T212959: Create AMC edit tag.
Thu, Jan 10, 10:58 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Tue, Jan 8

phuedx set the point value for T212959: Create AMC edit tag to 5.
Tue, Jan 8, 5:40 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx updated the task description for T212959: Create AMC edit tag.
Tue, Jan 8, 5:40 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx added a comment to T212959: Create AMC edit tag.

Here's the GettingStarted extension's implementation of edit tags: https://github.com/wikimedia/mediawiki-extensions-GettingStarted/blob/ae9542e45f722c5f700ed4434dca47d561394794/Hooks.php#L328-L363

Tue, Jan 8, 5:30 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx closed T177210: Security review of Marvin as Declined.

Thanks for the ping, @charlotteportero. This can safely be declined for now as the Marvin project is being archived.

Tue, Jan 8, 2:20 PM · Security-Team-Reviews, Marvin
phuedx closed T177210: Security review of Marvin, a subtask of T177057: Clarify production deployment requirements, outline and blockers, as Declined.
Tue, Jan 8, 2:20 PM · Epic, Marvin
phuedx added a comment to T212961: Add X-Analytics tag for AMC webrequests.

Do note that this task focusses on making the change in our application code, which is made possible by restricting AMC to logged-in users (who are always served by the application servers). It may be prudent to home all of our X-Analytics-related logic in the Varnish VCL's themselves.

Tue, Jan 8, 11:56 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx updated the task description for T212961: Add X-Analytics tag for AMC webrequests.
Tue, Jan 8, 11:45 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx updated the task description for T212961: Add X-Analytics tag for AMC webrequests.
Tue, Jan 8, 11:44 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx updated the task description for T212961: Add X-Analytics tag for AMC webrequests.
Tue, Jan 8, 11:41 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx updated the task description for T212216: AMC page/talk toggle v1: Talk tab at the top of page for AMC users.
Tue, Jan 8, 11:10 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx updated the task description for T212216: AMC page/talk toggle v1: Talk tab at the top of page for AMC users.
Tue, Jan 8, 11:09 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Fri, Jan 4

phuedx updated the task description for T212802: [subtask] Extract beta / stable mode code from MobileContext to new file.
Fri, Jan 4, 9:30 AM · Readers-Web-Backlog, Technical-Debt, Advanced Mobile Contributions

Wed, Jan 2

phuedx added a comment to T211197: Build AMC opt-in toggle.

There was a lot of back and forth between an 8 and a 13 with good discussion about:

Wed, Jan 2, 6:16 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx updated the task description for T211197: Build AMC opt-in toggle.
Wed, Jan 2, 5:29 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx added a comment to T212330: [Bug] Many JSON decode ReadingDepth schema errors from wikiyy.

We don't want to collect this data at all, right?

Wed, Jan 2, 4:48 PM · Readers-Web-Backlog (Tracking), Analytics
phuedx added a comment to T212771: [Bug] Special:Contributions broken when the Flow extension is loaded: "Cannot access private property ContribsPager::$tagFilter".

I think the original change was a good one – constraining a very loose API is a Good Thing™. However, while the ContribsPager API was very loose (a number of member variables were created in the constructor that happily defaulted to public!), I have to ask: should the public member variables have been formally deprecated?

Wed, Jan 2, 4:30 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions, MediaWiki-General-or-Unknown
phuedx added a comment to T212771: [Bug] Special:Contributions broken when the Flow extension is loaded: "Cannot access private property ContribsPager::$tagFilter".

Alright, shall we just make it a public property for now?

Wed, Jan 2, 4:17 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions, MediaWiki-General-or-Unknown
phuedx updated subscribers of T212771: [Bug] Special:Contributions broken when the Flow extension is loaded: "Cannot access private property ContribsPager::$tagFilter".
Wed, Jan 2, 12:49 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions, MediaWiki-General-or-Unknown
phuedx renamed T212771: [Bug] Special:Contributions broken when the Flow extension is loaded: "Cannot access private property ContribsPager::$tagFilter" from [Bug] Special:Contributions broken for users that exist to [Bug] Special:Contributions broken when the Flow extension is loaded.
Wed, Jan 2, 11:06 AM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions, MediaWiki-General-or-Unknown
phuedx added a comment to T212771: [Bug] Special:Contributions broken when the Flow extension is loaded: "Cannot access private property ContribsPager::$tagFilter".

@thiemowmde @Umherirrender: I've subscribed you both as you authored and merged the change I mentioned, respectively.

Wed, Jan 2, 11:03 AM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions, MediaWiki-General-or-Unknown
phuedx created T212771: [Bug] Special:Contributions broken when the Flow extension is loaded: "Cannot access private property ContribsPager::$tagFilter".
Wed, Jan 2, 11:02 AM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions, MediaWiki-General-or-Unknown
phuedx moved T200927: Enable smooth/animated scrolling between links on pages from Needs More Work to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

I take it back. Correlation doesn't imply causation and all that…

Wed, Jan 2, 10:09 AM · Readers-Web-Backlog, Audiences-QA, MobileFrontend, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08)

Fri, Dec 28

phuedx added a comment to T212408: Refactor the /content-providers/MwApiContentProvider.php class for ease of writing PHPUnit tests.

👍

Fri, Dec 28, 1:30 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), MobileFrontend, User-D3r1ck01, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review

Thu, Dec 27

phuedx moved T200927: Enable smooth/animated scrolling between links on pages from Ready for Signoff to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

It looks like this introduced a regression in the automated browser tests (N.B. the failures started on 22nd December as they were run 2 hours prior to T200927#4840811): https://integration.wikimedia.org/ci/job/selenium-MobileFrontend/

Thu, Dec 27, 8:19 AM · Readers-Web-Backlog, Audiences-QA, MobileFrontend, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08)

Dec 21 2018

phuedx closed T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings as Resolved.

Being bold.

Dec 21 2018, 5:50 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx added a comment to T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.

className is always passed to the parent constructor rather than set as a property

Dec 21 2018, 5:50 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx updated the task description for T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.
Dec 21 2018, 5:49 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx added a comment to T212484: Page Preview beacons being sent too fast?.

To be clear, that's 1 second after the page preview is shown, which occurs no less than 700 ms after the user hovers over the link, i.e. the user has to dwell on the link for >= 1.7 seconds prior to the beacon being sent. I grant that some of these beacons could be the result of accidental hovers but, from experience, it's unlikely.

Dec 21 2018, 4:09 PM · Analytics, Product-Analytics
phuedx closed T212408: Refactor the /content-providers/MwApiContentProvider.php class for ease of writing PHPUnit tests as Resolved.

Points 1 and 2 were addressed in https://gerrit.wikimedia.org/r/478488. It'd be good to see a follow-on change to add tests for the class.

Dec 21 2018, 3:41 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), MobileFrontend, User-D3r1ck01, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review
phuedx moved T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings from Ready for Signoff to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

@Jdlrobson: I believe that https://gerrit.wikimedia.org/r/481181 should allow us to mark the first AC as done so that we can resolve this task.

Dec 21 2018, 3:36 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx added a comment to T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.

If a class extends View and defines className and isBorderBox these have no impact
No deprecation notices can be shown in the console under any circumstances

Dec 21 2018, 3:18 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx updated the task description for T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.
Dec 21 2018, 3:17 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx added a comment to T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.

isBorderBox is always passed to the parent constructor rather than set as a property

Dec 21 2018, 3:15 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx updated the task description for T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.
Dec 21 2018, 3:12 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx added a comment to T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.

className is always passed to the parent constructor rather than set as a property

Dec 21 2018, 3:11 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx updated the task description for T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.
Dec 21 2018, 3:10 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx updated the task description for T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.
Dec 21 2018, 3:07 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx claimed T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.
Dec 21 2018, 3:06 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx updated the task description for T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.
Dec 21 2018, 3:06 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx added a comment to T212484: Page Preview beacons being sent too fast?.

(Emphasis on should)

Dec 21 2018, 11:44 AM · Analytics, Product-Analytics
phuedx added a comment to T212484: Page Preview beacons being sent too fast?.

The beacon should be being sent 1 second after the page preview is shown. This is also reflected in the AC for T184793: [EPIC] Instrument page interactions and in the description of the VirtualPageview schema itself.

Dec 21 2018, 11:43 AM · Analytics, Product-Analytics
phuedx triaged T200235: Word spacing issue in disclaimer of generated PDFs as Normal priority.

My guess is that this is Normal to High. We should try to reproduce it with Proton and if we can, then it should be escalated.

Dec 21 2018, 11:21 AM · Proton, Readers-Web-Backlog

Dec 19 2018

phuedx added a comment to T208980: [Bug] The statsv client should send a request when the page unloads.

What reading web products using statsv that might be impacted?

Dec 19 2018, 10:27 AM · Performance-Team, Readers-Web-Backlog, MediaWiki-extensions-WikimediaEvents

Dec 18 2018

phuedx added a comment to T212137: Analyze impact of mobile visual editor load screen improvements.

How long does it take on average for pages to load?

Dec 18 2018, 11:27 AM · Product-Analytics, VisualEditor
phuedx added a comment to T210400: PHPUnit: Cover methods in content-providers/ContentProviderFactory.php with unit tests.

Thank you, @D3r1ck01!

Dec 18 2018, 11:03 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend
phuedx closed T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests as Resolved.

Being bold.

Dec 18 2018, 11:01 AM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, User-D3r1ck01, MobileFrontend
phuedx closed T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests, a subtask of T208761: [Epic] Improve PHPUnit coverage in MobileFrontend to medium, as Resolved.
Dec 18 2018, 11:01 AM · Readers-Web-Backlog, Epic, MobileFrontend
phuedx updated the task description for T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests.
Dec 18 2018, 11:01 AM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, User-D3r1ck01, MobileFrontend
phuedx added a comment to T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests.

Code Coverage has gone up to 100%

Dec 18 2018, 11:00 AM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, User-D3r1ck01, MobileFrontend
phuedx closed T210400: PHPUnit: Cover methods in content-providers/ContentProviderFactory.php with unit tests as Resolved.

Being bold.

Dec 18 2018, 10:44 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend
phuedx closed T210400: PHPUnit: Cover methods in content-providers/ContentProviderFactory.php with unit tests, a subtask of T208761: [Epic] Improve PHPUnit coverage in MobileFrontend to medium, as Resolved.
Dec 18 2018, 10:44 AM · Readers-Web-Backlog, Epic, MobileFrontend
phuedx updated the task description for T210400: PHPUnit: Cover methods in content-providers/ContentProviderFactory.php with unit tests.
Dec 18 2018, 10:44 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend
phuedx added a comment to T210400: PHPUnit: Cover methods in content-providers/ContentProviderFactory.php with unit tests.

Code Coverage has gone up to 100%

Dec 18 2018, 10:43 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend