Page MenuHomePhabricator

phuedx (Sam Smith)
Staff Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Nov 14 2014, 10:42 AM (349 w, 5 h)
Availability
Available
IRC Nick
phuedx
LDAP User
Unknown
MediaWiki User
Phuedx (WMF) [ Global Accounts ]

Avatar by Buch.

Recent Activity

Yesterday

phuedx added a comment to T280798: Fix namespace blocks of removed extension namespaces (and actions).

I can confirm this on beta. I am guessing it is because $this->getLanguage()->getFormattedNsText() returns '' for NS_MAIN.

Thu, Jul 22, 4:43 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Anti-Harassment (The Letter Song), MediaWiki-Blocks
phuedx moved T279540: Instrument IP address copy action metric from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.
Thu, Jul 22, 3:33 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Anti-Harassment (The Letter Song), IP Info
phuedx moved T279540: Instrument IP address copy action metric from Code Review 🔍 to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
Thu, Jul 22, 7:06 AM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Anti-Harassment (The Letter Song), IP Info

Wed, Jul 21

phuedx committed rEGLW9edb3a7af77a: Selenium tests for vue version of Special:GlobalWatchlist (authored by DannyS712).
Selenium tests for vue version of Special:GlobalWatchlist
Wed, Jul 21, 10:37 AM
phuedx added a comment to T267211: Remove non-VirtualPageView EventLogging code from the Page Previews codebase.

@awight: I've +1'd https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/667897/. I'd really appreciate it if you could confirm that the ReferencePreviewsPopups instrumentation is still works as expected.

Wed, Jul 21, 9:44 AM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Performance-Team (Radar), Patch-For-Review, Page-Previews
phuedx updated the task description for T267211: Remove non-VirtualPageView EventLogging code from the Page Previews codebase.
Wed, Jul 21, 9:40 AM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Performance-Team (Radar), Patch-For-Review, Page-Previews

Tue, Jul 20

phuedx moved T279540: Instrument IP address copy action metric from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.
Tue, Jul 20, 5:51 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Anti-Harassment (The Letter Song), IP Info
phuedx updated the task description for T286932: Confirm the bucketing for the languages A/B tests worked as expected.
Tue, Jul 20, 10:02 AM · Vector, Readers-Web-Backlog (Kanbanana-FY-2020-21)

Mon, Jul 19

phuedx updated phuedx.
Mon, Jul 19, 6:41 PM
phuedx claimed T279540: Instrument IP address copy action metric.
Mon, Jul 19, 4:08 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Anti-Harassment (The Letter Song), IP Info

Fri, Jul 2

phuedx added a comment to T284643: Regression: Page previews displaying images with different heights.

@ovasileva: Could you provide a working example that this has regressed from?

Fri, Jul 2, 4:08 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Page-Previews

Thu, Jul 1

phuedx added a comment to T268782: It should be possible to target surveys at users with a specific user agent.

I think for now, the simple regex map will do the trick. In the future however, if more granular targeting for surveys is desired, we probably should consider using a proper parser lib.

Thu, Jul 1, 3:17 PM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Readers-Web-Backlog (Kanbanana-FY-2020-21), KaiOS-Wikipedia-app, QuickSurveys, Inuka-Team
phuedx awarded T280770: Instrumentation QA for language switching a Mountain of Wealth token.
Thu, Jul 1, 3:15 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Patch-For-Review, Product-Analytics (Kanban), Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)

Wed, Jun 30

phuedx assigned T268782: It should be possible to target surveys at users with a specific user agent to cjming.
Wed, Jun 30, 4:38 PM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Readers-Web-Backlog (Kanbanana-FY-2020-21), KaiOS-Wikipedia-app, QuickSurveys, Inuka-Team
phuedx added a comment to T280770: Instrumentation QA for language switching .

@phuedx - Are there any other scenarios where this event context would be logged? I'm seeing event.context = 'content-language-switcher' events logged on the legacy vector (see data below). Is this also logged if a user switches languages after selecting the N More button in the sidebar?

Wed, Jun 30, 3:37 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Patch-For-Review, Product-Analytics (Kanban), Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx placed T281797: Remove all bolding of search results on a variety of wikis up for grabs.
Wed, Jun 30, 1:42 PM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Patch-For-Review, Vector, Readers-Web-Backlog (Kanbanana-FY-2020-21), WVUI, Vue.js (Vue.js Search Experience (Vector modern)), Bengali-Sites, Desktop Improvements
phuedx placed T268782: It should be possible to target surveys at users with a specific user agent up for grabs.
Wed, Jun 30, 10:45 AM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Readers-Web-Backlog (Kanbanana-FY-2020-21), KaiOS-Wikipedia-app, QuickSurveys, Inuka-Team
phuedx moved T281797: Remove all bolding of search results on a variety of wikis from Blocked on Others to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Wed, Jun 30, 10:45 AM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Patch-For-Review, Vector, Readers-Web-Backlog (Kanbanana-FY-2020-21), WVUI, Vue.js (Vue.js Search Experience (Vector modern)), Bengali-Sites, Desktop Improvements

Tue, Jun 29

phuedx moved T281797: Remove all bolding of search results on a variety of wikis from Done to Doing on the WVUI board.
Tue, Jun 29, 5:44 PM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Patch-For-Review, Vector, Readers-Web-Backlog (Kanbanana-FY-2020-21), WVUI, Vue.js (Vue.js Search Experience (Vector modern)), Bengali-Sites, Desktop Improvements
phuedx added a comment to T281797: Remove all bolding of search results on a variety of wikis.

I'd have thought this was a feature you'd want to flag on a language basis, but I defer to the team. :-)

Tue, Jun 29, 9:07 AM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Patch-For-Review, Vector, Readers-Web-Backlog (Kanbanana-FY-2020-21), WVUI, Vue.js (Vue.js Search Experience (Vector modern)), Bengali-Sites, Desktop Improvements

Mon, Jun 28

phuedx moved T281797: Remove all bolding of search results on a variety of wikis from Doing to Blocked on Others on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Mon, Jun 28, 1:57 PM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Patch-For-Review, Vector, Readers-Web-Backlog (Kanbanana-FY-2020-21), WVUI, Vue.js (Vue.js Search Experience (Vector modern)), Bengali-Sites, Desktop Improvements
phuedx reassigned T268782: It should be possible to target surveys at users with a specific user agent from phuedx to cjming.
Mon, Jun 28, 1:57 PM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Readers-Web-Backlog (Kanbanana-FY-2020-21), KaiOS-Wikipedia-app, QuickSurveys, Inuka-Team
phuedx reassigned T280825: Create harness for A/B test for logged in users from phuedx to MNeisler.
Mon, Jun 28, 1:57 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx moved T268782: It should be possible to target surveys at users with a specific user agent from Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Mon, Jun 28, 1:56 PM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Readers-Web-Backlog (Kanbanana-FY-2020-21), KaiOS-Wikipedia-app, QuickSurveys, Inuka-Team

Fri, Jun 25

phuedx added a comment to T280825: Create harness for A/B test for logged in users.

As we discussed in yesterday's Web task sync I've run a query to see if the treatments are balanced:

Fri, Jun 25, 12:06 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)

Thu, Jun 24

phuedx moved T249247: History page with long titles not wrapping with AMC disabled from Triaged but Future to Needs Prioritization (Product) on the Readers-Web-Backlog board.
Thu, Jun 24, 6:02 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Readers-Web-Backlog (Kanbanana-FY-2020-21), MobileFrontend, good first task, patch-welcome
phuedx moved T284950: Remove deprecated hooks with no usages from Needs More Work to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Thu, Jun 24, 5:13 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Readers-Web-Backlog (Kanbanana-FY-2020-21), Technical-Debt (Deprecation process), good first task, MediaWiki-Core-Skin-Architecture

Wed, Jun 23

phuedx updated subscribers of T281797: Remove all bolding of search results on a variety of wikis.

@Jdforrester-WMF: Would you be able to do a concept review of https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/699416/, which attempts to tag the relevant wikis (see the task description for the list). Specifically, is it necessary to create another file, disable_search_autocomplete_highlights.yaml say, simply to add a wikiTag line rather than add that line directly to the wiki config files?

Wed, Jun 23, 4:05 PM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Patch-For-Review, Vector, Readers-Web-Backlog (Kanbanana-FY-2020-21), WVUI, Vue.js (Vue.js Search Experience (Vector modern)), Bengali-Sites, Desktop Improvements

Jun 23 2021

phuedx reassigned T280770: Instrumentation QA for language switching from Jdrewniak to MNeisler.
Jun 23 2021, 2:14 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Patch-For-Review, Product-Analytics (Kanban), Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx moved T280770: Instrumentation QA for language switching from Code Review to QA in Prod on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 23 2021, 2:13 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Patch-For-Review, Product-Analytics (Kanban), Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx assigned T284594: Userlinks: Remove SkinVector::ICON_USER_LINK_MAP to Jdlrobson.

@Jdlrobson: It looks like you've started reviewing @nray's patches so I'm being bold and assigning this task to you.

Jun 23 2021, 2:13 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Readers-Web-Backlog (Kanbanana-FY-2020-21), Technical-Debt, Vector, RW-Feature-DI-User-Menu, Desktop Improvements
phuedx placed T284950: Remove deprecated hooks with no usages up for grabs.
Jun 23 2021, 2:10 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Readers-Web-Backlog (Kanbanana-FY-2020-21), Technical-Debt (Deprecation process), good first task, MediaWiki-Core-Skin-Architecture
phuedx moved T284950: Remove deprecated hooks with no usages from Doing to Design Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 23 2021, 2:09 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Readers-Web-Backlog (Kanbanana-FY-2020-21), Technical-Debt (Deprecation process), good first task, MediaWiki-Core-Skin-Architecture
phuedx added a comment to T284950: Remove deprecated hooks with no usages.

and issue has been filed

Jun 23 2021, 2:08 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Readers-Web-Backlog (Kanbanana-FY-2020-21), Technical-Debt (Deprecation process), good first task, MediaWiki-Core-Skin-Architecture
phuedx claimed T284950: Remove deprecated hooks with no usages.
Jun 23 2021, 11:07 AM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Readers-Web-Backlog (Kanbanana-FY-2020-21), Technical-Debt (Deprecation process), good first task, MediaWiki-Core-Skin-Architecture
phuedx moved T284950: Remove deprecated hooks with no usages from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 23 2021, 11:07 AM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Readers-Web-Backlog (Kanbanana-FY-2020-21), Technical-Debt (Deprecation process), good first task, MediaWiki-Core-Skin-Architecture

Jun 22 2021

phuedx added a comment to T254977: Server-side survey configuration filtering.

@phuedx does T245292 impact your analysis in any way?

Jun 22 2021, 11:33 AM · Readers-Web-Backlog (Tracking), Performance Issue, QuickSurveys
phuedx reassigned T262859: isElementInViewport is unnecessarily slow on Firefox from Jdlrobson to Edtadros.
Jun 22 2021, 9:38 AM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Readers-Web-Backlog (Kanbanana-FY-2020-21), QuickSurveys, MediaWiki-Interface, Performance Issue, Browser-Support-Firefox
phuedx updated the task description for T262859: isElementInViewport is unnecessarily slow on Firefox.
Jun 22 2021, 9:37 AM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Readers-Web-Backlog (Kanbanana-FY-2020-21), QuickSurveys, MediaWiki-Interface, Performance Issue, Browser-Support-Firefox
phuedx added a comment to T262859: isElementInViewport is unnecessarily slow on Firefox.

@Edtadros: It should be sufficient to test that the survey appears as before (on both desktop and mobile) and that an event.eventName="impression" event is logged when it appears.

Jun 22 2021, 8:59 AM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Readers-Web-Backlog (Kanbanana-FY-2020-21), QuickSurveys, MediaWiki-Interface, Performance Issue, Browser-Support-Firefox

Jun 21 2021

phuedx claimed T254977: Server-side survey configuration filtering.
Jun 21 2021, 5:33 PM · Readers-Web-Backlog (Tracking), Performance Issue, QuickSurveys
phuedx placed T280770: Instrumentation QA for language switching up for grabs.
Jun 21 2021, 5:08 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Patch-For-Review, Product-Analytics (Kanban), Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx committed rEGTObaa4bfa2a448: Remove IE8 workaround code fragments (authored by Volker E <volker.e@wikimedia.org>).
Remove IE8 workaround code fragments
Jun 21 2021, 2:20 PM
phuedx added a comment to T280982: Suggestions in new Vector search form should wrap long words.

I always have this happen on dewiki, where content language and interface language are both German!

Jun 21 2021, 1:33 PM · Vector (Vector (Tracking)), WVUI, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx moved T277534: TypeaheadSearch component: Localization issue on quotation marks from Needs More Work to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.

Being bold.

Jun 21 2021, 11:20 AM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js Search Experience (Vector modern)), I18n, Vector (Vector (Tracking)), WVUI
phuedx moved T280982: Suggestions in new Vector search form should wrap long words from Ready for Signoff to Needs More Work on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.

Being bold.

Jun 21 2021, 11:19 AM · Vector (Vector (Tracking)), WVUI, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx reopened T280982: Suggestions in new Vector search form should wrap long words as "Open".

Per T277534#7165409, I'm seeing the following in production when the interface language is different from the content language (e.g. https://en.wikipedia.org/wiki/Main_Page?useskinversion=2&uselang=he):

Jun 21 2021, 11:19 AM · Vector (Vector (Tracking)), WVUI, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx added a comment to T277534: TypeaheadSearch component: Localization issue on quotation marks.

Generally, I'm not seeing this in production, locally, or on the Beta Cluster.

Jun 21 2021, 11:15 AM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js Search Experience (Vector modern)), I18n, Vector (Vector (Tracking)), WVUI

Jun 17 2021

phuedx added a comment to T254977: Server-side survey configuration filtering.

Firstly, let's address what we need to know in order to remove certain parts of the survey config payload ("the payload"):

Jun 17 2021, 5:25 PM · Readers-Web-Backlog (Tracking), Performance Issue, QuickSurveys

Jun 15 2021

Jdlrobson awarded T235752: Deprecate/undeploy the GettingStarted extension a Love token.
Jun 15 2021, 4:55 PM · Technical-Debt, Growth-Team-Filtering, User-notice, MediaWiki-extensions-GettingStarted, Growth-Team
phuedx added a comment to T280770: Instrumentation QA for language switching .

Quick question on the current implementation - can we tell the difference between selecting a language from the list and changing the settings for the control group?

Jun 15 2021, 9:30 AM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Patch-For-Review, Product-Analytics (Kanban), Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx added a comment to T280770: Instrumentation QA for language switching .

However, there is a caveat: it's quite difficult to thread through a value for event.context through a value so it'll always be the default ("interface"),

@phuedx To confirm, this means that both of the following events are recorded the same way, correct?:

  • A user clicks the language button in the header and changes the display language setting
  • A user clicks the language button in the header and switches languages
Jun 15 2021, 8:31 AM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Patch-For-Review, Product-Analytics (Kanban), Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)

Jun 14 2021

phuedx moved T283881: mw.user.sessionId sometimes returns IDs with 16 characters rather than 20 from Needs Prioritization to Needs Prioritization (Tech) on the Readers-Web-Backlog board.
Jun 14 2021, 5:25 PM · Readers-Web-Backlog (Tracking), Product-Data-Infrastructure, Product-Analytics
phuedx edited projects for T283881: mw.user.sessionId sometimes returns IDs with 16 characters rather than 20, added: Readers-Web-Backlog; removed Readers-Web-Backlog (Kanbanana-FY-2020-21).

I've added a filter to the eventgate-validation Logstash dashboard (Logstashboard?!) that refers to this task. Given T283881#7152241, I'm inclined to either lower the priority of this task to Lowest or decline this task. Regardless, I'm moving this off of Readers Web's kanban board.

Jun 14 2021, 5:24 PM · Readers-Web-Backlog (Tracking), Product-Data-Infrastructure, Product-Analytics

Jun 11 2021

phuedx added a comment to T280770: Instrumentation QA for language switching .

POSSIBLE BUG/MISSING INSTRUMENTATION:

  • For sessions with clicks to the new language button in the header, I'm not seeing any language change events (event.action = 'language-change') for when a user changes language by clicking on one of the language links that appear after the user clicks the button. Was instrumentation added to track these events?
Jun 11 2021, 9:53 AM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Patch-For-Review, Product-Analytics (Kanban), Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)

Jun 10 2021

phuedx placed T257695: QuickSurveys description should be optional up for grabs.
Jun 10 2021, 6:15 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Readers-Web-Backlog (Kanbanana-FY-2020-21), QuickSurveys

Jun 9 2021

phuedx claimed T254977: Server-side survey configuration filtering.
Jun 9 2021, 10:47 AM · Readers-Web-Backlog (Tracking), Performance Issue, QuickSurveys
phuedx moved T262859: isElementInViewport is unnecessarily slow on Firefox from Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 9 2021, 10:46 AM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Readers-Web-Backlog (Kanbanana-FY-2020-21), QuickSurveys, MediaWiki-Interface, Performance Issue, Browser-Support-Firefox
phuedx closed T113455: Share test surveys configuration between different builds as Declined.

Tempus fugit

Jun 9 2021, 10:16 AM · Readers-Web-Backlog (Tracking), Spike, QuickSurveys
phuedx closed T113455: Share test surveys configuration between different builds, a subtask of T166395: [EPIC] Make QuickSurveys more useful to survey writers, as Declined.
Jun 9 2021, 10:16 AM · Readers-Web-Backlog (Tracking)
phuedx added a comment to T257695: QuickSurveys description should be optional.

I'll set one up but will need help getting it deployed..

Jun 9 2021, 9:58 AM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Readers-Web-Backlog (Kanbanana-FY-2020-21), QuickSurveys

Jun 8 2021

phuedx added a comment to T278894: [1.37] The class mw-ajax-loader will no longer be styled by Vector.

@bwang: Are you working on this? If so, could you move it into Doing.

Jun 8 2021, 4:00 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Technical-Debt, MediaWiki-extensions-LiquidThreads, MW-1.37-release
phuedx placed T283955: Align the numerals on the language switching button to local scripts up for grabs.
Jun 8 2021, 3:59 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
phuedx updated the task description for T283955: Align the numerals on the language switching button to local scripts.
Jun 8 2021, 3:23 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
phuedx added a comment to T283955: Align the numerals on the language switching button to local scripts.

The Message object doesn't guess at how parameters should be handled but needs to be told. Message::numParams() tags the passed parameter as a number so that it can be formatted when needed. AIUI we have to change

Jun 8 2021, 3:22 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
phuedx added a comment to T262859: isElementInViewport is unnecessarily slow on Firefox.

@ovasileva: @Jdlrobson and I are discussing how much of the survey should be visible on the screen before we log an impression. Currently, we log an impression when approx. half of the survey is visible. @Jdlrobson's patch supports changing that value if we want. Do we want to change this behaviour? If so, then how much of the survey should be visible before we log an impression?

Jun 8 2021, 2:58 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Readers-Web-Backlog (Kanbanana-FY-2020-21), QuickSurveys, MediaWiki-Interface, Performance Issue, Browser-Support-Firefox
phuedx moved T262859: isElementInViewport is unnecessarily slow on Firefox from Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 8 2021, 2:47 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Readers-Web-Backlog (Kanbanana-FY-2020-21), QuickSurveys, MediaWiki-Interface, Performance Issue, Browser-Support-Firefox
phuedx added a project to T284542: [SPIKE] Investigate existing instrumentation for User Links feature: Spike.
Jun 8 2021, 8:48 AM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Product-Analytics, Readers-Web-Backlog (Kanbanana-FY-2020-21), Spike, RW-Feature-DI-User-Menu, Desktop Improvements
phuedx created T284542: [SPIKE] Investigate existing instrumentation for User Links feature.
Jun 8 2021, 8:48 AM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Product-Analytics, Readers-Web-Backlog (Kanbanana-FY-2020-21), Spike, RW-Feature-DI-User-Menu, Desktop Improvements

Jun 7 2021

phuedx added a comment to T284096: Kerberos identity for phuedx.

Thanks!

Jun 7 2021, 1:27 PM · Analytics
phuedx assigned T262859: isElementInViewport is unnecessarily slow on Firefox to Jdlrobson.
Jun 7 2021, 9:31 AM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Readers-Web-Backlog (Kanbanana-FY-2020-21), QuickSurveys, MediaWiki-Interface, Performance Issue, Browser-Support-Firefox
phuedx moved T262859: isElementInViewport is unnecessarily slow on Firefox from Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 7 2021, 9:31 AM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Readers-Web-Backlog (Kanbanana-FY-2020-21), QuickSurveys, MediaWiki-Interface, Performance Issue, Browser-Support-Firefox

Jun 2 2021

phuedx closed T282653: "Use Legacy Vector" setting is available on wikis that have not been opted in as Resolved.

I'm being bold and resolving this. If it can be replicated, then please do reopen this task.

Jun 2 2021, 6:30 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements, Vector
phuedx added a comment to T283881: mw.user.sessionId sometimes returns IDs with 16 characters rather than 20.

This is also occurring for the following data streams:

Jun 2 2021, 11:56 AM · Readers-Web-Backlog (Tracking), Product-Data-Infrastructure, Product-Analytics
phuedx assigned T257695: QuickSurveys description should be optional to Jdlrobson.
Jun 2 2021, 10:41 AM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Readers-Web-Backlog (Kanbanana-FY-2020-21), QuickSurveys
phuedx moved T280405: Search button should use Searchbutton instead of Search from Code Review to QA on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 2 2021, 9:48 AM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js Search Experience (Vector modern)), Desktop Improvements

Jun 1 2021

phuedx created T284096: Kerberos identity for phuedx.
Jun 1 2021, 5:38 PM · Analytics
phuedx placed T257695: QuickSurveys description should be optional up for grabs.
Jun 1 2021, 5:06 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Readers-Web-Backlog (Kanbanana-FY-2020-21), QuickSurveys
zeljkofilipin awarded T283182: 12:45:04 FAIL skins.minerva.content.styles: 3.08KB > maxSize 2.2KB (gzip) a Party Time token.
Jun 1 2021, 1:32 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), User-zeljkofilipin, MinervaNeue, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx claimed T257695: QuickSurveys description should be optional.
Jun 1 2021, 1:01 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Readers-Web-Backlog (Kanbanana-FY-2020-21), QuickSurveys
phuedx moved T257695: QuickSurveys description should be optional from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 1 2021, 1:01 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Readers-Web-Backlog (Kanbanana-FY-2020-21), QuickSurveys
phuedx closed T283182: 12:45:04 FAIL skins.minerva.content.styles: 3.08KB > maxSize 2.2KB (gzip) as Resolved.

Being bold and signing this off. I triggered a build and it passed as expected.

Jun 1 2021, 12:49 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), User-zeljkofilipin, MinervaNeue, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx added a comment to T281797: Remove all bolding of search results on a variety of wikis.

This is blocked on the next WVUI release /cc @Volker_E

Jun 1 2021, 12:45 PM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Patch-For-Review, Vector, Readers-Web-Backlog (Kanbanana-FY-2020-21), WVUI, Vue.js (Vue.js Search Experience (Vector modern)), Bengali-Sites, Desktop Improvements
phuedx moved T281797: Remove all bolding of search results on a variety of wikis from Code Review to Blocked on Others on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 1 2021, 12:41 PM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Patch-For-Review, Vector, Readers-Web-Backlog (Kanbanana-FY-2020-21), WVUI, Vue.js (Vue.js Search Experience (Vector modern)), Bengali-Sites, Desktop Improvements

May 27 2021

phuedx added a comment to T274869: Instrumentation QA for new search widget.

What patch(es) need code review (I don't see any associated)?

May 27 2021, 7:43 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Product-Analytics (Kanban), MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Performance-Team (Radar), Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx placed T280770: Instrumentation QA for language switching up for grabs.
May 27 2021, 7:42 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Patch-For-Review, Product-Analytics (Kanban), Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx reassigned T274869: Instrumentation QA for new search widget from Edtadros to MNeisler.
May 27 2021, 7:42 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Product-Analytics (Kanban), MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Performance-Team (Radar), Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx assigned T274869: Instrumentation QA for new search widget to Edtadros.
May 27 2021, 7:41 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Product-Analytics (Kanban), MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Performance-Team (Radar), Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx claimed T282653: "Use Legacy Vector" setting is available on wikis that have not been opted in.
May 27 2021, 4:16 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements, Vector
phuedx added a comment to T282653: "Use Legacy Vector" setting is available on wikis that have not been opted in.

Browsing again, the Use Legacy Vector option is still unchecked in my user preference and the pages show properly.

May 27 2021, 4:16 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements, Vector
phuedx closed T275762: Instrument clicks to links in the Languages list in the sidebar as Resolved.

Being bold and signing this off and broader instrumentation QA and sign off is happening over at T280770: Instrumentation QA for language switching .

May 27 2021, 4:01 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Vector (Language in header), Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-extensions-WikimediaEvents, Desktop Improvements
phuedx closed T275762: Instrument clicks to links in the Languages list in the sidebar, a subtask of T269093: Deploy new language switching location to test wikis and begin A/B test pt 1, as Resolved.
May 27 2021, 4:01 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Wikimedia-Site-requests, Desktop Improvements
phuedx closed T275762: Instrument clicks to links in the Languages list in the sidebar, a subtask of T280526: Deploy new language switching functionality to logged-in users , as Resolved.
May 27 2021, 4:01 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Wikimedia-Site-requests, Desktop Improvements
phuedx closed T275762: Instrument clicks to links in the Languages list in the sidebar, a subtask of T256023: [EPIC] Improve language switching capabilities, as Resolved.
May 27 2021, 4:01 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
phuedx closed T281928: No event fired for clicking the language button as Resolved.

Being bold and signing this off and broader instrumentation QA and sign off is happening over at T280770: Instrumentation QA for language switching .

May 27 2021, 4:01 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx placed T281797: Remove all bolding of search results on a variety of wikis up for grabs.
May 27 2021, 3:59 PM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Patch-For-Review, Vector, Readers-Web-Backlog (Kanbanana-FY-2020-21), WVUI, Vue.js (Vue.js Search Experience (Vector modern)), Bengali-Sites, Desktop Improvements
phuedx added a comment to T280770: Instrumentation QA for language switching .

I discussed this with @ovasileva and we concluded that we can backport that above changes next week and then wait until the week after to enable the A/B test.

May 27 2021, 11:41 AM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Patch-For-Review, Product-Analytics (Kanban), Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)

May 26 2021

phuedx committed rWVUIb9cfa1d7561b: Optionally disable query match highlighting (authored by phuedx).
Optionally disable query match highlighting
May 26 2021, 7:44 PM
phuedx placed T274869: Instrumentation QA for new search widget up for grabs.
May 26 2021, 5:09 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Product-Analytics (Kanban), MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Performance-Team (Radar), Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx added a comment to T267256: WVUI Typeahead search: Follow keyboard support outlined in ARIA 1.1 Combox with Listbox Popup example.

Were there issues implementing this or is this clear to implement it's just a matter of priorities?

May 26 2021, 4:30 PM · Readers-Web-Backlog (Tracking), Accessibility, Desktop Improvements, WVUI