Page MenuHomePhabricator

phuedx (Sam Smith)
Senior Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Nov 14 2014, 10:42 AM (328 w, 6 d)
Availability
Available
IRC Nick
phuedx
LDAP User
Unknown
MediaWiki User
Phuedx (WMF) [ Global Accounts ]

Recent Activity

Yesterday

phuedx assigned T276455: MobileFrontend transformations interfere with DiscussionTools transformations to ovasileva.
Thu, Mar 4, 5:05 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), HtmlFormatter, Readers-Web-Backlog (Tracking), Patch-For-Review, DiscussionTools
phuedx added a project to T276455: MobileFrontend transformations interfere with DiscussionTools transformations: Readers-Web-Backlog.
Thu, Mar 4, 5:04 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), HtmlFormatter, Readers-Web-Backlog (Tracking), Patch-For-Review, DiscussionTools
phuedx updated the task description for T276474: '.event.query' should be string.
Thu, Mar 4, 4:14 PM · Discovery-Search, MediaWiki-extensions-WikimediaEvents, Wikimedia-production-error
phuedx created T276474: '.event.query' should be string.
Thu, Mar 4, 4:13 PM · Discovery-Search, MediaWiki-extensions-WikimediaEvents, Wikimedia-production-error
phuedx awarded Blog Post: Eventlogging journey a Like token.
Thu, Mar 4, 11:56 AM
phuedx claimed T275894: Migrate UniversalLanguageSelector instrument to WikimediaEvents extension.
Thu, Mar 4, 11:46 AM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-extensions-WikimediaEvents, UniversalLanguageSelector
phuedx moved T275894: Migrate UniversalLanguageSelector instrument to WikimediaEvents extension from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Thu, Mar 4, 11:45 AM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-extensions-WikimediaEvents, UniversalLanguageSelector

Wed, Mar 3

phuedx set the point value for T275766: Log sessionID, isAnon, editBucketCount, and selectedLanguage properties in the UniversalLanguageSelector instrument to 3.
Wed, Mar 3, 6:32 PM · MediaWiki-extensions-WikimediaEvents, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vector, Desktop Improvements
phuedx updated the task description for T275766: Log sessionID, isAnon, editBucketCount, and selectedLanguage properties in the UniversalLanguageSelector instrument.
Wed, Mar 3, 6:32 PM · MediaWiki-extensions-WikimediaEvents, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vector, Desktop Improvements
phuedx assigned T276112: Regression: Page Previews and Reference Previews tip triangle is in the wrong location in RTL wikis to Nomsterio.
Wed, Mar 3, 5:59 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Performance-Team, Readers-Web-Backlog (Kanbanana-FY-2020-21), Page-Previews, RTL, I18n
phuedx added a comment to T276112: Regression: Page Previews and Reference Previews tip triangle is in the wrong location in RTL wikis.

FWIW I don't think it's necessary to revert the patch that I merged today. @Jdlrobson left some helpful comments on the patch that should get us to the solution 🙂

Wed, Mar 3, 5:58 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Performance-Team, Readers-Web-Backlog (Kanbanana-FY-2020-21), Page-Previews, RTL, I18n
phuedx placed T276112: Regression: Page Previews and Reference Previews tip triangle is in the wrong location in RTL wikis up for grabs.
Wed, Mar 3, 3:26 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Performance-Team, Readers-Web-Backlog (Kanbanana-FY-2020-21), Page-Previews, RTL, I18n
phuedx moved T276112: Regression: Page Previews and Reference Previews tip triangle is in the wrong location in RTL wikis from Needs QA to Blocked on Others on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Wed, Mar 3, 3:26 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Performance-Team, Readers-Web-Backlog (Kanbanana-FY-2020-21), Page-Previews, RTL, I18n
phuedx closed T276294: "Search Clicking on a watchstar toggles the watchstar" selenium test failing as Resolved.

Being bold. I re-ran the tests and it passes. I've also confirmed that fuzzy matches are being returned on the Beta Cluster:

Wed, Mar 3, 2:33 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), MinervaNeue
phuedx reassigned T276112: Regression: Page Previews and Reference Previews tip triangle is in the wrong location in RTL wikis from phuedx to Edtadros.
Wed, Mar 3, 12:03 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Performance-Team, Readers-Web-Backlog (Kanbanana-FY-2020-21), Page-Previews, RTL, I18n
phuedx placed T210106: Provide a reusable getEditCountBucket function for analytics purposes up for grabs.
Wed, Mar 3, 12:02 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Analytics-Radar, Patch-For-Review, Front-end-Standards-Group, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents
phuedx claimed T276112: Regression: Page Previews and Reference Previews tip triangle is in the wrong location in RTL wikis.
Wed, Mar 3, 11:14 AM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Performance-Team, Readers-Web-Backlog (Kanbanana-FY-2020-21), Page-Previews, RTL, I18n
phuedx moved T276112: Regression: Page Previews and Reference Previews tip triangle is in the wrong location in RTL wikis from Upcoming to Needs Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Wed, Mar 3, 11:00 AM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Performance-Team, Readers-Web-Backlog (Kanbanana-FY-2020-21), Page-Previews, RTL, I18n
phuedx reassigned T262093: MoveLeadParagraphTransformInfobox should be rewritten to be more similar to mobile apps from ovasileva to Edtadros.
Wed, Mar 3, 10:52 AM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Readers-Web-Backlog (Kanbanana-FY-2020-21), MobileFrontend
phuedx moved T262093: MoveLeadParagraphTransformInfobox should be rewritten to be more similar to mobile apps from Needs Code Review to Needs QA on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Wed, Mar 3, 10:38 AM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Readers-Web-Backlog (Kanbanana-FY-2020-21), MobileFrontend
phuedx added a comment to T276304: Review Popups metrics deprecation and coordinate according to WMDE Tech Wishes needs.

Thanks for writing this up, @awight.

Wed, Mar 3, 10:22 AM · WMDE-TechWish-Sprint-2021-03-03, Page-Previews, Analytics-Radar, Book-Referencing, Reference Previews

Tue, Mar 2

phuedx awarded T274105: Consolidate popup types a Like token.
Tue, Mar 2, 2:46 PM · Readers-Web-Backlog, Reference Previews, Page-Previews, WMDE-Technical-Wishes-Maintenance
phuedx added a comment to T276112: Regression: Page Previews and Reference Previews tip triangle is in the wrong location in RTL wikis.

Could this be caused by the styles in rEPOP7b0937c5a865: Use CSS clip-path instead of SVG when supported. not being flipped by CSSJanus?

Tue, Mar 2, 2:40 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Performance-Team, Readers-Web-Backlog (Kanbanana-FY-2020-21), Page-Previews, RTL, I18n
phuedx placed T249297: Deploy the new Vue.js search experience up for grabs.
Tue, Mar 2, 2:19 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search), Desktop Improvements
phuedx updated the task description for T249297: Deploy the new Vue.js search experience.
Tue, Mar 2, 2:18 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search), Desktop Improvements
phuedx moved T249826: Feed Vue.js run time errors to error intake system from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Tue, Mar 2, 2:18 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)
phuedx added a comment to T275807: Create harness for the language switcher A/B test.

Nice work on the proof of concept!

Tue, Mar 2, 10:57 AM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Vector, Desktop Improvements
phuedx added a comment to T275807: Create harness for the language switcher A/B test.

Is old treatment languages in the sidebar? Is new treatment language in the header?

Readers Web will be A/B testing the existing treatment of the language switcher and a new treatment being worked on as part of Desktop Improvements. The initial cohort will be all users (not just logged-in users).

Note, given the old and new treatment require HTML changes I think an A/B test could only feasibly be run here for logged in users.

Tue, Mar 2, 10:55 AM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Vector, Desktop Improvements

Mon, Mar 1

phuedx updated the task description for T262093: MoveLeadParagraphTransformInfobox should be rewritten to be more similar to mobile apps.
Mon, Mar 1, 5:33 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Readers-Web-Backlog (Kanbanana-FY-2020-21), MobileFrontend
phuedx moved T210106: Provide a reusable getEditCountBucket function for analytics purposes from Doing to Needs Analysis on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.

I'm actually going to move this one back into Needs Analysis. AFAICT @awight's approach in rEEVLaca489f139cd: User edit count bucketing is one @Krinkle advised against in T210106#5829916 so we should probably chat about it.

Mon, Mar 1, 2:07 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Analytics-Radar, Patch-For-Review, Front-end-Standards-Group, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents
phuedx moved T210106: Provide a reusable getEditCountBucket function for analytics purposes from Upcoming to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Mon, Mar 1, 11:33 AM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Analytics-Radar, Patch-For-Review, Front-end-Standards-Group, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents

Fri, Feb 26

phuedx added a comment to T275766: Log sessionID, isAnon, editBucketCount, and selectedLanguage properties in the UniversalLanguageSelector instrument.

I think once T275766#6862597 is clarified (via an addition to acceptance criteria) this should be moved into upcoming for estimation.

Fri, Feb 26, 4:14 PM · MediaWiki-extensions-WikimediaEvents, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vector, Desktop Improvements
phuedx added a project to T275894: Migrate UniversalLanguageSelector instrument to WikimediaEvents extension: Readers-Web-Backlog.
Fri, Feb 26, 4:13 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-extensions-WikimediaEvents, UniversalLanguageSelector
phuedx created T275894: Migrate UniversalLanguageSelector instrument to WikimediaEvents extension.
Fri, Feb 26, 4:12 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-extensions-WikimediaEvents, UniversalLanguageSelector
phuedx updated subscribers of T275794: Log time on page before switching language as part of the UniversalLanguageSelector instrument.

If my understanding is correct, using time the page was open might include instances where the page is just open in the background during tabbed browsing. This could skew our results and understanding of how long a user is actually viewing the page before they switch languages.

Fri, Feb 26, 11:13 AM · MediaWiki-extensions-WikimediaEvents, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vector, Desktop Improvements
phuedx updated the task description for T275794: Log time on page before switching language as part of the UniversalLanguageSelector instrument.
Fri, Feb 26, 11:12 AM · MediaWiki-extensions-WikimediaEvents, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vector, Desktop Improvements
phuedx reopened T210106: Provide a reusable getEditCountBucket function for analytics purposes as "Open".

Sorry I wasn't aware of this task until now, and may have duplicated some work. In patch aca489f139cd13df, I added code to the EventLogging extension which makes wgUserEditCountBucket available from JS, and EventLoggingServices::getInstance()->getUserBucketProvider()->getUserEditCountBucket( $user ) from the backend.

Fri, Feb 26, 10:29 AM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Analytics-Radar, Patch-For-Review, Front-end-Standards-Group, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents

Thu, Feb 25

phuedx placed T268504: [SPIKE 24hrs] Instrument language button up for grabs.
Thu, Feb 25, 6:39 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx moved T268504: [SPIKE 24hrs] Instrument language button from Doing to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Thu, Feb 25, 6:39 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx updated the task description for T268504: [SPIKE 24hrs] Instrument language button.
Thu, Feb 25, 6:38 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx created T275807: Create harness for the language switcher A/B test.
Thu, Feb 25, 6:38 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Vector, Desktop Improvements
phuedx closed T210106: Provide a reusable getEditCountBucket function for analytics purposes as Resolved.

Yes! Thanks for the ping, @Jdlrobson.

Thu, Feb 25, 4:31 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Analytics-Radar, Patch-For-Review, Front-end-Standards-Group, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents
phuedx updated the task description for T268504: [SPIKE 24hrs] Instrument language button.
Thu, Feb 25, 4:28 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx created T275794: Log time on page before switching language as part of the UniversalLanguageSelector instrument.
Thu, Feb 25, 4:26 PM · MediaWiki-extensions-WikimediaEvents, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vector, Desktop Improvements
phuedx updated the task description for T268504: [SPIKE 24hrs] Instrument language button.
Thu, Feb 25, 1:42 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx added a project to T275766: Log sessionID, isAnon, editBucketCount, and selectedLanguage properties in the UniversalLanguageSelector instrument: Vector.
Thu, Feb 25, 1:41 PM · MediaWiki-extensions-WikimediaEvents, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vector, Desktop Improvements
phuedx created T275766: Log sessionID, isAnon, editBucketCount, and selectedLanguage properties in the UniversalLanguageSelector instrument.
Thu, Feb 25, 1:41 PM · MediaWiki-extensions-WikimediaEvents, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vector, Desktop Improvements
phuedx updated the task description for T268504: [SPIKE 24hrs] Instrument language button.
Thu, Feb 25, 1:21 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx updated the task description for T268504: [SPIKE 24hrs] Instrument language button.
Thu, Feb 25, 1:20 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx created T275762: Instrument clicks to links in the Languages list in the sidebar.
Thu, Feb 25, 1:18 PM · MediaWiki-extensions-WikimediaEvents, Vector, Desktop Improvements

Tue, Feb 23

phuedx reassigned T218835: prefUpdate schema contains multiple identical events for the same preference update from phuedx to polishdeveloper.
Tue, Feb 23, 4:29 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Better Use Of Data, Product-Data-Infrastructure, Analytics-Radar, Product-Analytics

Mon, Feb 22

phuedx moved T268504: [SPIKE 24hrs] Instrument language button from Ready for Signoff to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Mon, Feb 22, 6:13 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx placed T249826: Feed Vue.js run time errors to error intake system up for grabs.
Mon, Feb 22, 6:03 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)
phuedx claimed T218835: prefUpdate schema contains multiple identical events for the same preference update.
Mon, Feb 22, 6:03 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Better Use Of Data, Product-Data-Infrastructure, Analytics-Radar, Product-Analytics
phuedx moved T272991: Add edit buckets to search satisfaction schema from Needs QA to Needs QA in Prod on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.

@Edtadros: If you have access to Hue (i.e. you've signed an NDA and you're in the nda LDAP group, then you should be able to test this. Alternatively, @MNeisler or I could.

Mon, Feb 22, 5:20 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
phuedx added a comment to T272991: Add edit buckets to search satisfaction schema.

Regrettably, this will have to tested by checking data in the event.searchsatisfaction Hive table once the change has gone live – it'll be deployed to the group0 wikis tomorrow – as there's no way to override the sampling code that enables the SearchSatisfaction instrument.

Mon, Feb 22, 4:29 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
phuedx assigned T272991: Add edit buckets to search satisfaction schema to Edtadros.
Mon, Feb 22, 4:00 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
phuedx moved T249826: Feed Vue.js run time errors to error intake system from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Mon, Feb 22, 3:59 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)

Tue, Feb 16

phuedx added a comment to T253634: Convert WikimediaEvents to use ResourceLoader packageFiles.

Excellent! I'd asked @Mholloway if he was looking for a merger just the other day. Great work, everyone!

Tue, Feb 16, 4:29 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Better Use Of Data, Performance-Team (Radar), Analytics, Event-Platform
phuedx added a comment to T273090: Deploy modern Vector and new Vue.js search experience to new pilot wikis.

From an engineering perspective only, this is roughly an S – it's a one-line config change and deployment. The config change is as follows:

Tue, Feb 16, 11:31 AM · Bengali-Sites, Serbian-Sites, Turkish-Sites, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search), Desktop Improvements
phuedx added a comment to T259798: Deploy the new Vue.js search experience to the Beta-Cluster and Test Wikipedia.

I've scheduled the above for deployment.

Tue, Feb 16, 11:01 AM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)

Mon, Feb 15

phuedx added a comment to T272991: Add edit buckets to search satisfaction schema.

We might want to revisit reusing the user edit count bucketing code again. However, code reuse and testing in possible but non-trivial in the WikimediaEvents, which is geared towards isolated modules that do everything that they need.

Mon, Feb 15, 6:21 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
phuedx updated the task description for T268504: [SPIKE 24hrs] Instrument language button.
Mon, Feb 15, 4:07 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx added a comment to T268504: [SPIKE 24hrs] Instrument language button.

Thanks, @nshahquinn-wmf!

Mon, Feb 15, 2:34 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)

Fri, Feb 12

phuedx moved T249826: Feed Vue.js run time errors to error intake system from Blocked on Others to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Fri, Feb 12, 4:14 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)
phuedx updated the task description for T268504: [SPIKE 24hrs] Instrument language button.
Fri, Feb 12, 3:06 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx added a comment to T268504: [SPIKE 24hrs] Instrument language button.

Instrumentation: Initial and final language
At the time of writing, the UniversalLanguageSelector instrument sets the interfaceLanguage property to the final language for language-change events. However, for all other events, the interfaceLanguage property is set to the initial language.
We could infer the initial language from the domain of the intake URL, which is logged as the event.meta.domain field.

Could the initial language also be inferred from the event.ContentLanguage field for language-change events? Either way, I agree with the addition of the selectedLanguageproperty to clarify the final language selection for events.

Fri, Feb 12, 2:40 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)

Thu, Feb 11

phuedx moved T274428: Handling of talk page notification from Incoming to Triaged but Future on the Readers-Web-Backlog board.
Thu, Feb 11, 5:38 PM · RW-Feature-DI-User-Menu, Readers-Web-Backlog, Desktop Improvements
phuedx reassigned T270796: Message boxes classes should carry `mw-` from Volker_E to ovasileva.
Thu, Feb 11, 5:21 PM · Readers-Web-Backlog, User-notice, MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Tech-Ambassadors, MediaWiki-Installer, MediaWiki-General, CSS
phuedx moved T274489: Extra character (-) in the title of the Main page for unregistered users in the mobile version from Needs triage to MinervaNeue on the Mobile board.
Thu, Feb 11, 5:12 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Mobile, MobileFrontend
phuedx moved T274489: Extra character (-) in the title of the Main page for unregistered users in the mobile version from Incoming to Needs Prioritization on the Readers-Web-Backlog board.

/cc @ovasileva

Thu, Feb 11, 5:09 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Mobile, MobileFrontend
phuedx added a project to T274489: Extra character (-) in the title of the Main page for unregistered users in the mobile version: Readers-Web-Backlog.
Thu, Feb 11, 5:08 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Mobile, MobileFrontend

Wed, Feb 10

phuedx added a comment to T274210: [Regression] some beta cluster wikis using official logos.

If I'm reading correctly, it looks like InitialiseSettings-labs.php can override keys in InitialiseSettings.php provided the keys are prefixed with "-" is that right? That said I've made mistakes hereb efore.

So in the case of https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/InitialiseSettings-labs.php#L372-L384 the reason the logo doesn't apply to https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page?useskinversion=1 is because no entry for 'wikipedia' has been defined and wmgSiteLogo1x should be -wmgSiteLogo1x ... am I reading that correctly?

Wed, Feb 10, 5:02 PM · Release-Engineering-Team-TODO, Readers-Web-Backlog (Kanbanana-FY-2020-21), Wikimedia-Site-requests, Vector (Vector (Tracking)), Regression, Beta-Cluster-Infrastructure
phuedx added a comment to T268504: [SPIKE 24hrs] Instrument language button.

AC: Allow logged-in (logged-out users nice to have) to be bucketed into either the new treatment or the control

Logged-in and -out users

We can't bucket logged-out users on the server, which introduces a number of complications:

  1. We'll have to deliver the page in an "undefined" state until we can make a determination. Since all JavaScript is loaded asynchronously so as not to block the initial rendering of the page, there'll be a small delay until either treatment is available to the user, i.e. there's a small risk that a user who has previously expanded the sidebar, might see a list of 300+ languages suddenly appearing – I've judged the risk as small because the sidebar is collapsed by default for anonymous users with fresh sessions (and sessions are highly likely to be refreshed after seven days).

If we do end up bucketing anon users though, would we use the same client-side code to bucket logged-in users? (where I think the sidebar is open by default, and I would think 300+ languages suddenly appearing in the sidebar would be more noticeable)?

Wed, Feb 10, 4:06 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx added a comment to T268504: [SPIKE 24hrs] Instrument language button.

Thank you @phuedx for the great detailed notes!

@alexhollender and I discussed this on Thursday and agreed that hiding the language list in the sidebar and hiding the language switcher until the user is bucketed is the simplest solution from both a design and engineering perspective.

Could you elaborate on how you envision this working for no-js users just so I'm on the same page? Were you envisioning the server would render the language list in the sidebar (the status quo), the language button in the body header but with an empty .vector-menu-content-list list, and we would use the client-js class to hide both of these before the JS executes? If the user is bucketed in the body header group on the client then ULS would use the list of languages in the sidebar for its data?

Wed, Feb 10, 4:04 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx updated subscribers of T268504: [SPIKE 24hrs] Instrument language button.
Wed, Feb 10, 3:40 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)

Tue, Feb 9

phuedx moved T249826: Feed Vue.js run time errors to error intake system from Needs More Work to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Tue, Feb 9, 5:56 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)

Mon, Feb 8

phuedx moved T268504: [SPIKE 24hrs] Instrument language button from Needs Design Review to Needs Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Mon, Feb 8, 11:22 AM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx added a comment to T268504: [SPIKE 24hrs] Instrument language button.

Questions from Sam: Is it worth thinking about the affect on the a/b test? Is there a design treatment that is an ambiguous state we send to everyone?

Mon, Feb 8, 11:22 AM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx moved T257579: Security Readiness Review For WVUI and Vector dependencies needed for Vue.js search from Blocked on Others to Ready for Development on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Mon, Feb 8, 10:32 AM · Security Readiness Reviews, WVUI, Readers-Web-Backlog (Kanbanana-FY-2020-21), user-sbassett, secscrum, Security, Vue.js (Vue.js-Search)
phuedx added a comment to T272530: Adding a graph to a page doubles JS payload on mobile and desktop.

First of all, how dated are the versions of Vega we're using for this? Maybe newer ones are leaner or more modular.

Is the JS only required for interaction? I thought it was needed for rendering too. If only needed for interaction, then waiting for user interaction makes total sense.

Mon, Feb 8, 10:24 AM · Performance-Team (Radar), Readers-Web-Backlog (Tracking), Mobile, MediaWiki-extensions-Graph

Thu, Feb 4

phuedx updated the task description for T268504: [SPIKE 24hrs] Instrument language button.
Thu, Feb 4, 3:08 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx added a comment to T268504: [SPIKE 24hrs] Instrument language button.

Instrument: Clicks to language list in control group

Thu, Feb 4, 3:07 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx updated the task description for T268504: [SPIKE 24hrs] Instrument language button.
Thu, Feb 4, 1:57 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx updated the task description for T268504: [SPIKE 24hrs] Instrument language button.
Thu, Feb 4, 1:38 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx added a comment to T268504: [SPIKE 24hrs] Instrument language button.

Instrumentation: Time on page prior to switching to a different language

Thu, Feb 4, 1:38 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)

Wed, Feb 3

phuedx moved T268504: [SPIKE 24hrs] Instrument language button from Doing to Needs Design Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Wed, Feb 3, 5:17 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx added a comment to T261647: Set up A/B test for new search widget.

☝️ Per our discussion yesterday, we'll sign this off now and test the change after we've enabled the A/B test on the Beta Cluster.

Wed, Feb 3, 5:08 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)

Feb 2 2021

phuedx updated the task description for T268504: [SPIKE 24hrs] Instrument language button.
Feb 2 2021, 5:58 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx updated the task description for T268504: [SPIKE 24hrs] Instrument language button.
Feb 2 2021, 5:41 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx updated the task description for T268504: [SPIKE 24hrs] Instrument language button.
Feb 2 2021, 5:40 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx updated the task description for T268504: [SPIKE 24hrs] Instrument language button.
Feb 2 2021, 5:39 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx added a comment to T268504: [SPIKE 24hrs] Instrument language button.

Instrumentation: Initial and final language

Feb 2 2021, 5:38 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx updated the task description for T268504: [SPIKE 24hrs] Instrument language button.
Feb 2 2021, 4:32 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx added a comment to T268504: [SPIKE 24hrs] Instrument language button.

Instrumentation: Number of new users accessing language switching functionality

Feb 2 2021, 4:31 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx updated the task description for T268504: [SPIKE 24hrs] Instrument language button.
Feb 2 2021, 2:53 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx added a comment to T268504: [SPIKE 24hrs] Instrument language button.

Instrumentation: Clicks to new button

Feb 2 2021, 2:53 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx updated the task description for T268504: [SPIKE 24hrs] Instrument language button.
Feb 2 2021, 2:36 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx added a comment to T268504: [SPIKE 24hrs] Instrument language button.

AC: Allow logged-in (logged-out users nice to have) to be bucketed into either the new treatment or the control

Feb 2 2021, 2:36 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
phuedx updated the task description for T268504: [SPIKE 24hrs] Instrument language button.
Feb 2 2021, 1:12 PM · Product-Analytics, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)