Page MenuHomePhabricator

[JS, PHP] Add performer.is_temp as a contextual attribute
Open, Needs TriagePublic

Description

Description

performer.is_temp is a contextual attribute that is already included at the common schema (https://schema.wikimedia.org/repositories//secondary/jsonschema/fragment/analytics/product_metrics/common/current.yaml). It was also included to the Java MP library but there is nothing about it neither for the JS and PHP ones nor the EventLogging extension.

This field must be added as a contextual attribute for the JS and PHP MP libraries and for the EventLogging extension.

Acceptance criteria

  • performer.is_temp has been added to the JS Metrics Platform library
  • performer.is_temp has been added to the PHP Metrics Platform library
  • performer.is_temp has been added to the EventLogging extension

Required

  • Unit/Integration tests
  • Documentation
  • Passed QA

Event Timeline

Sfaci renamed this task from [JS] Add performer.is_temp contextual attribute to [JS, PHP] Add performer.is_temp contextual attribute.Mon, Jun 24, 2:35 PM
Sfaci renamed this task from [JS, PHP] Add performer.is_temp contextual attribute to [JS, PHP] Add performer.is_temp as a contextual attribute.Mon, Jun 24, 2:40 PM
Sfaci updated the task description. (Show Details)
Sfaci updated the task description. (Show Details)

The MR to add performer.is_temp to the JS and PHP MP libraries is ready to be reviewed: https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/merge_requests/61

Change #1049259 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[mediawiki/extensions/EventLogging@master] lib: Update lib/metrics-platform to e959228f

https://gerrit.wikimedia.org/r/1049259

Sfaci updated the task description. (Show Details)

Change #1048358 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/EventLogging@master] lib: Update metrics-platform to v4.2.1

https://gerrit.wikimedia.org/r/1048358

Change #1048358 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] lib: Update metrics-platform to v4.2.1

https://gerrit.wikimedia.org/r/1048358

Change #1049259 abandoned by Santiago Faci:

[mediawiki/extensions/EventLogging@master] lib: Update lib/metrics-platform to e959228f

Reason:

All these changes were included https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventLogging/+/1048358

https://gerrit.wikimedia.org/r/1049259

Change #1049567 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[mediawiki/vendor@master] Update wikimedia/metrics-platform to 4.2.1

https://gerrit.wikimedia.org/r/1049567

Change #1049567 merged by jenkins-bot:

[mediawiki/vendor@master] Update wikimedia/metrics-platform to 4.2.1

https://gerrit.wikimedia.org/r/1049567