AC
- A unit test is added to the org.wikimedia.metrics_platform.SamplingController tests that proves that
if a pageview/session/device is in-sample at a 1% rate, then it should be in-sample at any greater rate, e.g. 5%, 10%, 25%, 50%, etc.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | phuedx | T304379 Non-deterministic unit test "streamInSample() - session sampling resets" | |||
| Open | None | T355052 [EPIC] Increase coverage of sampling tests | |||
| Open | None | T355055 [Java] Increase coverage of SamplingController tests |
Event Timeline
Comment Actions
@phuedx Could you please elaborate the issue little more. would love to work on it.
~ Thanks.
Comment Actions
Hello.
There are tests for the following scenarios:
- There's no sample config
- There's a sample config with a rate of 100% (all devices are in-sample)
- There's a sample config with a rate of 0% (no devices is in-sample)
There's no test that provides that a device in-sample at a rate of 1% is also in-sample at a rate of 5%, 10%, etc.
To prove that this is true, we need to:
- Find a device ID that is in-sample for a sample config with a rate of 1%
- Iterate over rates of 1% to 100% and assert that the device ID is in-sample for a sample config with each rate
If you're looking for more context about this task, please see the parent epic (T355052) and linked task (T304379).