AC
- A unit test is added to the org.wikimedia.metrics_platform.SamplingController tests that proves that
if a pageview/session/device is in-sample at a 1% rate, then it should be in-sample at any greater rate, e.g. 5%, 10%, 25%, 50%, etc.
Description
Description
Details
Details
Related Changes in GitLab:
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| Add testcase for SamplingController | repos/data-engineering/metrics-platform!106 | sanjaisiddharthan | T355055 | main |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | phuedx | T304379 Non-deterministic unit test "streamInSample() - session sampling resets" | |||
| Open | None | T355052 [EPIC] Increase coverage of sampling tests | |||
| Declined | sanjaisid | T355055 [Java] Increase coverage of SamplingController tests |
Event Timeline
Comment Actions
@phuedx Could you please elaborate the issue little more. would love to work on it.
~ Thanks.
Comment Actions
Hello.
There are tests for the following scenarios:
- There's no sample config
- There's a sample config with a rate of 100% (all devices are in-sample)
- There's a sample config with a rate of 0% (no devices is in-sample)
There's no test that provides that a device in-sample at a rate of 1% is also in-sample at a rate of 5%, 10%, etc.
To prove that this is true, we need to:
- Find a device ID that is in-sample for a sample config with a rate of 1%
- Iterate over rates of 1% to 100% and assert that the device ID is in-sample for a sample config with each rate
If you're looking for more context about this task, please see the parent epic (T355052) and linked task (T304379).
Comment Actions
@VirginiaPoundstone: This seems to be about the Metrics Platform code base thus re-adding that code base project tag.
Comment Actions
Im interested to work on this but i don't have Gitlab access. Can someone help me with this ??
Comment Actions
sanjaisiddharthan opened https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/merge_requests/106
Add testcase for SamplingController
Comment Actions
@phuedx I have raised MR with the required changes but the pipeline got failed failed due to dockerfile parse error
https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/merge_requests/106
Comment Actions
Welcome @sanjaisid, and thank you for the patch! We chatted as a team and it turns out we may be sunsetting this Java client and rethinking our Android strategy (maybe Kotlin). Apologies that we didn't reflect this sooner by closing this task.
What are you interested in contributing to? Is it specifically Java, testing, or something broader? I'm happy to help match you up with a better task if possible.
Comment Actions
@Milimetric
Thanks for letting me know! I’m open to contributing beyond Java too or perhaps Kotlin or testing areas. Happy to take your guidance on where I could help next!
Comment Actions
Declining this as we're planning on moving the SDK to Kotlin and removing the Java SDK.
@sanjaisid: T401023: [XL] xLab Client Library: Convert to Kotlin and bring into app repo. tracks the move to Kotlin. Please do comment on that task to see if/how you can contribute to the effort. Thank you for your patience while we work through these tasks to reflect our thinking.