Page MenuHomePhabricator

wfAbruptExit in GlobalFunctions.php seems to make incorrect assumption about PHP's debug_backtrace() function
Closed, ResolvedPublic

Description

Author: nickpj

Description:
PHP's debug_backtrace() function can produce output that is not handled properly
by the wfAbruptExit function.

To illustrate, here is part of the output of doing a var_dump($bt) when running

with the latest PHP4.4 stable CVS snapshot:

     }
    }
  }
}
[12]=>
array(4) {
  ["function"]=>
  string(12) "out_revision"
  ["class"]=>
  string(12) "wikiimporter"
  ["type"]=>
  string(2) "->"
  ["args"]=>
  array(2) {
    [0]=>
    &resource(75) of type (xml)
    [1]=>
    &string(8) "revision"
  }
}
[13]=>
array(4) {
  ["file"]=>
  string(62) "/var/www/hosts/local-wikipedia/wiki/includes/SpecialImport.php"
  ["line"]=>
  int(261)
  ["function"]=>
  string(9) "xml_parse"
  ["args"]=>
  array(3) {
    [0]=>
    &resource(75) of type (xml)
    [1]=>

Note that $bt[12] does not contain a "file" or "line" key.

A 2-line patch will be attached shortly to add handling for this.


Version: 1.5.x
Severity: normal
OS: Windows 2000
Platform: PC

Details

Reference
bz3765

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:53 PM
bzimport set Reference to bz3765.
bzimport added a subscriber: Unknown Object (MLST).

nickpj wrote:

Allow wfAbruptExit to cope with unexpected debug_backtrace() output

Attached: