Page MenuHomePhabricator

#guider_overlay's z-index should be greater than #p-personal's z-index
Closed, ResolvedPublic

Description

The combination of[1]

#guider_overlay {
    /*...*/
    z-index: 10;
}

and[2]

#p-personal {
	/* ... */
	z-index: 100;
}

causes GuidedTour to highlight Echo's #pt-notifications when a step of a tour has "overlay: true". I tested this at [3].

[1] https://github.com/wikimedia/mediawiki-extensions-GuidedTour/blob/master/modules/mediawiki.libs.guiders/mediawiki.libs.guiders.css#L94

[2] https://github.com/wikimedia/mediawiki-core/blob/master/skins/vector/screen.less#L77

[3] https://pt.wikipedia.org/wiki/Especial:Contribui%C3%A7%C3%B5es/Aleph_Bot?tour=contribs


Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=64788

Details

Reference
bz55706

Event Timeline

bzimport raised the priority of this task from to Low.
bzimport set Reference to bz55706.
He7d3r created this task.Oct 14 2013, 5:45 PM

swalling wrote:

Good idea, should be easy?

mailstorpk wrote:

This one seems to be interesting. I would like to work on this bug.Can someone assign this to me.

Change 107333 had a related patch set uploaded by Roopak:
Re-sized #guider_overlay's z-index

https://gerrit.wikimedia.org/r/107333

Change 107333 merged by jenkins-bot:
Re-sized #guider_overlay's z-index

https://gerrit.wikimedia.org/r/107333