Page MenuHomePhabricator

Login captcha shown after too many incorrect attempts to log in looks ugly
Closed, ResolvedPublic


Login captcha (in Polish)

Login captcha shown after too many incorrect attempts to log in looks ugly, compared to the nicely styles create account form captcha.

Version: 1.22.0
Severity: normal
Whiteboard: gci2013


2013-10-30_12_06_24-Zaloguj_się_–_Wikipedia,_wolna_encyklopedia_-_Opera.png (737×328 px, 28 KB)



Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:21 AM
bzimport set Reference to bz56370.
bzimport added a subscriber: Unknown Object (MLST).

Do you refer to the capture itself? Or the red box?

Created attachment 13770
Signup captcha (in Polish), for comparison

I refer to the stuff above the red box. It's not styled consistenyl wirh the rest of the form. I attached similar captcha on the signup form for comparison.


2013-11-12_15_24_26-Załóż_nowe_konto_–_Wikipedia,_wolna_encyklopedia_-_Opera.png (585×335 px, 24 KB)

The signup captcha is being reformatted by a script in mediawiki.special.createAccount.js; we should probably run it for login too.
(Also, that's an awful solution. :( )

Change 98357 had a related patch set uploaded by Jcf2000:
Reformat signin captcha in case of incorrect login

I'm assuming this bug is meant for Extension:ConfirmEdit, since that's where CAPTCHA support is.

Actually the code to format CAPTCHA to look pretty in the new login/signup form is currently in core (which sucks, feel free to fix that).

Ha! Never knew that. Interesting.

Change 98357 merged by jenkins-bot:
Additional styling for CAPTCHA on Special:UserLogin

swalling wrote:

(In reply to comment #8)

Fixed :)

This looks great. Nice work everyone.